-
Notifications
You must be signed in to change notification settings - Fork 485
feat(appsec/proxy): add metrics #4072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a3225ba to
fdb5775
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 82e25fa | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
|
Waiting for the changes merge in dd-go to update the metric values in this PR. |
a7236b2 to
e30f288
Compare
|
Reopened the PR as PR in dd-go merged. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
This PR implement the collection of metrics for appsec proxies:
As the telemetry package is internal and the environment variables are set inside the contribs, the method
TelemetryRegisterAppConfigand the telemetry origin have been exposed inside the instrumentation package.*Related
PR that adds the metrics to dd-go.
Motivation
More visibility into the usage of the product.
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!