Don't update jmxfetch integrations submodule during build #9150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomanderson
added
tag: no release notes
| ./gradlew :dd-java-agent:agent-jmxfetch:submodulesUpdate | ||
| - name: Download ghcommit CLI | ||
| run: | | ||
| curl https://github.com/planetscale/ghcommit/releases/download/v0.1.48/ghcommit_linux_amd64 -o /usr/local/bin/ghcommit -L |
There was a problem hiding this comment.
Just curious if it make sense to use latest version v0.1.73 here?
bric3
reviewed
Jul 10, 2025
|
|
||
| on: | ||
| schedule: | ||
| - cron: '0 0 1 * *' |
There was a problem hiding this comment.
I suggest weekly, early on monday
Suggested change
| - cron: '0 0 1 * *' | |
| - cron: '0 2 * * 1' |
| env: | ||
| GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} | ||
| run: | | ||
| ghcommit --repository ${{ github.repository }} --branch ${{ steps.define-branch.outputs.branch }} --add dd-java-agent/agent-jmxfetch/integrations-core --message "Update agent-jmxfetch submodule" |
There was a problem hiding this comment.
question: Wouldn't it be better to use git itself, rather than using a third party executable ?
There was a problem hiding this comment.
I copied this from another workflow. It's what's used in Update Gradle Dependencies and Update Docker Build Image
bric3
reviewed
Jul 10, 2025
| @@ -97,7 +97,6 @@ tasks.register('copyMetricConfigs', CopyMetricConfigsTask) { | |||
| description 'Copy metrics.yaml files from integrations-core into resources' | |||
| inputDirectory = file("$projectDir/integrations-core") | |||
| outputDirectory = file("$buildDir/integrations-core-resources") | |||
| dependsOn 'submodulesUpdate' | |||
There was a problem hiding this comment.
We may also want to do that during a release.
There was a problem hiding this comment.
No. submodulesUpdate checks out the submodule at the pinned version. It doesn't actually update it to latest.
Gitlab can check out the submodule automatically so it is unneeded to do it in Gradle
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~21a687f7a9, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (994.795 ms) : 0, 994795
Total [baseline] (10.584 s) : 0, 10583515
Agent [candidate] (999.252 ms) : 0, 999252
Total [candidate] (10.571 s) : 0, 10570814
section appsec
Agent [baseline] (1.182 s) : 0, 1182065
Total [baseline] (10.748 s) : 0, 10748264
Agent [candidate] (1.175 s) : 0, 1175216
Total [candidate] (10.767 s) : 0, 10766795
section iast
Agent [baseline] (1.142 s) : 0, 1142288
Total [baseline] (10.923 s) : 0, 10922625
Agent [candidate] (1.135 s) : 0, 1135025
Total [candidate] (10.854 s) : 0, 10853681
section profiling
Agent [baseline] (1.25 s) : 0, 1249984
Total [baseline] (11.065 s) : 0, 11064718
Agent [candidate] (1.246 s) : 0, 1246027
Total [candidate] (10.922 s) : 0, 10922473
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~21a687f7a9, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.858 ms) : 0, 686858
BytebuddyAgent [candidate] (689.067 ms) : 0, 689067
GlobalTracer [baseline] (241.892 ms) : 0, 241892
GlobalTracer [candidate] (243.024 ms) : 0, 243024
AppSec [baseline] (30.358 ms) : 0, 30358
AppSec [candidate] (30.394 ms) : 0, 30394
Debugger [baseline] (6.018 ms) : 0, 6018
Debugger [candidate] (6.01 ms) : 0, 6010
Remote Config [baseline] (676.589 µs) : 0, 677
Remote Config [candidate] (678.505 µs) : 0, 679
Telemetry [baseline] (8.172 ms) : 0, 8172
Telemetry [candidate] (9.032 ms) : 0, 9032
section appsec
BytebuddyAgent [baseline] (716.029 ms) : 0, 716029
BytebuddyAgent [candidate] (709.986 ms) : 0, 709986
GlobalTracer [baseline] (235.976 ms) : 0, 235976
GlobalTracer [candidate] (235.554 ms) : 0, 235554
IAST [baseline] (23.673 ms) : 0, 23673
IAST [candidate] (23.329 ms) : 0, 23329
AppSec [baseline] (171.029 ms) : 0, 171029
AppSec [candidate] (171.091 ms) : 0, 171091
Debugger [baseline] (5.734 ms) : 0, 5734
Debugger [candidate] (5.723 ms) : 0, 5723
Remote Config [baseline] (614.837 µs) : 0, 615
Remote Config [candidate] (605.959 µs) : 0, 606
Telemetry [baseline] (8.043 ms) : 0, 8043
Telemetry [candidate] (8.034 ms) : 0, 8034
section iast
BytebuddyAgent [baseline] (814.168 ms) : 0, 814168
BytebuddyAgent [candidate] (809.249 ms) : 0, 809249
GlobalTracer [baseline] (234.203 ms) : 0, 234203
GlobalTracer [candidate] (232.524 ms) : 0, 232524
IAST [baseline] (27.739 ms) : 0, 27739
IAST [candidate] (27.351 ms) : 0, 27351
AppSec [baseline] (30.735 ms) : 0, 30735
AppSec [candidate] (28.87 ms) : 0, 28870
Debugger [baseline] (5.771 ms) : 0, 5771
Debugger [candidate] (7.577 ms) : 0, 7577
Remote Config [baseline] (594.54 µs) : 0, 595
Remote Config [candidate] (592.391 µs) : 0, 592
Telemetry [baseline] (8.08 ms) : 0, 8080
Telemetry [candidate] (7.969 ms) : 0, 7969
section profiling
BytebuddyAgent [baseline] (680.441 ms) : 0, 680441
BytebuddyAgent [candidate] (678.466 ms) : 0, 678466
GlobalTracer [baseline] (362.642 ms) : 0, 362642
GlobalTracer [candidate] (361.867 ms) : 0, 361867
AppSec [baseline] (32.635 ms) : 0, 32635
AppSec [candidate] (30.843 ms) : 0, 30843
Debugger [baseline] (11.309 ms) : 0, 11309
Debugger [candidate] (11.29 ms) : 0, 11290
Remote Config [baseline] (669.719 µs) : 0, 670
Remote Config [candidate] (669.531 µs) : 0, 670
Telemetry [baseline] (8.825 ms) : 0, 8825
Telemetry [candidate] (9.523 ms) : 0, 9523
ProfilingAgent [baseline] (104.512 ms) : 0, 104512
ProfilingAgent [candidate] (104.535 ms) : 0, 104535
Profiling [baseline] (104.536 ms) : 0, 104536
Profiling [candidate] (104.559 ms) : 0, 104559
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~21a687f7a9, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1000757
Total [baseline] (8.579 s) : 0, 8579404
Agent [candidate] (998.857 ms) : 0, 998857
Total [candidate] (8.609 s) : 0, 8608891
section iast
Agent [baseline] (1.141 s) : 0, 1141108
Total [baseline] (9.301 s) : 0, 9301245
Agent [candidate] (1.134 s) : 0, 1134402
Total [candidate] (9.348 s) : 0, 9347733
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~21a687f7a9, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.453 ms) : 0, 692453
BytebuddyAgent [candidate] (689.612 ms) : 0, 689612
GlobalTracer [baseline] (242.369 ms) : 0, 242369
GlobalTracer [candidate] (243.294 ms) : 0, 243294
AppSec [baseline] (30.089 ms) : 0, 30089
AppSec [candidate] (30.195 ms) : 0, 30195
Debugger [baseline] (6.01 ms) : 0, 6010
Debugger [candidate] (6.01 ms) : 0, 6010
Remote Config [baseline] (688.697 µs) : 0, 689
Remote Config [candidate] (683.812 µs) : 0, 684
Telemetry [baseline] (8.202 ms) : 0, 8202
Telemetry [candidate] (8.221 ms) : 0, 8221
section iast
BytebuddyAgent [baseline] (814.567 ms) : 0, 814567
BytebuddyAgent [candidate] (808.48 ms) : 0, 808480
GlobalTracer [baseline] (233.41 ms) : 0, 233410
GlobalTracer [candidate] (232.933 ms) : 0, 232933
IAST [baseline] (28.283 ms) : 0, 28283
IAST [candidate] (28.914 ms) : 0, 28914
AppSec [baseline] (29.656 ms) : 0, 29656
AppSec [candidate] (28.101 ms) : 0, 28101
Debugger [baseline] (5.773 ms) : 0, 5773
Debugger [candidate] (6.634 ms) : 0, 6634
Remote Config [baseline] (580.208 µs) : 0, 580
Remote Config [candidate] (572.031 µs) : 0, 572
Telemetry [baseline] (7.941 ms) : 0, 7941
Telemetry [candidate] (7.947 ms) : 0, 7947
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 12 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~21a687f7a9, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section baseline
no_agent (4.442 ms) : 4390, 4494
. : milestone, 4442,
iast (9.098 ms) : 8949, 9246
. : milestone, 9098,
iast_FULL (13.884 ms) : 13610, 14159
. : milestone, 13884,
iast_GLOBAL (10.013 ms) : 9842, 10185
. : milestone, 10013,
profiling (8.548 ms) : 8410, 8685
. : milestone, 8548,
tracing (7.381 ms) : 7279, 7483
. : milestone, 7381,
section candidate
no_agent (4.494 ms) : 4442, 4545
. : milestone, 4494,
iast (9.348 ms) : 9196, 9500
. : milestone, 9348,
iast_FULL (13.983 ms) : 13708, 14259
. : milestone, 13983,
iast_GLOBAL (10.173 ms) : 9994, 10352
. : milestone, 10173,
profiling (8.659 ms) : 8515, 8803
. : milestone, 8659,
tracing (7.637 ms) : 7526, 7748
. : milestone, 7637,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~21a687f7a9, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section baseline
no_agent (35.951 ms) : 35668, 36233
. : milestone, 35951,
appsec (47.338 ms) : 46924, 47752
. : milestone, 47338,
code_origins (45.433 ms) : 45041, 45826
. : milestone, 45433,
iast (43.706 ms) : 43320, 44093
. : milestone, 43706,
profiling (46.455 ms) : 46034, 46876
. : milestone, 46455,
tracing (43.674 ms) : 43302, 44047
. : milestone, 43674,
section candidate
no_agent (36.896 ms) : 36589, 37203
. : milestone, 36896,
appsec (48.235 ms) : 47801, 48668
. : milestone, 48235,
code_origins (45.958 ms) : 45550, 46366
. : milestone, 45958,
iast (44.193 ms) : 43813, 44573
. : milestone, 44193,
profiling (47.713 ms) : 47276, 48150
. : milestone, 47713,
tracing (44.757 ms) : 44386, 45129
. : milestone, 44757,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~21a687f7a9, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.404 ms) : 2354, 2455
. : milestone, 2404,
iast (2.19 ms) : 2127, 2253
. : milestone, 2190,
iast_GLOBAL (2.237 ms) : 2174, 2300
. : milestone, 2237,
profiling (2.485 ms) : 2261, 2709
. : milestone, 2485,
tracing (2.007 ms) : 1958, 2055
. : milestone, 2007,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.405 ms) : 2354, 2455
. : milestone, 2405,
iast (2.196 ms) : 2132, 2260
. : milestone, 2196,
iast_GLOBAL (2.224 ms) : 2162, 2287
. : milestone, 2224,
profiling (2.03 ms) : 1979, 2081
. : milestone, 2030,
tracing (2.009 ms) : 1959, 2058
. : milestone, 2009,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~21a687f7a9, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section baseline
no_agent (15.511 s) : 15511000, 15511000
. : milestone, 15511000,
appsec (14.984 s) : 14984000, 14984000
. : milestone, 14984000,
iast (18.573 s) : 18573000, 18573000
. : milestone, 18573000,
iast_GLOBAL (18.147 s) : 18147000, 18147000
. : milestone, 18147000,
profiling (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
tracing (14.904 s) : 14904000, 14904000
. : milestone, 14904000,
section candidate
no_agent (15.358 s) : 15358000, 15358000
. : milestone, 15358000,
appsec (14.837 s) : 14837000, 14837000
. : milestone, 14837000,
iast (18.506 s) : 18506000, 18506000
. : milestone, 18506000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
. : milestone, 17885000,
profiling (15.625 s) : 15625000, 15625000
. : milestone, 15625000,
tracing (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
|
randomanderson
requested review from
colin-higgins
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Removes updating the integrations git submodule from the build and creates a github action to update monthly
Motivation
Updating the submodule takes 30+ seconds and is not worth doing on every build every time.
Additional comments
Not quite sure how to test the workflow since I can only invoke workflows already merged to master
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]