-
Notifications
You must be signed in to change notification settings - Fork 311
Use dd-octo-sts to retrieve github release token #9187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~4cc35a712b, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1037456
Total [baseline] (10.633 s) : 0, 10633191
Agent [candidate] (1.042 s) : 0, 1042492
Total [candidate] (10.59 s) : 0, 10589915
section appsec
Agent [baseline] (1.22 s) : 0, 1219698
Total [baseline] (10.789 s) : 0, 10789201
Agent [candidate] (1.219 s) : 0, 1218941
Total [candidate] (10.844 s) : 0, 10844445
section iast
Agent [baseline] (1.179 s) : 0, 1179168
Total [baseline] (10.937 s) : 0, 10937490
Agent [candidate] (1.173 s) : 0, 1173023
Total [candidate] (10.886 s) : 0, 10886007
section profiling
Agent [baseline] (1.191 s) : 0, 1190878
Total [baseline] (11.01 s) : 0, 11010166
Agent [candidate] (1.191 s) : 0, 1190835
Total [candidate] (10.927 s) : 0, 10926540
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~4cc35a712b, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (728.271 ms) : 0, 728271
BytebuddyAgent [candidate] (731.798 ms) : 0, 731798
GlobalTracer [baseline] (241.213 ms) : 0, 241213
GlobalTracer [candidate] (243.024 ms) : 0, 243024
AppSec [baseline] (30.641 ms) : 0, 30641
AppSec [candidate] (30.36 ms) : 0, 30360
Debugger [baseline] (6.025 ms) : 0, 6025
Debugger [candidate] (5.998 ms) : 0, 5998
Remote Config [baseline] (650.947 µs) : 0, 651
Remote Config [candidate] (645.474 µs) : 0, 645
Telemetry [baseline] (8.261 ms) : 0, 8261
Telemetry [candidate] (8.18 ms) : 0, 8180
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (753.108 ms) : 0, 753108
BytebuddyAgent [candidate] (751.003 ms) : 0, 751003
GlobalTracer [baseline] (234.649 ms) : 0, 234649
GlobalTracer [candidate] (235.582 ms) : 0, 235582
AppSec [baseline] (170.534 ms) : 0, 170534
AppSec [candidate] (169.21 ms) : 0, 169210
Debugger [baseline] (6.377 ms) : 0, 6377
Debugger [candidate] (7.962 ms) : 0, 7962
Remote Config [baseline] (598.362 µs) : 0, 598
Remote Config [candidate] (616.933 µs) : 0, 617
Telemetry [baseline] (8.154 ms) : 0, 8154
Telemetry [candidate] (8.124 ms) : 0, 8124
IAST [baseline] (23.515 ms) : 0, 23515
IAST [candidate] (23.745 ms) : 0, 23745
section iast
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (851.67 ms) : 0, 851670
BytebuddyAgent [candidate] (846.011 ms) : 0, 846011
GlobalTracer [baseline] (231.922 ms) : 0, 231922
GlobalTracer [candidate] (231.659 ms) : 0, 231659
AppSec [baseline] (28.387 ms) : 0, 28387
AppSec [candidate] (26.8 ms) : 0, 26800
Debugger [baseline] (8.502 ms) : 0, 8502
Debugger [candidate] (6.702 ms) : 0, 6702
Remote Config [baseline] (598.765 µs) : 0, 599
Remote Config [candidate] (601.494 µs) : 0, 601
Telemetry [baseline] (7.951 ms) : 0, 7951
Telemetry [candidate] (7.948 ms) : 0, 7948
IAST [baseline] (27.609 ms) : 0, 27609
IAST [candidate] (30.854 ms) : 0, 30854
section profiling
ProfilingAgent [baseline] (104.6 ms) : 0, 104600
ProfilingAgent [candidate] (105.248 ms) : 0, 105248
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.41 ms) : 0, 1410
BytebuddyAgent [baseline] (763.073 ms) : 0, 763073
BytebuddyAgent [candidate] (762.386 ms) : 0, 762386
GlobalTracer [baseline] (221.529 ms) : 0, 221529
GlobalTracer [candidate] (221.232 ms) : 0, 221232
AppSec [baseline] (30.473 ms) : 0, 30473
AppSec [candidate] (30.57 ms) : 0, 30570
Debugger [baseline] (6.34 ms) : 0, 6340
Debugger [candidate] (6.36 ms) : 0, 6360
Remote Config [baseline] (679.364 µs) : 0, 679
Remote Config [candidate] (671.793 µs) : 0, 672
Telemetry [baseline] (14.039 ms) : 0, 14039
Telemetry [candidate] (14.239 ms) : 0, 14239
Profiling [baseline] (104.623 ms) : 0, 104623
Profiling [candidate] (105.273 ms) : 0, 105273
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~4cc35a712b, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042547
Total [baseline] (8.634 s) : 0, 8634429
Agent [candidate] (1.045 s) : 0, 1044705
Total [candidate] (8.639 s) : 0, 8639445
section iast
Agent [baseline] (1.17 s) : 0, 1169692
Total [baseline] (9.267 s) : 0, 9266569
Agent [candidate] (1.17 s) : 0, 1170004
Total [candidate] (9.25 s) : 0, 9250106
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~4cc35a712b, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (733.331 ms) : 0, 733331
BytebuddyAgent [candidate] (733.938 ms) : 0, 733938
GlobalTracer [baseline] (241.457 ms) : 0, 241457
GlobalTracer [candidate] (242.784 ms) : 0, 242784
AppSec [baseline] (30.391 ms) : 0, 30391
AppSec [candidate] (30.525 ms) : 0, 30525
Debugger [baseline] (6.013 ms) : 0, 6013
Debugger [candidate] (6.085 ms) : 0, 6085
Remote Config [baseline] (650.879 µs) : 0, 651
Remote Config [candidate] (648.148 µs) : 0, 648
Telemetry [baseline] (8.206 ms) : 0, 8206
Telemetry [candidate] (8.264 ms) : 0, 8264
section iast
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (844.993 ms) : 0, 844993
BytebuddyAgent [candidate] (844.167 ms) : 0, 844167
GlobalTracer [baseline] (231.6 ms) : 0, 231600
GlobalTracer [candidate] (230.827 ms) : 0, 230827
IAST [baseline] (30.425 ms) : 0, 30425
IAST [candidate] (28.328 ms) : 0, 28328
AppSec [baseline] (26.325 ms) : 0, 26325
AppSec [candidate] (28.323 ms) : 0, 28322
Debugger [baseline] (5.77 ms) : 0, 5770
Debugger [candidate] (7.482 ms) : 0, 7482
Remote Config [baseline] (576.685 µs) : 0, 577
Remote Config [candidate] (585.598 µs) : 0, 586
Telemetry [baseline] (7.854 ms) : 0, 7854
Telemetry [candidate] (7.986 ms) : 0, 7986
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~4cc35a712b, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section baseline
no_agent (37.471 ms) : 37166, 37775
. : milestone, 37471,
appsec (48.309 ms) : 47885, 48733
. : milestone, 48309,
code_origins (44.814 ms) : 44431, 45197
. : milestone, 44814,
iast (45.226 ms) : 44832, 45621
. : milestone, 45226,
profiling (44.956 ms) : 44517, 45395
. : milestone, 44956,
tracing (44.992 ms) : 44607, 45377
. : milestone, 44992,
section candidate
no_agent (37.271 ms) : 36968, 37575
. : milestone, 37271,
appsec (45.645 ms) : 45243, 46047
. : milestone, 45645,
code_origins (45.182 ms) : 44799, 45566
. : milestone, 45182,
iast (45.025 ms) : 44631, 45418
. : milestone, 45025,
profiling (48.517 ms) : 48050, 48984
. : milestone, 48517,
tracing (43.362 ms) : 42986, 43738
. : milestone, 43362,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~4cc35a712b, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section baseline
no_agent (4.477 ms) : 4427, 4526
. : milestone, 4477,
iast (9.276 ms) : 9127, 9426
. : milestone, 9276,
iast_FULL (14.208 ms) : 13924, 14492
. : milestone, 14208,
iast_GLOBAL (10.399 ms) : 10204, 10595
. : milestone, 10399,
profiling (8.658 ms) : 8525, 8791
. : milestone, 8658,
tracing (7.341 ms) : 7239, 7444
. : milestone, 7341,
section candidate
no_agent (4.451 ms) : 4401, 4501
. : milestone, 4451,
iast (9.288 ms) : 9137, 9440
. : milestone, 9288,
iast_FULL (13.606 ms) : 13339, 13872
. : milestone, 13606,
iast_GLOBAL (10.159 ms) : 9983, 10336
. : milestone, 10159,
profiling (8.7 ms) : 8565, 8836
. : milestone, 8700,
tracing (7.473 ms) : 7372, 7575
. : milestone, 7473,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~4cc35a712b, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.624 ms) : 3407, 3840
. : milestone, 3624,
iast (2.179 ms) : 2117, 2241
. : milestone, 2179,
iast_GLOBAL (2.233 ms) : 2170, 2295
. : milestone, 2233,
profiling (2.028 ms) : 1978, 2078
. : milestone, 2028,
tracing (2.005 ms) : 1957, 2053
. : milestone, 2005,
section candidate
no_agent (1.473 ms) : 1461, 1485
. : milestone, 1473,
appsec (3.618 ms) : 3402, 3833
. : milestone, 3618,
iast (2.181 ms) : 2119, 2243
. : milestone, 2181,
iast_GLOBAL (2.224 ms) : 2162, 2287
. : milestone, 2224,
profiling (2.026 ms) : 1976, 2076
. : milestone, 2026,
tracing (2.006 ms) : 1957, 2054
. : milestone, 2006,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~4cc35a712b, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section baseline
no_agent (15.568 s) : 15568000, 15568000
. : milestone, 15568000,
appsec (14.856 s) : 14856000, 14856000
. : milestone, 14856000,
iast (18.782 s) : 18782000, 18782000
. : milestone, 18782000,
iast_GLOBAL (18.085 s) : 18085000, 18085000
. : milestone, 18085000,
profiling (15.299 s) : 15299000, 15299000
. : milestone, 15299000,
tracing (14.664 s) : 14664000, 14664000
. : milestone, 14664000,
section candidate
no_agent (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
appsec (14.834 s) : 14834000, 14834000
. : milestone, 14834000,
iast (18.517 s) : 18517000, 18517000
. : milestone, 18517000,
iast_GLOBAL (17.979 s) : 17979000, 17979000
. : milestone, 17979000,
profiling (15.239 s) : 15239000, 15239000
. : milestone, 15239000,
tracing (14.82 s) : 14820000, 14820000
. : milestone, 14820000,
|
Co-authored-by: Christoph Hamsen <[email protected]>
Co-authored-by: Christoph Hamsen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments. Another review from the R&P is welcome :)
…od that is manually triggered
What Does This Do
Use
dd-octo-sts
to retrieve the github release token. Fall back to our existing method that usesaws ssm
to retrieve a fine-grained PAT if thedd-octo-sts
process fails.Motivation
Leverage
dd-octo-sts
security: https://datadoghq.atlassian.net/wiki/spaces/SECENG/pages/4705912130/DD+Octo+STSAdditional Notes
The trust policy logic is in #9198 . Since policies can only be read from
master
, that PR will need to be merged first.This workflow is based on the dd-octo-sts User Guide example.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-696