-
Notifications
You must be signed in to change notification settings - Fork 312
Default LLM Observability ML Application to Service Name #9415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~f4fe857abf, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053667
Total [baseline] (8.682 s) : 0, 8682133
Agent [candidate] (1.058 s) : 0, 1058155
Total [candidate] (8.644 s) : 0, 8644031
section iast
Agent [baseline] (1.192 s) : 0, 1191936
Total [baseline] (9.384 s) : 0, 9384234
Agent [candidate] (1.19 s) : 0, 1189673
Total [candidate] (9.401 s) : 0, 9401195
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~f4fe857abf, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (736.064 ms) : 0, 736064
BytebuddyAgent [candidate] (740.221 ms) : 0, 740221
GlobalTracer [baseline] (244.12 ms) : 0, 244120
GlobalTracer [candidate] (245.027 ms) : 0, 245027
AppSec [baseline] (30.271 ms) : 0, 30271
AppSec [candidate] (30.312 ms) : 0, 30312
Debugger [baseline] (6.121 ms) : 0, 6121
Debugger [candidate] (6.083 ms) : 0, 6083
Remote Config [baseline] (681.634 µs) : 0, 682
Remote Config [candidate] (677.582 µs) : 0, 678
Telemetry [baseline] (13.871 ms) : 0, 13871
Telemetry [candidate] (13.199 ms) : 0, 13199
section iast
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (861.408 ms) : 0, 861408
BytebuddyAgent [candidate] (859.558 ms) : 0, 859558
GlobalTracer [baseline] (235.484 ms) : 0, 235484
GlobalTracer [candidate] (234.927 ms) : 0, 234927
IAST [baseline] (28.722 ms) : 0, 28722
IAST [candidate] (30.614 ms) : 0, 30614
AppSec [baseline] (27.913 ms) : 0, 27913
AppSec [candidate] (27.05 ms) : 0, 27050
Debugger [baseline] (6.65 ms) : 0, 6650
Debugger [candidate] (5.809 ms) : 0, 5809
Remote Config [baseline] (627.337 µs) : 0, 627
Remote Config [candidate] (616.953 µs) : 0, 617
Telemetry [baseline] (8.435 ms) : 0, 8435
Telemetry [candidate] (8.477 ms) : 0, 8477
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~f4fe857abf, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051456
Total [baseline] (10.8 s) : 0, 10800222
Agent [candidate] (1.052 s) : 0, 1052205
Total [candidate] (10.699 s) : 0, 10698952
section appsec
Agent [baseline] (1.226 s) : 0, 1226103
Total [baseline] (10.866 s) : 0, 10865551
Agent [candidate] (1.23 s) : 0, 1229589
Total [candidate] (10.826 s) : 0, 10826282
section iast
Agent [baseline] (1.197 s) : 0, 1196816
Total [baseline] (11.099 s) : 0, 11099110
Agent [candidate] (1.188 s) : 0, 1187774
Total [candidate] (11.012 s) : 0, 11012447
section profiling
Agent [baseline] (1.201 s) : 0, 1200986
Total [baseline] (10.947 s) : 0, 10946932
Agent [candidate] (1.198 s) : 0, 1197580
Total [candidate] (10.88 s) : 0, 10879748
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~f4fe857abf, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (735.359 ms) : 0, 735359
BytebuddyAgent [candidate] (735.413 ms) : 0, 735413
GlobalTracer [baseline] (243.526 ms) : 0, 243526
GlobalTracer [candidate] (243.682 ms) : 0, 243682
AppSec [baseline] (30.24 ms) : 0, 30240
AppSec [candidate] (30.136 ms) : 0, 30136
Debugger [baseline] (6.067 ms) : 0, 6067
Debugger [candidate] (6.045 ms) : 0, 6045
Remote Config [baseline] (684.402 µs) : 0, 684
Remote Config [candidate] (663.889 µs) : 0, 664
Telemetry [baseline] (12.952 ms) : 0, 12952
Telemetry [candidate] (13.676 ms) : 0, 13676
section appsec
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (757.279 ms) : 0, 757279
BytebuddyAgent [candidate] (759.788 ms) : 0, 759788
GlobalTracer [baseline] (235.679 ms) : 0, 235679
GlobalTracer [candidate] (236.474 ms) : 0, 236474
IAST [baseline] (23.575 ms) : 0, 23575
IAST [candidate] (23.591 ms) : 0, 23591
AppSec [baseline] (171.958 ms) : 0, 171958
AppSec [candidate] (170.548 ms) : 0, 170548
Debugger [baseline] (5.821 ms) : 0, 5821
Debugger [candidate] (6.584 ms) : 0, 6584
Remote Config [baseline] (642.636 µs) : 0, 643
Remote Config [candidate] (646.054 µs) : 0, 646
Telemetry [baseline] (8.485 ms) : 0, 8485
Telemetry [candidate] (9.273 ms) : 0, 9273
section iast
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (865.139 ms) : 0, 865139
BytebuddyAgent [candidate] (857.273 ms) : 0, 857273
GlobalTracer [baseline] (235.68 ms) : 0, 235680
GlobalTracer [candidate] (234.125 ms) : 0, 234125
IAST [baseline] (28.263 ms) : 0, 28263
IAST [candidate] (30.64 ms) : 0, 30640
AppSec [baseline] (27.376 ms) : 0, 27376
AppSec [candidate] (28.026 ms) : 0, 28026
Debugger [baseline] (8.381 ms) : 0, 8381
Debugger [candidate] (5.843 ms) : 0, 5843
Remote Config [baseline] (632.068 µs) : 0, 632
Remote Config [candidate] (635.891 µs) : 0, 636
Telemetry [baseline] (8.5 ms) : 0, 8500
Telemetry [candidate] (8.503 ms) : 0, 8503
section profiling
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (764.27 ms) : 0, 764270
BytebuddyAgent [candidate] (762.177 ms) : 0, 762177
GlobalTracer [baseline] (223.023 ms) : 0, 223023
GlobalTracer [candidate] (222.866 ms) : 0, 222866
AppSec [baseline] (30.127 ms) : 0, 30127
AppSec [candidate] (29.825 ms) : 0, 29825
Debugger [baseline] (6.304 ms) : 0, 6304
Debugger [candidate] (6.299 ms) : 0, 6299
Remote Config [baseline] (714.242 µs) : 0, 714
Remote Config [candidate] (688.196 µs) : 0, 688
Telemetry [baseline] (16.363 ms) : 0, 16363
Telemetry [candidate] (16.306 ms) : 0, 16306
ProfilingAgent [baseline] (108.191 ms) : 0, 108191
ProfilingAgent [candidate] (107.507 ms) : 0, 107507
Profiling [baseline] (108.862 ms) : 0, 108862
Profiling [candidate] (108.15 ms) : 0, 108150
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~f4fe857abf, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section baseline
no_agent (4.578 ms) : 4520, 4637
. : milestone, 4578,
iast (9.465 ms) : 9301, 9629
. : milestone, 9465,
iast_FULL (14.176 ms) : 13894, 14459
. : milestone, 14176,
iast_GLOBAL (10.294 ms) : 10112, 10476
. : milestone, 10294,
profiling (9.103 ms) : 8963, 9244
. : milestone, 9103,
tracing (7.41 ms) : 7299, 7520
. : milestone, 7410,
section candidate
no_agent (4.241 ms) : 4195, 4288
. : milestone, 4241,
iast (9.507 ms) : 9346, 9668
. : milestone, 9507,
iast_FULL (14.306 ms) : 14020, 14593
. : milestone, 14306,
iast_GLOBAL (10.056 ms) : 9865, 10248
. : milestone, 10056,
profiling (9.005 ms) : 8858, 9152
. : milestone, 9005,
tracing (7.616 ms) : 7498, 7734
. : milestone, 7616,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~f4fe857abf, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section baseline
no_agent (39.038 ms) : 38728, 39349
. : milestone, 39038,
appsec (47.192 ms) : 46789, 47595
. : milestone, 47192,
code_origins (45.493 ms) : 45099, 45886
. : milestone, 45493,
iast (44.945 ms) : 44544, 45346
. : milestone, 44945,
profiling (47.77 ms) : 47323, 48216
. : milestone, 47770,
tracing (45.652 ms) : 45265, 46039
. : milestone, 45652,
section candidate
no_agent (37.384 ms) : 37075, 37693
. : milestone, 37384,
appsec (48.251 ms) : 47823, 48678
. : milestone, 48251,
code_origins (45.715 ms) : 45309, 46121
. : milestone, 45715,
iast (45.23 ms) : 44837, 45623
. : milestone, 45230,
profiling (48.89 ms) : 48466, 49315
. : milestone, 48890,
tracing (45.982 ms) : 45585, 46378
. : milestone, 45982,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~f4fe857abf, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (3.663 ms) : 3446, 3881
. : milestone, 3663,
iast (2.194 ms) : 2132, 2257
. : milestone, 2194,
iast_GLOBAL (2.243 ms) : 2179, 2306
. : milestone, 2243,
profiling (2.038 ms) : 1988, 2089
. : milestone, 2038,
tracing (2.007 ms) : 1958, 2056
. : milestone, 2007,
section candidate
no_agent (1.472 ms) : 1461, 1483
. : milestone, 1472,
appsec (3.654 ms) : 3435, 3872
. : milestone, 3654,
iast (2.196 ms) : 2133, 2259
. : milestone, 2196,
iast_GLOBAL (2.236 ms) : 2173, 2300
. : milestone, 2236,
profiling (2.488 ms) : 2321, 2656
. : milestone, 2488,
tracing (2.012 ms) : 1963, 2061
. : milestone, 2012,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~f4fe857abf, baseline=1.53.0-SNAPSHOT~030f9bbb36
dateFormat X
axisFormat %s
section baseline
no_agent (14.885 s) : 14885000, 14885000
. : milestone, 14885000,
appsec (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
iast (18.447 s) : 18447000, 18447000
. : milestone, 18447000,
iast_GLOBAL (17.761 s) : 17761000, 17761000
. : milestone, 17761000,
profiling (15.666 s) : 15666000, 15666000
. : milestone, 15666000,
tracing (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
section candidate
no_agent (15.496 s) : 15496000, 15496000
. : milestone, 15496000,
appsec (14.804 s) : 14804000, 14804000
. : milestone, 14804000,
iast (18.206 s) : 18206000, 18206000
. : milestone, 18206000,
iast_GLOBAL (18.166 s) : 18166000, 18166000
. : milestone, 18166000,
profiling (15.27 s) : 15270000, 15270000
. : milestone, 15270000,
tracing (14.884 s) : 14884000, 14884000
. : milestone, 14884000,
|
🎯 Code Coverage 🔗 Commit SHA: f4fe857 | Docs | Was this helpful? Give us feedback! |
What Does This Do
Makes the
-Ddd.llmobs.ml.app
orDD_LLMOBS_ML_APP
configurations optional by removing anIllegalArgumentException
when it is eithernull
or empty, instead defaulting to the service name.Motivation
Easier onboarding for LLM Observability. Often, when there is no clear direction for an ML application configuration, and/or it aligns directly with the service itself, it's more friction to figure out what value ML application should take, especially after seeing a hard exception thrown during configuration when you just want to enable LLM Observability. This change seeks to reduce that friction by just defaulting it to the service name. A user can still set it to something better suited for an ML application description/name, especially if the service hosts multiple ML applications
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: MLOB-3635