-
Notifications
You must be signed in to change notification settings - Fork 312
Activate client stats by default for java 17 services #9463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
🎯 Code Coverage 🔗 Commit SHA: 3146c32 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 6 performance regressions! Performance is the same for 40 metrics, 12 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~3146c32a66, baseline=1.54.0-SNAPSHOT~1f2c16a7e7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046089
Total [baseline] (10.706 s) : 0, 10705871
Agent [candidate] (1.055 s) : 0, 1055271
Total [candidate] (10.688 s) : 0, 10688150
section appsec
Agent [baseline] (1.223 s) : 0, 1222871
Total [baseline] (10.912 s) : 0, 10912268
Agent [candidate] (1.229 s) : 0, 1228597
Total [candidate] (10.869 s) : 0, 10868751
section iast
Agent [baseline] (1.182 s) : 0, 1181952
Total [baseline] (10.966 s) : 0, 10966499
Agent [candidate] (1.212 s) : 0, 1211595
Total [candidate] (10.234 s) : 0, 10234300
section profiling
Agent [baseline] (1.203 s) : 0, 1203436
Total [baseline] (10.917 s) : 0, 10917108
Agent [candidate] (1.207 s) : 0, 1206617
Total [candidate] (10.843 s) : 0, 10842679
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~3146c32a66, baseline=1.54.0-SNAPSHOT~1f2c16a7e7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (729.825 ms) : 0, 729825
BytebuddyAgent [candidate] (728.938 ms) : 0, 728938
GlobalTracer [baseline] (241.764 ms) : 0, 241764
GlobalTracer [candidate] (251.04 ms) : 0, 251040
AppSec [baseline] (30.4 ms) : 0, 30400
AppSec [candidate] (30.324 ms) : 0, 30324
Debugger [baseline] (6.459 ms) : 0, 6459
Debugger [candidate] (6.341 ms) : 0, 6341
Remote Config [baseline] (673.008 µs) : 0, 673
Remote Config [candidate] (684.847 µs) : 0, 685
Telemetry [baseline] (14.429 ms) : 0, 14429
Telemetry [candidate] (15.45 ms) : 0, 15450
section appsec
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (753.771 ms) : 0, 753771
BytebuddyAgent [candidate] (751.768 ms) : 0, 751768
GlobalTracer [baseline] (235.346 ms) : 0, 235346
GlobalTracer [candidate] (244.326 ms) : 0, 244326
IAST [baseline] (23.513 ms) : 0, 23513
IAST [candidate] (23.675 ms) : 0, 23675
AppSec [baseline] (170.013 ms) : 0, 170013
AppSec [candidate] (170.597 ms) : 0, 170597
Debugger [baseline] (6.928 ms) : 0, 6928
Debugger [candidate] (5.961 ms) : 0, 5961
Remote Config [baseline] (650.06 µs) : 0, 650
Remote Config [candidate] (615.831 µs) : 0, 616
Telemetry [baseline] (10.162 ms) : 0, 10162
Telemetry [candidate] (9.184 ms) : 0, 9184
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (851.841 ms) : 0, 851841
BytebuddyAgent [candidate] (870.365 ms) : 0, 870365
GlobalTracer [baseline] (233.324 ms) : 0, 233324
GlobalTracer [candidate] (250.113 ms) : 0, 250113
IAST [baseline] (29.468 ms) : 0, 29468
IAST [candidate] (28.93 ms) : 0, 28930
AppSec [baseline] (27.62 ms) : 0, 27620
AppSec [candidate] (24.647 ms) : 0, 24647
Debugger [baseline] (8.047 ms) : 0, 8047
Debugger [candidate] (6.048 ms) : 0, 6048
Remote Config [baseline] (628.36 µs) : 0, 628
Remote Config [candidate] (606.389 µs) : 0, 606
Telemetry [baseline] (8.474 ms) : 0, 8474
Telemetry [candidate] (8.19 ms) : 0, 8190
section profiling
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (764.328 ms) : 0, 764328
BytebuddyAgent [candidate] (759.862 ms) : 0, 759862
GlobalTracer [baseline] (223.209 ms) : 0, 223209
GlobalTracer [candidate] (232.224 ms) : 0, 232224
AppSec [baseline] (30.699 ms) : 0, 30699
AppSec [candidate] (30.422 ms) : 0, 30422
Debugger [baseline] (6.715 ms) : 0, 6715
Debugger [candidate] (6.726 ms) : 0, 6726
Remote Config [baseline] (775.542 µs) : 0, 776
Remote Config [candidate] (724.546 µs) : 0, 725
Telemetry [baseline] (16.682 ms) : 0, 16682
Telemetry [candidate] (16.628 ms) : 0, 16628
ProfilingAgent [baseline] (108.548 ms) : 0, 108548
ProfilingAgent [candidate] (107.963 ms) : 0, 107963
Profiling [baseline] (109.247 ms) : 0, 109247
Profiling [candidate] (108.644 ms) : 0, 108644
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~3146c32a66, baseline=1.54.0-SNAPSHOT~1f2c16a7e7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055106
Total [baseline] (8.637 s) : 0, 8637460
Agent [candidate] (1.064 s) : 0, 1063875
Total [candidate] (8.623 s) : 0, 8623412
section iast
Agent [baseline] (1.179 s) : 0, 1179141
Total [baseline] (9.33 s) : 0, 9329542
Agent [candidate] (1.189 s) : 0, 1188617
Total [candidate] (9.267 s) : 0, 9267355
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~3146c32a66, baseline=1.54.0-SNAPSHOT~1f2c16a7e7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (737.246 ms) : 0, 737246
BytebuddyAgent [candidate] (733.638 ms) : 0, 733638
GlobalTracer [baseline] (243.986 ms) : 0, 243986
GlobalTracer [candidate] (253.034 ms) : 0, 253034
AppSec [baseline] (30.766 ms) : 0, 30766
AppSec [candidate] (30.933 ms) : 0, 30933
Debugger [baseline] (6.533 ms) : 0, 6533
Debugger [candidate] (6.476 ms) : 0, 6476
Remote Config [baseline] (686.307 µs) : 0, 686
Remote Config [candidate] (698.121 µs) : 0, 698
Telemetry [baseline] (13.313 ms) : 0, 13313
Telemetry [candidate] (16.582 ms) : 0, 16582
section iast
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (850.383 ms) : 0, 850383
BytebuddyAgent [candidate] (850.973 ms) : 0, 850973
GlobalTracer [baseline] (232.923 ms) : 0, 232923
GlobalTracer [candidate] (245.272 ms) : 0, 245272
IAST [baseline] (29.761 ms) : 0, 29761
IAST [candidate] (27.958 ms) : 0, 27958
AppSec [baseline] (27.752 ms) : 0, 27752
AppSec [candidate] (27.167 ms) : 0, 27167
Debugger [baseline] (6.983 ms) : 0, 6983
Debugger [candidate] (6.042 ms) : 0, 6042
Remote Config [baseline] (608.799 µs) : 0, 609
Remote Config [candidate] (613.175 µs) : 0, 613
Telemetry [baseline] (8.33 ms) : 0, 8330
Telemetry [candidate] (8.24 ms) : 0, 8240
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~3146c32a66, baseline=1.54.0-SNAPSHOT~1f2c16a7e7
dateFormat X
axisFormat %s
section baseline
no_agent (4.438 ms) : 4388, 4488
. : milestone, 4438,
iast (9.422 ms) : 9256, 9588
. : milestone, 9422,
iast_FULL (14.503 ms) : 14221, 14785
. : milestone, 14503,
iast_GLOBAL (10.469 ms) : 10272, 10665
. : milestone, 10469,
profiling (9.138 ms) : 8995, 9280
. : milestone, 9138,
tracing (7.815 ms) : 7696, 7935
. : milestone, 7815,
section candidate
no_agent (4.364 ms) : 4313, 4416
. : milestone, 4364,
iast (9.732 ms) : 9569, 9895
. : milestone, 9732,
iast_FULL (13.95 ms) : 13674, 14226
. : milestone, 13950,
iast_GLOBAL (10.57 ms) : 10383, 10757
. : milestone, 10570,
profiling (8.823 ms) : 8675, 8970
. : milestone, 8823,
tracing (7.915 ms) : 7792, 8038
. : milestone, 7915,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~3146c32a66, baseline=1.54.0-SNAPSHOT~1f2c16a7e7
dateFormat X
axisFormat %s
section baseline
no_agent (38.383 ms) : 38076, 38690
. : milestone, 38383,
appsec (48.31 ms) : 47898, 48722
. : milestone, 48310,
code_origins (45.688 ms) : 45286, 46090
. : milestone, 45688,
iast (46.01 ms) : 45614, 46405
. : milestone, 46010,
profiling (50.66 ms) : 50144, 51176
. : milestone, 50660,
tracing (45.708 ms) : 45320, 46097
. : milestone, 45708,
section candidate
no_agent (38.03 ms) : 37725, 38335
. : milestone, 38030,
appsec (48.804 ms) : 48376, 49232
. : milestone, 48804,
code_origins (45.824 ms) : 45431, 46218
. : milestone, 45824,
iast (46.053 ms) : 45651, 46456
. : milestone, 46053,
profiling (48.182 ms) : 47728, 48636
. : milestone, 48182,
tracing (44.709 ms) : 44327, 45091
. : milestone, 44709,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~3146c32a66, baseline=1.54.0-SNAPSHOT~1f2c16a7e7
dateFormat X
axisFormat %s
section baseline
no_agent (15.636 s) : 15636000, 15636000
. : milestone, 15636000,
appsec (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
iast (18.813 s) : 18813000, 18813000
. : milestone, 18813000,
iast_GLOBAL (18.016 s) : 18016000, 18016000
. : milestone, 18016000,
profiling (15.486 s) : 15486000, 15486000
. : milestone, 15486000,
tracing (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
section candidate
no_agent (15.611 s) : 15611000, 15611000
. : milestone, 15611000,
appsec (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
iast (18.907 s) : 18907000, 18907000
. : milestone, 18907000,
iast_GLOBAL (17.97 s) : 17970000, 17970000
. : milestone, 17970000,
profiling (15.436 s) : 15436000, 15436000
. : milestone, 15436000,
tracing (14.997 s) : 14997000, 14997000
. : milestone, 14997000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~3146c32a66, baseline=1.54.0-SNAPSHOT~1f2c16a7e7
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (3.677 ms) : 3463, 3891
. : milestone, 3677,
iast (2.212 ms) : 2149, 2274
. : milestone, 2212,
iast_GLOBAL (2.266 ms) : 2202, 2329
. : milestone, 2266,
profiling (2.069 ms) : 2018, 2121
. : milestone, 2069,
tracing (2.032 ms) : 1983, 2080
. : milestone, 2032,
section candidate
no_agent (1.488 ms) : 1477, 1500
. : milestone, 1488,
appsec (3.722 ms) : 3504, 3941
. : milestone, 3722,
iast (2.211 ms) : 2148, 2273
. : milestone, 2211,
iast_GLOBAL (2.255 ms) : 2192, 2318
. : milestone, 2255,
profiling (2.054 ms) : 2004, 2104
. : milestone, 2054,
tracing (2.028 ms) : 1979, 2076
. : milestone, 2028,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 suggestion: I would add a quick documentation about why Java Version filter is used (as an arbitrary rule for progressive rollout, not related to a Java feature)
d81fda7
to
b15996f
Compare
b15996f
to
2f25ce5
Compare
What Does This Do
Activates CSS by default for java 17 services
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]