Skip to content

Use constant instead of magic values for IsTraceRoot #9465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2025
Merged

Use constant instead of magic values for IsTraceRoot #9465

merged 3 commits into from
Sep 9, 2025

Conversation

bric3
Copy link
Contributor

@bric3 bric3 commented Sep 4, 2025

What Does This Do

Avoid magic values for IsTraceRoot

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bric3 bric3 requested a review from a team as a code owner September 4, 2025 14:14
@bric3 bric3 requested a review from dougqh September 4, 2025 14:14
@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: metrics Metrics labels Sep 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

amarziali
amarziali approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the refactoring

@datadog-official Datadog Official
Copy link

datadog-official bot commented Sep 4, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 57.65% (-0.16%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3d28255 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/istraceroot-magic-values
git_commit_date 1757338973 1757403839
git_commit_sha 03d997e 3d28255
release_version 1.54.0-SNAPSHOT~03d997e2fd 1.54.0-SNAPSHOT~3d282555c6
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757405707 1757405707
ci_job_id 1119886801 1119886801
ci_pipeline_id 75917999 75917999
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-zdftyc5q 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-zdftyc5q 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~3d282555c6, baseline=1.54.0-SNAPSHOT~03d997e2fd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058455
Total [baseline] (10.694 s) : 0, 10693915
Agent [candidate] (1.057 s) : 0, 1057255
Total [candidate] (10.806 s) : 0, 10805584
section appsec
Agent [baseline] (1.233 s) : 0, 1233175
Total [baseline] (10.941 s) : 0, 10940575
Agent [candidate] (1.243 s) : 0, 1243399
Total [candidate] (10.921 s) : 0, 10921452
section iast
Agent [baseline] (1.179 s) : 0, 1179218
Total [baseline] (10.968 s) : 0, 10967852
Agent [candidate] (1.192 s) : 0, 1191936
Total [candidate] (10.935 s) : 0, 10935216
section profiling
Agent [baseline] (1.201 s) : 0, 1200645
Total [baseline] (10.965 s) : 0, 10964582
Agent [candidate] (1.2 s) : 0, 1200116
Total [candidate] (10.914 s) : 0, 10913578
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.233 s 174.72 ms (16.5%)
Agent iast 1.179 s 120.763 ms (11.4%)
Agent profiling 1.201 s 142.19 ms (13.4%)
Total tracing 10.694 s -
Total appsec 10.941 s 246.66 ms (2.3%)
Total iast 10.968 s 273.937 ms (2.6%)
Total profiling 10.965 s 270.667 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent appsec 1.243 s 186.144 ms (17.6%)
Agent iast 1.192 s 134.681 ms (12.7%)
Agent profiling 1.2 s 142.861 ms (13.5%)
Total tracing 10.806 s -
Total appsec 10.921 s 115.867 ms (1.1%)
Total iast 10.935 s 129.632 ms (1.2%)
Total profiling 10.914 s 107.994 ms (1.0%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~3d282555c6, baseline=1.54.0-SNAPSHOT~03d997e2fd

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (741.526 ms) : 0, 741526
BytebuddyAgent [candidate] (738.871 ms) : 0, 738871
GlobalTracer [baseline] (245.081 ms) : 0, 245081
GlobalTracer [candidate] (245.22 ms) : 0, 245220
AppSec [baseline] (30.647 ms) : 0, 30647
AppSec [candidate] (30.538 ms) : 0, 30538
Debugger [baseline] (6.124 ms) : 0, 6124
Debugger [candidate] (6.135 ms) : 0, 6135
Remote Config [baseline] (717.086 µs) : 0, 717
Remote Config [candidate] (689.572 µs) : 0, 690
Telemetry [baseline] (11.542 ms) : 0, 11542
Telemetry [candidate] (13.073 ms) : 0, 13073
section appsec
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (761.14 ms) : 0, 761140
BytebuddyAgent [candidate] (768.827 ms) : 0, 768827
GlobalTracer [baseline] (237.48 ms) : 0, 237480
GlobalTracer [candidate] (239.339 ms) : 0, 239339
IAST [baseline] (23.785 ms) : 0, 23785
IAST [candidate] (24.223 ms) : 0, 24223
AppSec [baseline] (169.827 ms) : 0, 169827
AppSec [candidate] (169.531 ms) : 0, 169531
Debugger [baseline] (7.401 ms) : 0, 7401
Debugger [candidate] (8.783 ms) : 0, 8783
Remote Config [baseline] (628.39 µs) : 0, 628
Remote Config [candidate] (633.832 µs) : 0, 634
Telemetry [baseline] (10.237 ms) : 0, 10237
Telemetry [candidate] (9.289 ms) : 0, 9289
section iast
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (850.872 ms) : 0, 850872
BytebuddyAgent [candidate] (862.752 ms) : 0, 862752
GlobalTracer [baseline] (233.178 ms) : 0, 233178
GlobalTracer [candidate] (234.486 ms) : 0, 234486
IAST [baseline] (29.414 ms) : 0, 29414
IAST [candidate] (29.513 ms) : 0, 29513
AppSec [baseline] (27.684 ms) : 0, 27684
AppSec [candidate] (26.087 ms) : 0, 26087
Debugger [baseline] (6.672 ms) : 0, 6672
Debugger [candidate] (7.585 ms) : 0, 7585
Remote Config [baseline] (599.573 µs) : 0, 600
Remote Config [candidate] (597.448 µs) : 0, 597
Telemetry [baseline] (8.164 ms) : 0, 8164
Telemetry [candidate] (8.218 ms) : 0, 8218
section profiling
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (762.723 ms) : 0, 762723
BytebuddyAgent [candidate] (762.548 ms) : 0, 762548
GlobalTracer [baseline] (223.441 ms) : 0, 223441
GlobalTracer [candidate] (223.133 ms) : 0, 223133
AppSec [baseline] (30.728 ms) : 0, 30728
AppSec [candidate] (30.56 ms) : 0, 30560
Debugger [baseline] (7.01 ms) : 0, 7010
Debugger [candidate] (7.075 ms) : 0, 7075
Remote Config [baseline] (736.509 µs) : 0, 737
Remote Config [candidate] (704.894 µs) : 0, 705
Telemetry [baseline] (15.595 ms) : 0, 15595
Telemetry [candidate] (15.636 ms) : 0, 15636
ProfilingAgent [baseline] (108.356 ms) : 0, 108356
ProfilingAgent [candidate] (108.393 ms) : 0, 108393
Profiling [baseline] (109.013 ms) : 0, 109013
Profiling [candidate] (109.087 ms) : 0, 109087
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~3d282555c6, baseline=1.54.0-SNAPSHOT~03d997e2fd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057143
Total [baseline] (8.681 s) : 0, 8680656
Agent [candidate] (1.051 s) : 0, 1051069
Total [candidate] (8.648 s) : 0, 8647877
section iast
Agent [baseline] (1.186 s) : 0, 1185741
Total [baseline] (9.351 s) : 0, 9350858
Agent [candidate] (1.179 s) : 0, 1178987
Total [candidate] (9.319 s) : 0, 9319455
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.186 s 128.597 ms (12.2%)
Total tracing 8.681 s -
Total iast 9.351 s 670.202 ms (7.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.179 s 127.919 ms (12.2%)
Total tracing 8.648 s -
Total iast 9.319 s 671.578 ms (7.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~3d282555c6, baseline=1.54.0-SNAPSHOT~03d997e2fd

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (738.547 ms) : 0, 738547
BytebuddyAgent [candidate] (735.064 ms) : 0, 735064
GlobalTracer [baseline] (246.411 ms) : 0, 246411
GlobalTracer [candidate] (243.154 ms) : 0, 243154
AppSec [baseline] (30.872 ms) : 0, 30872
AppSec [candidate] (30.359 ms) : 0, 30359
Debugger [baseline] (6.174 ms) : 0, 6174
Debugger [candidate] (6.123 ms) : 0, 6123
Remote Config [baseline] (710.325 µs) : 0, 710
Remote Config [candidate] (687.515 µs) : 0, 688
Telemetry [baseline] (11.785 ms) : 0, 11785
Telemetry [candidate] (13.045 ms) : 0, 13045
section iast
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (856.759 ms) : 0, 856759
BytebuddyAgent [candidate] (851.069 ms) : 0, 851069
GlobalTracer [baseline] (233.544 ms) : 0, 233544
GlobalTracer [candidate] (234.025 ms) : 0, 234025
IAST [baseline] (31.444 ms) : 0, 31444
IAST [candidate] (30.008 ms) : 0, 30008
AppSec [baseline] (26.796 ms) : 0, 26796
AppSec [candidate] (25.235 ms) : 0, 25235
Debugger [baseline] (5.78 ms) : 0, 5780
Debugger [candidate] (6.636 ms) : 0, 6636
Remote Config [baseline] (616.235 µs) : 0, 616
Remote Config [candidate] (583.895 µs) : 0, 584
Telemetry [baseline] (8.241 ms) : 0, 8241
Telemetry [candidate] (9.01 ms) : 0, 9010
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/istraceroot-magic-values
git_commit_date 1757338973 1757403839
git_commit_sha 03d997e 3d28255
release_version 1.54.0-SNAPSHOT~03d997e2fd 1.54.0-SNAPSHOT~3d282555c6
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757405380 1757405380
ci_job_id 1119886802 1119886802
ci_pipeline_id 75917999 75917999
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-9a3eyg0x 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-9a3eyg0x 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:profiling:high_load better
[-520.887µs; -208.251µs] or [-5.783%; -2.312%]		 unstable
[-70.371op/s; +80.979op/s] or [-13.665%; +15.725%]		 8.643ms 520.273op/s 9.008ms 514.969op/s
scenario:load:petclinic:tracing:high_load worse
[+0.911ms; +1.722ms] or [+2.091%; +3.952%]		 unstable
[-10.654op/s; +4.279op/s] or [-9.921%; +3.985%]		 44.896ms 104.200op/s 43.579ms 107.388op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~3d282555c6, baseline=1.54.0-SNAPSHOT~03d997e2fd
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.058 ms) : 35777, 36338
.   : milestone, 36058,
appsec (48.199 ms) : 47774, 48624
.   : milestone, 48199,
code_origins (46.067 ms) : 45663, 46471
.   : milestone, 46067,
iast (45.049 ms) : 44645, 45453
.   : milestone, 45049,
profiling (47.85 ms) : 47393, 48307
.   : milestone, 47850,
tracing (43.579 ms) : 43203, 43955
.   : milestone, 43579,
section candidate
no_agent (36.817 ms) : 36512, 37122
.   : milestone, 36817,
appsec (46.806 ms) : 46383, 47230
.   : milestone, 46806,
code_origins (45.761 ms) : 45367, 46154
.   : milestone, 45761,
iast (45.357 ms) : 44961, 45754
.   : milestone, 45357,
profiling (47.803 ms) : 47350, 48257
.   : milestone, 47803,
tracing (44.896 ms) : 44518, 45274
.   : milestone, 44896,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.058 ms [35.777 ms, 36.338 ms] -
appsec 48.199 ms [47.774 ms, 48.624 ms] 12.142 ms (33.7%)
code_origins 46.067 ms [45.663 ms, 46.471 ms] 10.01 ms (27.8%)
iast 45.049 ms [44.645 ms, 45.453 ms] 8.991 ms (24.9%)
profiling 47.85 ms [47.393 ms, 48.307 ms] 11.792 ms (32.7%)
tracing 43.579 ms [43.203 ms, 43.955 ms] 7.521 ms (20.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.817 ms [36.512 ms, 37.122 ms] -
appsec 46.806 ms [46.383 ms, 47.23 ms] 9.989 ms (27.1%)
code_origins 45.761 ms [45.367 ms, 46.154 ms] 8.944 ms (24.3%)
iast 45.357 ms [44.961 ms, 45.754 ms] 8.54 ms (23.2%)
profiling 47.803 ms [47.35 ms, 48.257 ms] 10.986 ms (29.8%)
tracing 44.896 ms [44.518 ms, 45.274 ms] 8.079 ms (21.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~3d282555c6, baseline=1.54.0-SNAPSHOT~03d997e2fd
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.244 ms) : 4196, 4291
.   : milestone, 4244,
iast (9.559 ms) : 9401, 9716
.   : milestone, 9559,
iast_FULL (13.866 ms) : 13592, 14140
.   : milestone, 13866,
iast_GLOBAL (10.577 ms) : 10376, 10779
.   : milestone, 10577,
profiling (9.008 ms) : 8867, 9148
.   : milestone, 9008,
tracing (7.835 ms) : 7722, 7947
.   : milestone, 7835,
section candidate
no_agent (4.358 ms) : 4305, 4411
.   : milestone, 4358,
iast (9.241 ms) : 9089, 9394
.   : milestone, 9241,
iast_FULL (14.143 ms) : 13856, 14430
.   : milestone, 14143,
iast_GLOBAL (10.219 ms) : 10026, 10412
.   : milestone, 10219,
profiling (8.643 ms) : 8493, 8793
.   : milestone, 8643,
tracing (7.958 ms) : 7844, 8072
.   : milestone, 7958,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.244 ms [4.196 ms, 4.291 ms] -
iast 9.559 ms [9.401 ms, 9.716 ms] 5.315 ms (125.3%)
iast_FULL 13.866 ms [13.592 ms, 14.14 ms] 9.622 ms (226.7%)
iast_GLOBAL 10.577 ms [10.376 ms, 10.779 ms] 6.334 ms (149.3%)
profiling 9.008 ms [8.867 ms, 9.148 ms] 4.764 ms (112.3%)
tracing 7.835 ms [7.722 ms, 7.947 ms] 3.591 ms (84.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.358 ms [4.305 ms, 4.411 ms] -
iast 9.241 ms [9.089 ms, 9.394 ms] 4.884 ms (112.1%)
iast_FULL 14.143 ms [13.856 ms, 14.43 ms] 9.785 ms (224.5%)
iast_GLOBAL 10.219 ms [10.026 ms, 10.412 ms] 5.861 ms (134.5%)
profiling 8.643 ms [8.493 ms, 8.793 ms] 4.285 ms (98.3%)
tracing 7.958 ms [7.844 ms, 8.072 ms] 3.6 ms (82.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/istraceroot-magic-values
git_commit_date 1757338973 1757403839
git_commit_sha 03d997e 3d28255
release_version 1.54.0-SNAPSHOT~03d997e2fd 1.54.0-SNAPSHOT~3d282555c6
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1757405858 1757405858
ci_job_id 1119886803 1119886803
ci_pipeline_id 75917999 75917999
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-tlv1djte 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-tlv1djte 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:dacapo:tomcat:appsec better
[-1.371ms; -1.031ms] or [-37.189%; -27.971%]		 2.485ms 3.686ms
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~3d282555c6, baseline=1.54.0-SNAPSHOT~03d997e2fd
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.566 s) : 15566000, 15566000
.   : milestone, 15566000,
appsec (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
iast (18.541 s) : 18541000, 18541000
.   : milestone, 18541000,
iast_GLOBAL (17.811 s) : 17811000, 17811000
.   : milestone, 17811000,
profiling (15.544 s) : 15544000, 15544000
.   : milestone, 15544000,
tracing (15.098 s) : 15098000, 15098000
.   : milestone, 15098000,
section candidate
no_agent (15.541 s) : 15541000, 15541000
.   : milestone, 15541000,
appsec (14.527 s) : 14527000, 14527000
.   : milestone, 14527000,
iast (18.455 s) : 18455000, 18455000
.   : milestone, 18455000,
iast_GLOBAL (17.835 s) : 17835000, 17835000
.   : milestone, 17835000,
profiling (15.291 s) : 15291000, 15291000
.   : milestone, 15291000,
tracing (14.794 s) : 14794000, 14794000
.   : milestone, 14794000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.566 s [15.566 s, 15.566 s] -
appsec 15.016 s [15.016 s, 15.016 s] -550.0 ms (-3.5%)
iast 18.541 s [18.541 s, 18.541 s] 2.975 s (19.1%)
iast_GLOBAL 17.811 s [17.811 s, 17.811 s] 2.245 s (14.4%)
profiling 15.544 s [15.544 s, 15.544 s] -22.0 ms (-0.1%)
tracing 15.098 s [15.098 s, 15.098 s] -468.0 ms (-3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.541 s [15.541 s, 15.541 s] -
appsec 14.527 s [14.527 s, 14.527 s] -1.014 s (-6.5%)
iast 18.455 s [18.455 s, 18.455 s] 2.914 s (18.8%)
iast_GLOBAL 17.835 s [17.835 s, 17.835 s] 2.294 s (14.8%)
profiling 15.291 s [15.291 s, 15.291 s] -250.0 ms (-1.6%)
tracing 14.794 s [14.794 s, 14.794 s] -747.0 ms (-4.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~3d282555c6, baseline=1.54.0-SNAPSHOT~03d997e2fd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
.   : milestone, 1482,
appsec (3.686 ms) : 3469, 3903
.   : milestone, 3686,
iast (2.21 ms) : 2148, 2273
.   : milestone, 2210,
iast_GLOBAL (2.258 ms) : 2195, 2321
.   : milestone, 2258,
profiling (2.081 ms) : 2029, 2133
.   : milestone, 2081,
tracing (2.046 ms) : 1996, 2095
.   : milestone, 2046,
section candidate
no_agent (1.482 ms) : 1471, 1494
.   : milestone, 1482,
appsec (2.485 ms) : 2432, 2538
.   : milestone, 2485,
iast (2.215 ms) : 2153, 2278
.   : milestone, 2215,
iast_GLOBAL (2.261 ms) : 2198, 2324
.   : milestone, 2261,
profiling (2.048 ms) : 1997, 2098
.   : milestone, 2048,
tracing (2.034 ms) : 1985, 2083
.   : milestone, 2034,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.47 ms, 1.493 ms] -
appsec 3.686 ms [3.469 ms, 3.903 ms] 2.204 ms (148.8%)
iast 2.21 ms [2.148 ms, 2.273 ms] 728.948 µs (49.2%)
iast_GLOBAL 2.258 ms [2.195 ms, 2.321 ms] 776.838 µs (52.4%)
profiling 2.081 ms [2.029 ms, 2.133 ms] 599.764 µs (40.5%)
tracing 2.046 ms [1.996 ms, 2.095 ms] 564.002 µs (38.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.471 ms, 1.494 ms] -
appsec 2.485 ms [2.432 ms, 2.538 ms] 1.003 ms (67.7%)
iast 2.215 ms [2.153 ms, 2.278 ms] 733.149 µs (49.5%)
iast_GLOBAL 2.261 ms [2.198 ms, 2.324 ms] 778.999 µs (52.6%)
profiling 2.048 ms [1.997 ms, 2.098 ms] 565.323 µs (38.1%)
tracing 2.034 ms [1.985 ms, 2.083 ms] 551.609 µs (37.2%)

@bric3
fix: PR Review
59496fc 
Signed-off-by: Brice Dutheil <[email protected]>
@bric3 bric3 force-pushed the bdu/istraceroot-magic-values branch from 1f44294 to 59496fc Compare September 5, 2025 14:14
@bric3 bric3 enabled auto-merge (squash) September 5, 2025 14:18
@bric3 bric3 disabled auto-merge September 8, 2025 07:49
@bric3 bric3 force-pushed the bdu/istraceroot-magic-values branch from 552a807 to 54ca4a7 Compare September 8, 2025 09:18
@bric3 bric3 enabled auto-merge (squash) September 8, 2025 09:43
@bric3 bric3 disabled auto-merge September 8, 2025 09:43
@bric3 bric3 enabled auto-merge (squash) September 8, 2025 09:43
@bric3 bric3 force-pushed the bdu/istraceroot-magic-values branch from 54ca4a7 to e3c92dd Compare September 8, 2025 14:45
@bric3 bric3 force-pushed the bdu/istraceroot-magic-values branch from e3c92dd to 3d28255 Compare September 9, 2025 07:44
@bric3 bric3 merged commit f284153 into master Sep 9, 2025
503 checks passed
@bric3 bric3 deleted the bdu/istraceroot-magic-values branch September 9, 2025 10:12
@github-actions github-actions bot added this to the 1.54.0 milestone Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD left review comments

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: metrics Metrics tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bric3 @amarziali @AlexeyKuznetsov-DD