Error Logs Remediation 2 #9467
Open
Error Logs Remediation 2 #9467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygree
requested review from
jpbempel,
daniel-mohedano,
robertpi,
jandro996,
bric3 and
mcculls
and removed request for
a team
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (320.64 µs) : 294, 348
. : milestone, 321,
basic (283.552 µs) : 277, 290
. : milestone, 284,
loop (8.967 ms) : 8961, 8972
. : milestone, 8967,
section candidate
noprobe (325.821 µs) : 287, 364
. : milestone, 326,
basic (281.061 µs) : 275, 287
. : milestone, 281,
loop (8.971 ms) : 8965, 8976
. : milestone, 8971,
|
|
🎯 Code Coverage 🔗 Commit SHA: b9af27c | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~b9af27cabb, baseline=1.54.0-SNAPSHOT~4abe3ff9a9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050713
Total [baseline] (10.851 s) : 0, 10850617
Agent [candidate] (1.046 s) : 0, 1045799
Total [candidate] (10.716 s) : 0, 10716348
section appsec
Agent [baseline] (1.227 s) : 0, 1227228
Total [baseline] (10.828 s) : 0, 10827658
Agent [candidate] (1.241 s) : 0, 1241388
Total [candidate] (10.87 s) : 0, 10869715
section iast
Agent [baseline] (1.192 s) : 0, 1191726
Total [baseline] (10.952 s) : 0, 10951934
Agent [candidate] (1.182 s) : 0, 1182478
Total [candidate] (11.012 s) : 0, 11012262
section profiling
Agent [baseline] (1.207 s) : 0, 1207036
Total [baseline] (10.947 s) : 0, 10947480
Agent [candidate] (1.212 s) : 0, 1212229
Total [candidate] (10.978 s) : 0, 10977844
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~b9af27cabb, baseline=1.54.0-SNAPSHOT~4abe3ff9a9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (733.798 ms) : 0, 733798
BytebuddyAgent [candidate] (731.993 ms) : 0, 731993
GlobalTracer [baseline] (243.432 ms) : 0, 243432
GlobalTracer [candidate] (242.661 ms) : 0, 242661
AppSec [baseline] (30.202 ms) : 0, 30202
AppSec [candidate] (30.194 ms) : 0, 30194
Debugger [baseline] (6.087 ms) : 0, 6087
Debugger [candidate] (6.092 ms) : 0, 6092
Remote Config [baseline] (696.897 µs) : 0, 697
Remote Config [candidate] (696.208 µs) : 0, 696
Telemetry [baseline] (13.845 ms) : 0, 13845
Telemetry [candidate] (11.513 ms) : 0, 11513
section appsec
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (757.464 ms) : 0, 757464
BytebuddyAgent [candidate] (767.43 ms) : 0, 767430
GlobalTracer [baseline] (236.521 ms) : 0, 236521
GlobalTracer [candidate] (239.06 ms) : 0, 239060
IAST [baseline] (23.777 ms) : 0, 23777
IAST [candidate] (24.112 ms) : 0, 24112
AppSec [baseline] (170.338 ms) : 0, 170338
AppSec [candidate] (169.142 ms) : 0, 169142
Debugger [baseline] (6.527 ms) : 0, 6527
Debugger [candidate] (9.575 ms) : 0, 9575
Remote Config [baseline] (632.673 µs) : 0, 633
Remote Config [candidate] (626.283 µs) : 0, 626
Telemetry [baseline] (9.369 ms) : 0, 9369
Telemetry [candidate] (8.525 ms) : 0, 8525
section iast
crashtracking [baseline] (1.492 ms) : 0, 1492
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (860.668 ms) : 0, 860668
BytebuddyAgent [candidate] (853.504 ms) : 0, 853504
GlobalTracer [baseline] (234.87 ms) : 0, 234870
GlobalTracer [candidate] (233.942 ms) : 0, 233942
IAST [baseline] (29.641 ms) : 0, 29641
IAST [candidate] (31.101 ms) : 0, 31101
AppSec [baseline] (28.059 ms) : 0, 28059
AppSec [candidate] (25.958 ms) : 0, 25958
Debugger [baseline] (6.697 ms) : 0, 6697
Debugger [candidate] (6.646 ms) : 0, 6646
Remote Config [baseline] (618.333 µs) : 0, 618
Remote Config [candidate] (612.555 µs) : 0, 613
Telemetry [baseline] (8.382 ms) : 0, 8382
Telemetry [candidate] (8.203 ms) : 0, 8203
section profiling
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (767.178 ms) : 0, 767178
BytebuddyAgent [candidate] (769.553 ms) : 0, 769553
GlobalTracer [baseline] (224.355 ms) : 0, 224355
GlobalTracer [candidate] (225.779 ms) : 0, 225779
AppSec [baseline] (30.754 ms) : 0, 30754
AppSec [candidate] (31.205 ms) : 0, 31205
Debugger [baseline] (6.308 ms) : 0, 6308
Debugger [candidate] (6.37 ms) : 0, 6370
Remote Config [baseline] (729.143 µs) : 0, 729
Remote Config [candidate] (726.936 µs) : 0, 727
Telemetry [baseline] (16.707 ms) : 0, 16707
Telemetry [candidate] (16.577 ms) : 0, 16577
ProfilingAgent [baseline] (108.657 ms) : 0, 108657
ProfilingAgent [candidate] (109.635 ms) : 0, 109635
Profiling [baseline] (109.326 ms) : 0, 109326
Profiling [candidate] (110.33 ms) : 0, 110330
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~b9af27cabb, baseline=1.54.0-SNAPSHOT~4abe3ff9a9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045531
Total [baseline] (8.666 s) : 0, 8666075
Agent [candidate] (1.052 s) : 0, 1051872
Total [candidate] (8.665 s) : 0, 8665027
section iast
Agent [baseline] (1.186 s) : 0, 1186076
Total [baseline] (9.36 s) : 0, 9359764
Agent [candidate] (1.179 s) : 0, 1178759
Total [candidate] (9.352 s) : 0, 9351962
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~b9af27cabb, baseline=1.54.0-SNAPSHOT~4abe3ff9a9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (732.259 ms) : 0, 732259
BytebuddyAgent [candidate] (735.189 ms) : 0, 735189
GlobalTracer [baseline] (242.908 ms) : 0, 242908
GlobalTracer [candidate] (243.976 ms) : 0, 243976
AppSec [baseline] (30.062 ms) : 0, 30062
AppSec [candidate] (30.238 ms) : 0, 30238
Debugger [baseline] (6.096 ms) : 0, 6096
Debugger [candidate] (6.1 ms) : 0, 6100
Remote Config [baseline] (697.384 µs) : 0, 697
Remote Config [candidate] (690.197 µs) : 0, 690
Telemetry [baseline] (10.941 ms) : 0, 10941
Telemetry [candidate] (13.066 ms) : 0, 13066
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (856.371 ms) : 0, 856371
BytebuddyAgent [candidate] (851.084 ms) : 0, 851084
GlobalTracer [baseline] (234.168 ms) : 0, 234168
GlobalTracer [candidate] (233.978 ms) : 0, 233978
IAST [baseline] (29.598 ms) : 0, 29598
IAST [candidate] (29.045 ms) : 0, 29045
AppSec [baseline] (26.921 ms) : 0, 26921
AppSec [candidate] (27.618 ms) : 0, 27618
Debugger [baseline] (7.514 ms) : 0, 7514
Debugger [candidate] (5.695 ms) : 0, 5695
Remote Config [baseline] (597.223 µs) : 0, 597
Remote Config [candidate] (602.424 µs) : 0, 602
Telemetry [baseline] (8.223 ms) : 0, 8223
Telemetry [candidate] (8.237 ms) : 0, 8237
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b9af27cabb, baseline=1.54.0-SNAPSHOT~4abe3ff9a9
dateFormat X
axisFormat %s
section baseline
no_agent (36.868 ms) : 36566, 37170
. : milestone, 36868,
appsec (47.705 ms) : 47276, 48134
. : milestone, 47705,
code_origins (44.86 ms) : 44462, 45258
. : milestone, 44860,
iast (43.789 ms) : 43415, 44162
. : milestone, 43789,
profiling (48.135 ms) : 47671, 48599
. : milestone, 48135,
tracing (43.482 ms) : 43109, 43855
. : milestone, 43482,
section candidate
no_agent (38.02 ms) : 37713, 38327
. : milestone, 38020,
appsec (47.127 ms) : 46710, 47544
. : milestone, 47127,
code_origins (44.684 ms) : 44282, 45087
. : milestone, 44684,
iast (45.368 ms) : 44978, 45758
. : milestone, 45368,
profiling (48.715 ms) : 48225, 49205
. : milestone, 48715,
tracing (43.614 ms) : 43255, 43974
. : milestone, 43614,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b9af27cabb, baseline=1.54.0-SNAPSHOT~4abe3ff9a9
dateFormat X
axisFormat %s
section baseline
no_agent (4.302 ms) : 4254, 4351
. : milestone, 4302,
iast (9.377 ms) : 9215, 9540
. : milestone, 9377,
iast_FULL (13.66 ms) : 13385, 13935
. : milestone, 13660,
iast_GLOBAL (10.655 ms) : 10463, 10846
. : milestone, 10655,
profiling (8.834 ms) : 8692, 8975
. : milestone, 8834,
tracing (7.828 ms) : 7710, 7946
. : milestone, 7828,
section candidate
no_agent (4.242 ms) : 4194, 4291
. : milestone, 4242,
iast (9.408 ms) : 9253, 9563
. : milestone, 9408,
iast_FULL (14.054 ms) : 13767, 14341
. : milestone, 14054,
iast_GLOBAL (10.104 ms) : 9925, 10282
. : milestone, 10104,
profiling (9.21 ms) : 9044, 9376
. : milestone, 9210,
tracing (7.762 ms) : 7653, 7872
. : milestone, 7762,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b9af27cabb, baseline=1.54.0-SNAPSHOT~4abe3ff9a9
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1496
. : milestone, 1484,
appsec (3.654 ms) : 3439, 3870
. : milestone, 3654,
iast (2.203 ms) : 2140, 2266
. : milestone, 2203,
iast_GLOBAL (2.242 ms) : 2179, 2305
. : milestone, 2242,
profiling (2.07 ms) : 2018, 2122
. : milestone, 2070,
tracing (2.032 ms) : 1983, 2081
. : milestone, 2032,
section candidate
no_agent (1.486 ms) : 1474, 1498
. : milestone, 1486,
appsec (2.479 ms) : 2426, 2531
. : milestone, 2479,
iast (2.224 ms) : 2161, 2287
. : milestone, 2224,
iast_GLOBAL (2.246 ms) : 2183, 2309
. : milestone, 2246,
profiling (2.069 ms) : 2017, 2121
. : milestone, 2069,
tracing (2.028 ms) : 1979, 2077
. : milestone, 2028,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b9af27cabb, baseline=1.54.0-SNAPSHOT~4abe3ff9a9
dateFormat X
axisFormat %s
section baseline
no_agent (15.544 s) : 15544000, 15544000
. : milestone, 15544000,
appsec (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
iast (18.272 s) : 18272000, 18272000
. : milestone, 18272000,
iast_GLOBAL (18.034 s) : 18034000, 18034000
. : milestone, 18034000,
profiling (15.483 s) : 15483000, 15483000
. : milestone, 15483000,
tracing (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
section candidate
no_agent (15.452 s) : 15452000, 15452000
. : milestone, 15452000,
appsec (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
iast (18.933 s) : 18933000, 18933000
. : milestone, 18933000,
iast_GLOBAL (17.648 s) : 17648000, 17648000
. : milestone, 17648000,
profiling (15.515 s) : 15515000, 15515000
. : milestone, 15515000,
tracing (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
|
jpbempel
reviewed
Sep 5, 2025
| @@ -233,7 +233,7 @@ private void storeDebuggerDefinitions(ConfigurationComparer changes) { | |||
| public ProbeImplementation resolve(String encodedProbeId) { | |||
| ProbeDefinition definition = appliedDefinitions.get(encodedProbeId); | |||
| if (definition == null) { | |||
| LOGGER.warn(SEND_TELEMETRY, "Cannot resolve probe id=" + encodedProbeId); | |||
| LOGGER.warn(SEND_TELEMETRY, "Cannot resolve probe id={}", encodedProbeId); | |||
There was a problem hiding this comment.
this one is on purpose I want the probe ID sent to telemetry to help troubleshoot when we have this case!
this is not sensitive information. nothing related to the customer, this is a technical id
There was a problem hiding this comment.
Thanks! I'll roll back this one.
There was a problem hiding this comment.
Just curious, how concat and param are different here?
There was a problem hiding this comment.
Just curious, how concat and param are different here?
Only the format string "Cannot resolve probe id={}" is sent to the telemetry. Concatenation makes the otherwise hidden arguments available to the telemetry.
There was a problem hiding this comment.
Hmmm, we are hiding arguments to avoid sensitive data leakage? Correct?
If that true, I wish we have API for logging, that will support params and some flag managing what should be hidden... Something self-descriptive and better than concat... because you never know if this concat for purpose or just a human mistake...
There was a problem hiding this comment.
The idea is to have an analyzer check this unless there is an exclusion that explains its purpose.
There was a problem hiding this comment.
this one is on purpose I want the probe ID sent to telemetry to help troubleshoot when we have this case!
The logs that we send to the intake here are not really for normal troubleshooting and they are supposed to be constant message templates only so they can be properly deduplicated to reduce load.
There was a problem hiding this comment.
I agree that this could be addressed with an API change, but we currently use the standard Logger API backed by the TelemetryLogger, which reports errors to the backend.
There was a problem hiding this comment.
this one is on purpose I want the probe ID sent to telemetry to help troubleshoot when we have this case!
The logs that we send to the intake here are not really for normal troubleshooting and they are supposed to be constant message templates only so they can be properly deduplicated to reduce load.
Got it! Rolling back the rollback.
There was a problem hiding this comment.
those messages are cases, like exceptions.
If we cannot use them as telemetry for troubleshooting, they are useless!
bouwkast
reviewed
Sep 5, 2025
There was a problem hiding this comment.
Thanks @ygree!
I think it is just two left from what I can find in GitHub:
- Debugger probe ID - I see there were comments on this one
- Profiler settings
- This was the main one that we discussed with profiling as they don't have access to this data in the flare, it'd be best to get sign off from someone on profiling @jbachorik (?) to see what we can do here.
| @@ -233,7 +233,7 @@ private void storeDebuggerDefinitions(ConfigurationComparer changes) { | |||
| public ProbeImplementation resolve(String encodedProbeId) { | |||
| ProbeDefinition definition = appliedDefinitions.get(encodedProbeId); | |||
| if (definition == null) { | |||
| LOGGER.warn(SEND_TELEMETRY, "Cannot resolve probe id=" + encodedProbeId); | |||
| LOGGER.warn(SEND_TELEMETRY, "Cannot resolve probe id={}", encodedProbeId); | |||
There was a problem hiding this comment.
this one is on purpose I want the probe ID sent to telemetry to help troubleshoot when we have this case!
The logs that we send to the intake here are not really for normal troubleshooting and they are supposed to be constant message templates only so they can be properly deduplicated to reduce load.
ygree
force-pushed
the
ygree/error-logs-remediation-2
branch
from
ba11257 to
b9af27c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
#9459 follow up
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]