- 
                Notifications
    You must be signed in to change notification settings 
- Fork 315
Bump spotbugs gradle plugin to 6.4.4 #9748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…internal-api Also this forces JDK 11 to be the minimum.
# Conflicts: # communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java # utils/test-utils/src/main/groovy/datadog/trace/test/util/DDSpecification.groovy
| Debugger benchmarksParameters
 See matching parameters
 SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 6 unstable metrics. 
 See unchanged results
 Request duration reports for reportsgantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (322.865 µs) : 284, 362
.   : milestone, 323,
basic (292.34 µs) : 286, 299
.   : milestone, 292,
loop (8.956 ms) : 8953, 8959
.   : milestone, 8956,
section candidate
noprobe (331.706 µs) : 280, 383
.   : milestone, 332,
basic (279.828 µs) : 273, 286
.   : milestone, 280,
loop (8.956 ms) : 8950, 8962
.   : milestone, 8956,
 
 
 
 | 
| BenchmarksStartupParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~6eceae4ba8, baseline=1.55.0-SNAPSHOT~8747faa1b4
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1032105
Total [baseline] (10.884 s) : 0, 10884242
Agent [candidate] (1.034 s) : 0, 1033798
Total [candidate] (10.807 s) : 0, 10807265
section appsec
Agent [baseline] (1.218 s) : 0, 1217718
Total [baseline] (11.006 s) : 0, 11006123
Agent [candidate] (1.202 s) : 0, 1201586
Total [candidate] (10.838 s) : 0, 10838091
section iast
Agent [baseline] (1.163 s) : 0, 1163246
Total [baseline] (11.054 s) : 0, 11054321
Agent [candidate] (1.172 s) : 0, 1172074
Total [candidate] (11.089 s) : 0, 11089354
section profiling
Agent [baseline] (1.18 s) : 0, 1179914
Total [baseline] (10.846 s) : 0, 10845526
Agent [candidate] (1.179 s) : 0, 1179183
Total [candidate] (10.961 s) : 0, 10960957
 
 
 
 gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~6eceae4ba8, baseline=1.55.0-SNAPSHOT~8747faa1b4
    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (703.971 ms) : 0, 703971
BytebuddyAgent [candidate] (705.137 ms) : 0, 705137
GlobalTracer [baseline] (244.844 ms) : 0, 244844
GlobalTracer [candidate] (245.536 ms) : 0, 245536
AppSec [baseline] (32.508 ms) : 0, 32508
AppSec [candidate] (32.411 ms) : 0, 32411
Debugger [baseline] (6.385 ms) : 0, 6385
Debugger [candidate] (6.409 ms) : 0, 6409
Remote Config [baseline] (677.098 µs) : 0, 677
Remote Config [candidate] (663.281 µs) : 0, 663
Telemetry [baseline] (14.322 ms) : 0, 14322
Telemetry [candidate] (14.437 ms) : 0, 14437
Flare Poller [baseline] (6.571 ms) : 0, 6571
Flare Poller [candidate] (6.529 ms) : 0, 6529
section appsec
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (735.963 ms) : 0, 735963
BytebuddyAgent [candidate] (726.595 ms) : 0, 726595
GlobalTracer [baseline] (238.916 ms) : 0, 238916
GlobalTracer [candidate] (235.253 ms) : 0, 235253
IAST [baseline] (25.523 ms) : 0, 25523
IAST [candidate] (24.864 ms) : 0, 24864
AppSec [baseline] (175.233 ms) : 0, 175233
AppSec [candidate] (173.524 ms) : 0, 173524
Debugger [baseline] (6.038 ms) : 0, 6038
Debugger [candidate] (5.9 ms) : 0, 5900
Remote Config [baseline] (640.202 µs) : 0, 640
Remote Config [candidate] (637.68 µs) : 0, 638
Telemetry [baseline] (8.611 ms) : 0, 8611
Telemetry [candidate] (8.363 ms) : 0, 8363
Flare Poller [baseline] (3.927 ms) : 0, 3927
Flare Poller [candidate] (3.854 ms) : 0, 3854
section iast
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (825.31 ms) : 0, 825310
BytebuddyAgent [candidate] (832.888 ms) : 0, 832888
GlobalTracer [baseline] (234.227 ms) : 0, 234227
GlobalTracer [candidate] (234.975 ms) : 0, 234975
IAST [baseline] (35.196 ms) : 0, 35196
IAST [candidate] (32.137 ms) : 0, 32137
AppSec [baseline] (26.362 ms) : 0, 26362
AppSec [candidate] (29.898 ms) : 0, 29898
Debugger [baseline] (6.253 ms) : 0, 6253
Debugger [candidate] (6.072 ms) : 0, 6072
Remote Config [baseline] (604.291 µs) : 0, 604
Remote Config [candidate] (595.99 µs) : 0, 596
Telemetry [baseline] (8.494 ms) : 0, 8494
Telemetry [candidate] (8.361 ms) : 0, 8361
Flare Poller [baseline] (4.053 ms) : 0, 4053
Flare Poller [candidate] (4.136 ms) : 0, 4136
section profiling
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (731.667 ms) : 0, 731667
BytebuddyAgent [candidate] (731.388 ms) : 0, 731388
GlobalTracer [baseline] (221.65 ms) : 0, 221650
GlobalTracer [candidate] (220.802 ms) : 0, 220802
AppSec [baseline] (32.199 ms) : 0, 32199
AppSec [candidate] (33.265 ms) : 0, 33265
Debugger [baseline] (13.885 ms) : 0, 13885
Debugger [candidate] (10.625 ms) : 0, 10625
Remote Config [baseline] (691.943 µs) : 0, 692
Remote Config [candidate] (1.375 ms) : 0, 1375
Telemetry [baseline] (8.866 ms) : 0, 8866
Telemetry [candidate] (10.715 ms) : 0, 10715
Flare Poller [baseline] (4.076 ms) : 0, 4076
Flare Poller [candidate] (4.096 ms) : 0, 4096
ProfilingAgent [baseline] (109.423 ms) : 0, 109423
ProfilingAgent [candidate] (109.674 ms) : 0, 109674
Profiling [baseline] (110.071 ms) : 0, 110071
Profiling [candidate] (110.313 ms) : 0, 110313
Startup time reports for insecure-bankgantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~6eceae4ba8, baseline=1.55.0-SNAPSHOT~8747faa1b4
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1033361
Total [baseline] (8.659 s) : 0, 8658789
Agent [candidate] (1.033 s) : 0, 1033136
Total [candidate] (8.67 s) : 0, 8670449
section iast
Agent [baseline] (1.167 s) : 0, 1167049
Total [baseline] (9.38 s) : 0, 9379512
Agent [candidate] (1.162 s) : 0, 1161836
Total [candidate] (9.367 s) : 0, 9366586
 
 
 
 gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~6eceae4ba8, baseline=1.55.0-SNAPSHOT~8747faa1b4
    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (704.558 ms) : 0, 704558
BytebuddyAgent [candidate] (704.567 ms) : 0, 704567
GlobalTracer [baseline] (245.495 ms) : 0, 245495
GlobalTracer [candidate] (245.744 ms) : 0, 245744
AppSec [baseline] (32.629 ms) : 0, 32629
AppSec [candidate] (32.366 ms) : 0, 32366
Debugger [baseline] (6.462 ms) : 0, 6462
Debugger [candidate] (6.406 ms) : 0, 6406
Remote Config [baseline] (689.301 µs) : 0, 689
Remote Config [candidate] (680.642 µs) : 0, 681
Telemetry [baseline] (12.751 ms) : 0, 12751
Telemetry [candidate] (13.658 ms) : 0, 13658
Flare Poller [baseline] (8.077 ms) : 0, 8077
Flare Poller [candidate] (7.065 ms) : 0, 7065
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (827.282 ms) : 0, 827282
BytebuddyAgent [candidate] (825.05 ms) : 0, 825050
GlobalTracer [baseline] (235.405 ms) : 0, 235405
GlobalTracer [candidate] (233.614 ms) : 0, 233614
IAST [baseline] (34.717 ms) : 0, 34717
IAST [candidate] (33.209 ms) : 0, 33209
AppSec [baseline] (27.501 ms) : 0, 27501
AppSec [candidate] (28.141 ms) : 0, 28141
Debugger [baseline] (6.219 ms) : 0, 6219
Debugger [candidate] (6.048 ms) : 0, 6048
Remote Config [baseline] (612.778 µs) : 0, 613
Remote Config [candidate] (599.557 µs) : 0, 600
Telemetry [baseline] (8.481 ms) : 0, 8481
Telemetry [candidate] (8.352 ms) : 0, 8352
Flare Poller [baseline] (4.139 ms) : 0, 4139
Flare Poller [candidate] (4.149 ms) : 0, 4149
LoadParameters
 See matching parameters
 SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics. 
 Request duration reports for insecure-bankgantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~6eceae4ba8, baseline=1.55.0-SNAPSHOT~8747faa1b4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.199 ms) : 1187, 1211
.   : milestone, 1199,
iast (3.317 ms) : 3275, 3360
.   : milestone, 3317,
iast_FULL (5.625 ms) : 5570, 5680
.   : milestone, 5625,
iast_GLOBAL (3.681 ms) : 3621, 3740
.   : milestone, 3681,
profiling (2.038 ms) : 2020, 2057
.   : milestone, 2038,
tracing (1.83 ms) : 1813, 1846
.   : milestone, 1830,
section candidate
no_agent (1.188 ms) : 1176, 1199
.   : milestone, 1188,
iast (3.333 ms) : 3290, 3376
.   : milestone, 3333,
iast_FULL (5.745 ms) : 5688, 5802
.   : milestone, 5745,
iast_GLOBAL (3.627 ms) : 3567, 3687
.   : milestone, 3627,
profiling (1.94 ms) : 1924, 1956
.   : milestone, 1940,
tracing (1.785 ms) : 1770, 1799
.   : milestone, 1785,
 
 
 
 Request duration reports for petclinicgantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~6eceae4ba8, baseline=1.55.0-SNAPSHOT~8747faa1b4
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.289 ms) : 19094, 19484
.   : milestone, 19289,
appsec (20.459 ms) : 20245, 20672
.   : milestone, 20459,
code_origins (18.528 ms) : 18344, 18712
.   : milestone, 18528,
iast (18.658 ms) : 18469, 18846
.   : milestone, 18658,
profiling (19.422 ms) : 19224, 19621
.   : milestone, 19422,
tracing (19.292 ms) : 19099, 19486
.   : milestone, 19292,
section candidate
no_agent (19.485 ms) : 19278, 19691
.   : milestone, 19485,
appsec (20.381 ms) : 20172, 20590
.   : milestone, 20381,
code_origins (19.334 ms) : 19134, 19535
.   : milestone, 19334,
iast (18.887 ms) : 18694, 19080
.   : milestone, 18887,
profiling (19.325 ms) : 19129, 19521
.   : milestone, 19325,
tracing (19.59 ms) : 19397, 19783
.   : milestone, 19590,
 
 
 
 DacapoParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~6eceae4ba8, baseline=1.55.0-SNAPSHOT~8747faa1b4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.459 ms) : 2408, 2510
.   : milestone, 2459,
iast (2.211 ms) : 2148, 2275
.   : milestone, 2211,
iast_GLOBAL (2.254 ms) : 2190, 2318
.   : milestone, 2254,
profiling (2.075 ms) : 2022, 2129
.   : milestone, 2075,
tracing (2.034 ms) : 1984, 2084
.   : milestone, 2034,
section candidate
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (2.462 ms) : 2411, 2514
.   : milestone, 2462,
iast (2.216 ms) : 2152, 2280
.   : milestone, 2216,
iast_GLOBAL (2.261 ms) : 2197, 2325
.   : milestone, 2261,
profiling (2.078 ms) : 2025, 2131
.   : milestone, 2078,
tracing (2.028 ms) : 1978, 2077
.   : milestone, 2028,
 
 
 
 Execution time for biojavagantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~6eceae4ba8, baseline=1.55.0-SNAPSHOT~8747faa1b4
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.794 s) : 14794000, 14794000
.   : milestone, 14794000,
appsec (14.996 s) : 14996000, 14996000
.   : milestone, 14996000,
iast (18.346 s) : 18346000, 18346000
.   : milestone, 18346000,
iast_GLOBAL (17.782 s) : 17782000, 17782000
.   : milestone, 17782000,
profiling (15.966 s) : 15966000, 15966000
.   : milestone, 15966000,
tracing (15.123 s) : 15123000, 15123000
.   : milestone, 15123000,
section candidate
no_agent (15.528 s) : 15528000, 15528000
.   : milestone, 15528000,
appsec (14.757 s) : 14757000, 14757000
.   : milestone, 14757000,
iast (18.452 s) : 18452000, 18452000
.   : milestone, 18452000,
iast_GLOBAL (18.123 s) : 18123000, 18123000
.   : milestone, 18123000,
profiling (15.744 s) : 15744000, 15744000
.   : milestone, 15744000,
tracing (15.062 s) : 15062000, 15062000
.   : milestone, 15062000,
 
 
 
 | 
| 🎯 Code Coverage 🔗 Commit SHA: 6eceae4 | Docs | Datadog PR Page | Was this helpful? Give us feedback! | 
What Does This Do
This PR bumps spotbugs gradle plugin to the most recent version 6.4.4 to this day (from 5.0.14).
And require a JDK 11 minimum to run.
Important
This version of spotbugs has new rules, better detection engine that requires to change so of the warnings ignores, or fix some code.
Motivation
Latest tools provide more value.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]