-
Notifications
You must be signed in to change notification settings - Fork 318
Fix flaky test configuration #9918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 2b8f175 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~2b8f1757fe, baseline=1.56.0-SNAPSHOT~54da873ecc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053562
Total [baseline] (10.778 s) : 0, 10777817
Agent [candidate] (1.055 s) : 0, 1054933
Total [candidate] (10.652 s) : 0, 10652428
section appsec
Agent [baseline] (1.222 s) : 0, 1222144
Total [baseline] (10.821 s) : 0, 10820762
Agent [candidate] (1.243 s) : 0, 1242886
Total [candidate] (10.946 s) : 0, 10946024
section iast
Agent [baseline] (1.188 s) : 0, 1187637
Total [baseline] (11.14 s) : 0, 11140277
Agent [candidate] (1.176 s) : 0, 1175894
Total [candidate] (11.157 s) : 0, 11156766
section profiling
Agent [baseline] (1.194 s) : 0, 1194037
Total [baseline] (10.879 s) : 0, 10879024
Agent [candidate] (1.199 s) : 0, 1198542
Total [candidate] (10.911 s) : 0, 10910641
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~2b8f1757fe, baseline=1.56.0-SNAPSHOT~54da873ecc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (708.759 ms) : 0, 708759
BytebuddyAgent [candidate] (711.17 ms) : 0, 711170
GlobalTracer [baseline] (247.229 ms) : 0, 247229
GlobalTracer [candidate] (246.595 ms) : 0, 246595
AppSec [baseline] (32.872 ms) : 0, 32872
AppSec [candidate] (32.465 ms) : 0, 32465
Debugger [baseline] (6.523 ms) : 0, 6523
Debugger [candidate] (6.44 ms) : 0, 6440
Remote Config [baseline] (718.643 µs) : 0, 719
Remote Config [candidate] (717.64 µs) : 0, 718
Telemetry [baseline] (13.74 ms) : 0, 13740
Telemetry [candidate] (13.061 ms) : 0, 13061
Flare Poller [baseline] (7.421 ms) : 0, 7421
Flare Poller [candidate] (8.071 ms) : 0, 8071
section appsec
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (729.915 ms) : 0, 729915
BytebuddyAgent [candidate] (742.672 ms) : 0, 742672
GlobalTracer [baseline] (237.54 ms) : 0, 237540
GlobalTracer [candidate] (242.133 ms) : 0, 242133
AppSec [baseline] (174.232 ms) : 0, 174232
AppSec [candidate] (175.944 ms) : 0, 175944
Debugger [baseline] (5.971 ms) : 0, 5971
Debugger [candidate] (6.104 ms) : 0, 6104
Remote Config [baseline] (667.124 µs) : 0, 667
Remote Config [candidate] (675.849 µs) : 0, 676
Telemetry [baseline] (8.483 ms) : 0, 8483
Telemetry [candidate] (8.856 ms) : 0, 8856
Flare Poller [baseline] (3.991 ms) : 0, 3991
Flare Poller [candidate] (4.133 ms) : 0, 4133
IAST [baseline] (24.941 ms) : 0, 24941
IAST [candidate] (25.611 ms) : 0, 25611
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (834.637 ms) : 0, 834637
BytebuddyAgent [candidate] (825.816 ms) : 0, 825816
GlobalTracer [baseline] (235.61 ms) : 0, 235610
GlobalTracer [candidate] (234.211 ms) : 0, 234211
AppSec [baseline] (30.668 ms) : 0, 30668
AppSec [candidate] (26.818 ms) : 0, 26818
Debugger [baseline] (6.025 ms) : 0, 6025
Debugger [candidate] (5.957 ms) : 0, 5957
Remote Config [baseline] (627.553 µs) : 0, 628
Remote Config [candidate] (595.055 µs) : 0, 595
Telemetry [baseline] (8.619 ms) : 0, 8619
Telemetry [candidate] (8.321 ms) : 0, 8321
Flare Poller [baseline] (4.199 ms) : 0, 4199
Flare Poller [candidate] (4.145 ms) : 0, 4145
IAST [baseline] (30.887 ms) : 0, 30887
IAST [candidate] (33.897 ms) : 0, 33897
section profiling
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (730.187 ms) : 0, 730187
BytebuddyAgent [candidate] (734.347 ms) : 0, 734347
GlobalTracer [baseline] (222.227 ms) : 0, 222227
GlobalTracer [candidate] (221.979 ms) : 0, 221979
AppSec [baseline] (32.136 ms) : 0, 32136
AppSec [candidate] (32.198 ms) : 0, 32198
Debugger [baseline] (9.046 ms) : 0, 9046
Debugger [candidate] (7.5 ms) : 0, 7500
Remote Config [baseline] (716.217 µs) : 0, 716
Remote Config [candidate] (681.01 µs) : 0, 681
Telemetry [baseline] (13.785 ms) : 0, 13785
Telemetry [candidate] (15.432 ms) : 0, 15432
Flare Poller [baseline] (4.111 ms) : 0, 4111
Flare Poller [candidate] (4.215 ms) : 0, 4215
ProfilingAgent [baseline] (110.524 ms) : 0, 110524
ProfilingAgent [candidate] (110.609 ms) : 0, 110609
Profiling [baseline] (111.227 ms) : 0, 111227
Profiling [candidate] (111.285 ms) : 0, 111285
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~2b8f1757fe, baseline=1.56.0-SNAPSHOT~54da873ecc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050277
Total [baseline] (8.671 s) : 0, 8671065
Agent [candidate] (1.05 s) : 0, 1049614
Total [candidate] (8.649 s) : 0, 8649402
section iast
Agent [baseline] (1.179 s) : 0, 1178643
Total [baseline] (9.267 s) : 0, 9267162
Agent [candidate] (1.19 s) : 0, 1190373
Total [candidate] (9.274 s) : 0, 9273647
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~2b8f1757fe, baseline=1.56.0-SNAPSHOT~54da873ecc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (706.533 ms) : 0, 706533
BytebuddyAgent [candidate] (706.68 ms) : 0, 706680
GlobalTracer [baseline] (246.467 ms) : 0, 246467
GlobalTracer [candidate] (246.14 ms) : 0, 246140
AppSec [baseline] (32.868 ms) : 0, 32868
AppSec [candidate] (32.476 ms) : 0, 32476
Debugger [baseline] (6.527 ms) : 0, 6527
Debugger [candidate] (6.403 ms) : 0, 6403
Remote Config [baseline] (729.366 µs) : 0, 729
Remote Config [candidate] (713.743 µs) : 0, 714
Telemetry [baseline] (12.95 ms) : 0, 12950
Telemetry [candidate] (12.906 ms) : 0, 12906
Flare Poller [baseline] (8.087 ms) : 0, 8087
Flare Poller [candidate] (8.067 ms) : 0, 8067
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (827.698 ms) : 0, 827698
BytebuddyAgent [candidate] (837.003 ms) : 0, 837003
GlobalTracer [baseline] (234.485 ms) : 0, 234485
GlobalTracer [candidate] (236.123 ms) : 0, 236123
AppSec [baseline] (28.615 ms) : 0, 28615
AppSec [candidate] (27.228 ms) : 0, 27228
Debugger [baseline] (5.995 ms) : 0, 5995
Debugger [candidate] (6.015 ms) : 0, 6015
Remote Config [baseline] (604.791 µs) : 0, 605
Remote Config [candidate] (598.196 µs) : 0, 598
Telemetry [baseline] (8.375 ms) : 0, 8375
Telemetry [candidate] (8.318 ms) : 0, 8318
Flare Poller [baseline] (4.155 ms) : 0, 4155
Flare Poller [candidate] (4.143 ms) : 0, 4143
IAST [baseline] (32.505 ms) : 0, 32505
IAST [candidate] (34.653 ms) : 0, 34653
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~2b8f1757fe, baseline=1.56.0-SNAPSHOT~54da873ecc
dateFormat X
axisFormat %s
section baseline
no_agent (1.183 ms) : 1171, 1194
. : milestone, 1183,
iast (3.112 ms) : 3073, 3152
. : milestone, 3112,
iast_FULL (5.92 ms) : 5861, 5979
. : milestone, 5920,
iast_GLOBAL (3.494 ms) : 3444, 3544
. : milestone, 3494,
profiling (1.96 ms) : 1944, 1976
. : milestone, 1960,
tracing (1.811 ms) : 1796, 1825
. : milestone, 1811,
section candidate
no_agent (1.197 ms) : 1186, 1209
. : milestone, 1197,
iast (3.198 ms) : 3157, 3239
. : milestone, 3198,
iast_FULL (5.931 ms) : 5871, 5990
. : milestone, 5931,
iast_GLOBAL (3.596 ms) : 3543, 3649
. : milestone, 3596,
profiling (2.11 ms) : 2092, 2129
. : milestone, 2110,
tracing (1.781 ms) : 1766, 1796
. : milestone, 1781,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~2b8f1757fe, baseline=1.56.0-SNAPSHOT~54da873ecc
dateFormat X
axisFormat %s
section baseline
no_agent (18.149 ms) : 17959, 18340
. : milestone, 18149,
appsec (18.618 ms) : 18431, 18806
. : milestone, 18618,
code_origins (17.803 ms) : 17626, 17981
. : milestone, 17803,
iast (17.78 ms) : 17602, 17958
. : milestone, 17780,
profiling (18.558 ms) : 18368, 18749
. : milestone, 18558,
tracing (17.651 ms) : 17476, 17825
. : milestone, 17651,
section candidate
no_agent (17.759 ms) : 17578, 17940
. : milestone, 17759,
appsec (18.645 ms) : 18459, 18832
. : milestone, 18645,
code_origins (18.901 ms) : 18704, 19097
. : milestone, 18901,
iast (17.654 ms) : 17479, 17830
. : milestone, 17654,
profiling (19.668 ms) : 19466, 19870
. : milestone, 19668,
tracing (18.204 ms) : 18026, 18382
. : milestone, 18204,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~2b8f1757fe, baseline=1.56.0-SNAPSHOT~54da873ecc
dateFormat X
axisFormat %s
section baseline
no_agent (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
appsec (14.844 s) : 14844000, 14844000
. : milestone, 14844000,
iast (18.141 s) : 18141000, 18141000
. : milestone, 18141000,
iast_GLOBAL (17.938 s) : 17938000, 17938000
. : milestone, 17938000,
profiling (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
tracing (14.472 s) : 14472000, 14472000
. : milestone, 14472000,
section candidate
no_agent (15.604 s) : 15604000, 15604000
. : milestone, 15604000,
appsec (14.64 s) : 14640000, 14640000
. : milestone, 14640000,
iast (18.44 s) : 18440000, 18440000
. : milestone, 18440000,
iast_GLOBAL (17.976 s) : 17976000, 17976000
. : milestone, 17976000,
profiling (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
tracing (14.701 s) : 14701000, 14701000
. : milestone, 14701000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~2b8f1757fe, baseline=1.56.0-SNAPSHOT~54da873ecc
dateFormat X
axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (3.69 ms) : 3471, 3908
. : milestone, 3690,
iast (2.201 ms) : 2137, 2264
. : milestone, 2201,
iast_GLOBAL (2.241 ms) : 2177, 2305
. : milestone, 2241,
profiling (2.05 ms) : 1998, 2101
. : milestone, 2050,
tracing (2.021 ms) : 1971, 2071
. : milestone, 2021,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.621 ms) : 3408, 3835
. : milestone, 3621,
iast (2.187 ms) : 2123, 2251
. : milestone, 2187,
iast_GLOBAL (2.237 ms) : 2173, 2300
. : milestone, 2237,
profiling (2.059 ms) : 2006, 2112
. : milestone, 2059,
tracing (2.018 ms) : 1969, 2068
. : milestone, 2018,
|
b7a159c to
2b8f175
Compare
What Does This Do
Use a safe
instanceOfcheck withoptions as? JUnitPlatformOptionsinstead of the wrongtestFramework is JUnitPlatformOptionsevaluation to check if tests marked as@Flakyshould be skipped or not.Motivation
Previously when using
testFramework, it had the wrong type, and the check always evaluated asfalse, skipping the test configuration entirely.Additional Notes
After converting
configure-teststo a convention plug-in in #9859, JUnit flaky test configurations were skipped and causing failures on themasterbranch of CI. This PR restores the functionality.