Skip to content

[PHP 8] Second custom pre-RC5 build #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2020
Merged

[PHP 8] Second custom pre-RC5 build #1096

merged 1 commit into from
Nov 13, 2020

Conversation

SammyK
Copy link
Contributor

@SammyK SammyK commented Nov 13, 2020

Description

This PR is a follow up to #1093 that adds php/php-src#6422 to the PHP 8 containers. That PR fixes a number of issues with passing the correct return value to the end handlers.

These changes will be landing in RC5 next week.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@SammyK SammyK added the ci label Nov 13, 2020
@SammyK SammyK added this to the 0.51.0 milestone Nov 13, 2020
@SammyK SammyK merged commit a3e6fa4 into master Nov 13, 2020
@SammyK SammyK deleted the sammyk/php8.0.0-pre-rc5 branch November 13, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants