Skip to content

Conversation

@Strech
Copy link
Member

@Strech Strech commented Dec 10, 2025

Reverts #5074

Change log entry

None.

@Strech Strech requested a review from a team as a code owner December 10, 2025 09:08
@github-actions github-actions bot added the core Involves Datadog core libraries label Dec 10, 2025
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-12-10 09:17:11 UTC

@github-actions
Copy link

Typing analysis

Note: Ignored files are excluded from the next sections.

steep:ignore comments

This PR clears 1 steep:ignore comment.

steep:ignore comments (+0-1)Cleared:
lib/datadog/core/telemetry/worker.rb:284

Untyped methods

This PR introduces 1 untyped method and 5 partially typed methods, and clears 1 untyped method and 5 partially typed methods. It decreases the percentage of typed methods from 55.53% to 55.4% (-0.13%).

Untyped methods (+1-1)Introduced:
sig/datadog/core/telemetry/worker.rbs:60
└── def buffer_klass: () -> untyped
Cleared:
sig/datadog/core/telemetry/worker.rbs:61
└── def buffer_klass: () -> untyped
Partially typed methods (+5-5)Introduced:
sig/datadog/core/telemetry/event/app_started.rbs:17
└── def configuration: (untyped settings, Core::Configuration::AgentSettings agent_settings) -> Array[Hash[Symbol, untyped]]
sig/datadog/core/telemetry/event/app_started.rbs:21
└── def conf_value: (String name, untyped value, Integer seq_id, String origin) -> Hash[Symbol, untyped]
sig/datadog/core/telemetry/event/app_started.rbs:25
└── def install_signature: (untyped settings) -> Hash[Symbol, Object]
sig/datadog/core/telemetry/event/app_started.rbs:27
└── def get_telemetry_origin: (untyped settings, String config_path) -> String
sig/datadog/core/telemetry/event/synth_app_client_configuration_change.rbs:8
└── def payload: () -> { configuration: untyped }
Cleared:
sig/datadog/core/telemetry/event/app_started.rbs:19
└── def configuration: (untyped settings, Core::Configuration::AgentSettings agent_settings) -> Array[Hash[Symbol, untyped]]
sig/datadog/core/telemetry/event/app_started.rbs:23
└── def conf_value: (String name, untyped value, Integer seq_id, String origin) -> Hash[Symbol, untyped]
sig/datadog/core/telemetry/event/app_started.rbs:27
└── def install_signature: (untyped settings) -> Hash[Symbol, Object]
sig/datadog/core/telemetry/event/app_started.rbs:29
└── def get_telemetry_origin: (untyped settings, String config_path) -> String
sig/datadog/core/telemetry/event/synth_app_client_configuration_change.rbs:8
└── def payload: () -> { ?products: untyped, configuration: untyped, ?install_signature: untyped }

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept to the end of the line to remove it from the stats.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It's a bit sad we won't have this one, but hopefully we'll re-land it soon!

Looks good as a clean revert of #5074!

@datadog-official
Copy link

datadog-official bot commented Dec 10, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 94.12%
Total Coverage: 95.24% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 36fd0cd | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2025

Benchmarks

Benchmark execution time: 2025-12-10 09:39:37

Comparing candidate commit 36fd0cd in PR branch revert-5074-telemetry-in-children with baseline commit 4bae228 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@Strech Strech merged commit 80b8b5a into master Dec 10, 2025
555 checks passed
@Strech Strech deleted the revert-5074-telemetry-in-children branch December 10, 2025 10:38
@github-actions github-actions bot added this to the 2.23.0 milestone Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants