👷 Update dependency dd-trace to v6#171
Conversation
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Review — Score: 4.5 / 5
This is a straightforward Renovate bump of the bundled dd-trace dependency from 5.109.0 to 6.0.0. The SDK's integration surface — experimental.exporter: 'electron', the datadog:apm:electron:export diagnostics channel, and disabled electron plugin instrumentation — is unchanged and validated by passing unit tests and a full local e2e run (35/35). I would approve this PR.
Why 4.5: Clean lockfile-only diff; no SDK code changes required; dd-trace v6's Node >=22 engines requirement aligns with the existing electron >=39 peer dependency (Electron 39+ ships Node 22+); unit and e2e tests exercise the integration successfully.
Why not 5: Major-version dependency bump lacks a CHANGELOG entry following the precedent set by #136, and dd-trace v6 drops Node 18/20 support — a behavioral tightening worth documenting even though the peer dep already excludes affected Electron versions.
Findings
- [Minor] Missing CHANGELOG entry — Record the dd-trace 6.0.0 bump under Internal, matching the pattern from #136.
Sent by Cursor Automation: electron-sdk reviews
| }, | ||
| "dependencies": { | ||
| "dd-trace": "5.109.0" | ||
| "dd-trace": "6.0.0" |
There was a problem hiding this comment.
dd-trace v6 is a major release (engines.node: ">=22", drops Node 18/20). The existing electron >=39 peer dependency already implies Node 22+ at runtime, so no SDK code changes are needed here — confirmed by unit tests and a full local e2e run with 6.0.0.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bfbf221c25
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| "dependencies": { | ||
| "dd-trace": "5.109.0" | ||
| "dd-trace": "6.0.0" |
There was a problem hiding this comment.
In CI, the e2e and integration jobs run yarn test:e2e:init / yarn test:integration:init, and both scripts execute cd e2e/app && yarn install; Yarn's install docs state that --immutable defaults to true on CI and aborts if the lockfile would change. This dependency bump leaves e2e/app/yarn.lock resolving the portal SDK dependency to dd-trace: "npm:5.109.0", so those CI installs will need to rewrite the lockfile to 6.0.0 and fail before tests run. Please update the E2E app lockfile along with the root lockfile.
Useful? React with 👍 / 👎.
| }, | ||
| "dependencies": { | ||
| "dd-trace": "5.109.0" | ||
| "dd-trace": "6.0.0" |
There was a problem hiding this comment.
The playground CI job runs yarn dev:init, and that script executes cd playground && yarn install; the lint job also runs the same init script. Since playground/yarn.lock still resolves the portal SDK dependency to dd-trace: "npm:5.109.0", Yarn's CI-default immutable install will need to rewrite that lockfile after this bump and abort before the playground and lint checks can run. Please update the playground lockfile as part of the dependency bump.
Useful? React with 👍 / 👎.
This PR contains the following updates:
5.109.0→6.0.0Release Notes
DataDog/dd-trace-js (dd-trace)
v6.0.0: 6.0.0Compare Source
Breaking Changes
Features
Fixes
Performance
Documentation
Internal (CI, Testing, Benchmarking)
Contributors
v5.113.0Compare Source
v5.112.0: 5.112.0Compare Source
Features
@anthropic-ai/claude-agent-sdk#9202Fixes
Internal (CI, Testing, Benchmarking)
v5.111.0: 5.111.0Compare Source
Features
Fixes
Performance
Documentation
Internal (CI, Testing, Benchmarking)
v5.110.0: 5.110.0Compare Source
Features
Fixes
Performance
Documentation
Internal (CI, Testing, Benchmarking)
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.