Skip to content

[FIX] - archive fails due to Cycle inside caused by dSym upload build phase#117

Merged
sbarrio merged 1 commit into
mainfrom
sbarrio/fix/remove-input-output-paths-for-dsym-upload-build-phase
Jun 30, 2026
Merged

[FIX] - archive fails due to Cycle inside caused by dSym upload build phase#117
sbarrio merged 1 commit into
mainfrom
sbarrio/fix/remove-input-output-paths-for-dsym-upload-build-phase

Conversation

@sbarrio

@sbarrio sbarrio commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Reported on #90

Fixes a dependency cycle in Xcode's build system that caused iOS archive builds to fail.

The inputPaths/outputPaths added in #85 wired the "Upload dSYMs to Datadog" script phase into Xcode's dependency graph, creating a cycle.

This PR removes inputPaths/outputPaths and a guard to the script with DEPLOYMENT_POSTPROCESSING=YES so it only runs during archive builds.

Motivation

Using expo-datadog should not make the host app build fail.

Additional notes

Tested against the E2E expo app:

Release build
Screenshot 2026-06-26 at 16 08 32

Archive build without exported DATADOG_API_KEY

Screenshot 2026-06-26 at 16 14 38

Archive build with exported DATADOG_API_KEY

Screenshot 2026-06-26 at 16 12 28

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio marked this pull request as ready for review June 26, 2026 14:27
@sbarrio sbarrio requested a review from a team as a code owner June 26, 2026 14:27
@sbarrio sbarrio requested a review from barboraplasovska June 29, 2026 07:06

@barboraplasovska barboraplasovska left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@sbarrio sbarrio merged commit e94600f into main Jun 30, 2026
5 checks passed
@sbarrio sbarrio deleted the sbarrio/fix/remove-input-output-paths-for-dsym-upload-build-phase branch June 30, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants