gpu: add missing volume mount to the operator #20786
Merged
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val06
previously approved these changes
Jul 18, 2025
gpu/README.md
Outdated
| oomKill: # Only enable this feature if there is nothing else that requires the system-probe container in all Agent pods | ||
| oomKill: | ||
| # Only enable this feature if there is nothing else that requires the system-probe container in all Agent pods | ||
| # Examples of system-probe features are npm, cws, usm, oom_kill. |
There was a problem hiding this comment.
nit: i think you can remove the oom_kill from the list
temporal-github-worker-1
bot
dismissed
val06’s stale review
Review from val06 is dismissed. Related teams and files:
- ebpf-platform
- gpu/README.md
michaelcretzman
approved these changes
Jul 18, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
val06
approved these changes
Jul 21, 2025
github-actions bot
pushed a commit
to ConnectionMaster/integrations-core
that referenced
this pull request
Jul 21, 2025
* Update mounts * Remove redundant feature 3be35b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a missing volume mount that is required for operator versions < 1.18. Note that this is only necessary if there are no other system-probe features enabled, so the mount is not required for mixed-node deployments.
Motivation
Correct deployment instructions.
Related ticket: https://datadoghq.atlassian.net/browse/EBPF-768
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged