Skip to content

Conversation

@savandalasaniya-crest
Copy link
Contributor

What does this PR do?

This is a initial release PR of Have I Been Pwned integration including all the required assets.

Integration Logo Source: https://haveibeenpwned.com/Images/Hero.svg?v=ela4hSGcWyGSHm101pjc3K0EHrDqdwhMAsD3G_hZAgA

Motivation

  • Crawler code for this integration has been committed in its respective repo.
  • OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository.
  • Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behavior.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

⚠️ Recommendation: Add qa/skip-qa Label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@cmlaverdiere
Copy link
Contributor

@savandalasaniya-crest is this ready for review?

@savandalasaniya-crest
Copy link
Contributor Author

@savandalasaniya-crest is this ready for review?

We are marking the asset PR as ready for review once the no-asset PR has been merged. Since the no-asset PR was merged yesterday, i have marked this PR as ready for review.

@cmlaverdiere cmlaverdiere added this pull request to the merge queue Sep 29, 2025
@cmlaverdiere cmlaverdiere removed this pull request from the merge queue due to a manual request Sep 29, 2025
@cmlaverdiere cmlaverdiere added this pull request to the merge queue Sep 29, 2025
Merged via the queue into DataDog:master with commit 9e3eb28 Sep 29, 2025
73 of 75 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 29, 2025
…21239)

* Add Have I Been Pwned integration with assets

* Updated images

* Renaming file name

* Updating sample

* Adding test result

* Resolving pipeline issues 9e3eb28
github-actions bot pushed a commit to ConnectionMaster/integrations-core that referenced this pull request Sep 29, 2025
…ataDog#21239)

* Add Have I Been Pwned integration with assets

* Updated images

* Renaming file name

* Updating sample

* Adding test result

* Resolving pipeline issues 9e3eb28
github-actions bot pushed a commit to dancmeyers/integrations-core that referenced this pull request Sep 30, 2025
…ataDog#21239)

* Add Have I Been Pwned integration with assets

* Updated images

* Renaming file name

* Updating sample

* Adding test result

* Resolving pipeline issues 9e3eb28
github-actions bot pushed a commit to vinodkumar-sacumen/integrations-core that referenced this pull request Sep 30, 2025
…ataDog#21239)

* Add Have I Been Pwned integration with assets

* Updated images

* Renaming file name

* Updating sample

* Adding test result

* Resolving pipeline issues 9e3eb28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants