Skip to content

update s3 bucket components to integration logo components #21269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2025
Merged

update s3 bucket components to integration logo components #21269

merged 3 commits into from
Sep 10, 2025

Conversation

@ameesha
Copy link
Contributor

@ameesha ameesha commented Sep 5, 2025 •
edited
Loading

What does this PR do?

Logos were stored on a text component, swapping them to use the integration logo component

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@ameesha ameesha requested review from a team as code owners September 5, 2025 04:15
@ameesha ameesha added assets/no-dry-run Run asset publishing github checks in staging and removed ecosystems/review-requested product/review-requested labels Sep 5, 2025
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

⚠️ Recommendation: Add qa/skip-qa Label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

janine-c
janine-c approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's nothing for docs to look at; approving to unblock merging 🙂

@ameesha ameesha requested review from a team and ksun154 September 10, 2025 15:27
@NouemanKHAL NouemanKHAL added the qa/skip-qa Automatically skip this PR for the next QA label Sep 10, 2025
@ameesha
Copy link
Contributor Author

ameesha commented Sep 10, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-09-10 16:14:57 UTC ℹ️ Start processing command /merge

2025-09-10 16:15:03 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-10 17:07:46 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@ameesha
Copy link
Contributor Author

ameesha commented Sep 10, 2025

/merge -c

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-09-10 17:07:38 UTC ℹ️ Start processing command /merge -c

@NouemanKHAL NouemanKHAL added this pull request to the merge queue Sep 10, 2025
Merged via the queue into master with commit 8754f3a Sep 10, 2025
63 of 64 checks passed
@NouemanKHAL NouemanKHAL deleted the ameesha/update-bucket-to-integration-logo branch September 10, 2025 18:44
github-actions bot pushed a commit to ConnectionMaster/integrations-core that referenced this pull request Sep 10, 2025
@pull
update s3 bucket components to integration logo components (DataDog#2…
31b772c 
…1269)

* update s3 bucket components to integration logo components

* empty 8754f3a
github-actions bot pushed a commit to vinodkumar-sacumen/integrations-core that referenced this pull request Sep 11, 2025
@vinodkumar-sacumen
update s3 bucket components to integration logo components (DataDog#2…
224ef9a 
…1269)

* update s3 bucket components to integration logo components

* empty 8754f3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NouemanKHAL NouemanKHAL NouemanKHAL approved these changes

@ksun154 ksun154 ksun154 approved these changes

@janine-c janine-c janine-c approved these changes

Assignees

No one assigned

Labels

agent/approved assets/no-dry-run Run asset publishing github checks in staging docs/approved ecosystems/review-requested integration/gitlab mergequeue-status: removed product/review-requested qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations team/documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ameesha @NouemanKHAL @ksun154 @janine-c