Skip to content

Conversation

@eric-weaver
Copy link
Contributor

What does this PR do?

This change updates our explain plan collection query to filter out recently executed queries that have errors. This is done to avoid attempting to explain an unexplainable query and will stop emitting back an explain plan event that's marked as unsupported. We already avoid collection of these in Query samples and Query metrics.

Motivation

Will prevent explain plan event entries that look like this
Screenshot 2025-10-20 at 4 32 00 PM

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.12%. Comparing base (46169ca) to head (0f395b2).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant