add infra_mode tag to vsphere metric #21730
Conversation
This PR is the equivalent of DataDog/datadog-agent#42081 for vsphere metrics.
There was a problem hiding this comment.
Hi @arbll I left a couple of questions. Just make sure to update the tests to ensure they are testing the current behavior.
I removed the no-changelog tag as this would not qualify for that use case. Any change that is going to be included in a future release of the agent needs to include a changelog that adds visibility to what has been modified both for us and for our customers.
Thanks!
My Feedback Legend
Here's a quick guide to the prefixes I use in my comments:
praise: no action needed, just celebrate!
note: just a comment/information, no need to take any action.
question: I need clarification or I'm seeking to understand your approach.
nit: A minor, non-blocking issue (e.g., style, typo). Feel free to ignore.
suggestion: I'm proposing an improvement. This is optional but recommended.
request: A change I believe is necessary before this can be merged.
The only blocking comments are request, any other type of comment can be applied at discretion of the developer.
temporal-github-worker-1
bot
added
agent/requested-changes
and removed
agent/review-requested
labels
| tags.append('infra_mode:{}'.format(infra_mode)) | ||
|
|
||
| value = valid_values[-1] | ||
| if metric_name in PERCENT_METRICS: |
There was a problem hiding this comment.
Unsure when the vsphere. prefix is added to the collected metric_name (the logic here matches the metric_name against PERCENT_METRICS, which does not have this prefix, see code )
There was a problem hiding this comment.
The vsphere. prefix is added by the __NAMESPACE__ attribute, see:
There was a problem hiding this comment.
Fixed this but will doublecheck with the live test that it's working properly
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
4 participants
This PR is the equivalent of DataDog/datadog-agent#42081 for vsphere metrics.