Update bentoml.yaml #22067
Update bentoml.yaml #22067
Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
bentoml/assets/logs/bentoml.yaml
Outdated
| grok: | ||
| matchRules: | | ||
| timestamp %{date("yyyy-MM-dd'T'HH:mm:ss.SSSSSS"):timestamp} | ||
| timestamp %{date("yyyy-MM-dd'T'HH:mm:ss.SSSSSS"):timestamp |
There was a problem hiding this comment.
The matchRules pattern for the timestamp grok-parser is now missing its closing } (timestamp %{date("yyyy-MM-dd'T'HH:mm:ss.SSSSSS"):timestamp), leaving the grok expression syntactically invalid. With this malformed pattern the grok parser cannot compile, so the pipeline will fail to extract timestamp and downstream date remapping will not run for BentoML logs.
Useful? React with 👍 / 👎.
|
👋 hello! I'm not sure I understand this change? |
ClementGalland
added
the
assets/no-dry-run
Hello, this is used to reproduce a bug in logs-integration-check. This should have been a draft PR, I updated it. |
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged