Skip to content

feat(sidecar): add telemetry clients expiration #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat(sidecar): add telemetry clients expiration #1077

wants to merge 15 commits into from

Conversation

Leiyks
Copy link
Contributor

@Leiyks Leiyks commented May 28, 2025

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented May 28, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-07-22 13:59:06

Comparing candidate commit 00d1748 in PR branch leiyks-reduce-telemetry-size with baseline commit 4eb2b86 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 246.317ns 259.046ns ± 13.857ns 251.854ns ± 3.440ns 269.936ns 289.533ns 295.350ns 297.951ns 18.30% 1.210 0.256 5.34% 0.980ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [257.125ns; 260.966ns] or [-0.741%; +0.741%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.248ms 8.268ms ± 0.010ms 8.267ms ± 0.006ms 8.273ms 8.284ms 8.302ms 8.323ms 0.68% 1.594 5.490 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.267ms; 8.270ms] or [-0.016%; +0.016%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.163µs 3.221µs ± 1.404µs 3.013µs ± 0.028µs 3.035µs 3.656µs 13.775µs 14.760µs 389.86% 7.297 54.661 43.48% 0.099µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.027µs; 3.416µs] or [-6.041%; +6.041%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.855µs 26.305µs ± 10.532µs 18.111µs ± 0.146µs 35.260µs 44.538µs 49.500µs 76.576µs 322.80% 1.176 1.856 39.94% 0.745µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.846µs; 27.765µs] or [-5.549%; +5.549%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.916µs 3.918µs 3.919µs 0.19% -0.892 6.368 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255153002.992op/s 255633442.977op/s ± 191874.718op/s 255640665.806op/s ± 111550.899op/s 255744032.729op/s 255896429.954op/s 255959349.790op/s 256830955.111op/s 0.47% 0.909 6.477 0.07% 13567.591op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 78.503µs 81.493µs ± 1.034µs 81.595µs ± 0.691µs 82.244µs 83.011µs 83.550µs 83.939µs 2.87% -0.268 -0.350 1.27% 0.073µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11913445.886op/s 12272913.982op/s ± 156252.194op/s 12255625.926op/s ± 103841.898op/s 12369733.651op/s 12551829.684op/s 12628434.503op/s 12738349.396op/s 3.94% 0.328 -0.302 1.27% 11048.699op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 74.205µs 74.929µs ± 0.184µs 74.900µs ± 0.101µs 75.036µs 75.208µs 75.410µs 75.717µs 1.09% 0.490 2.667 0.24% 0.013µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13207094.536op/s 13345962.901op/s ± 32740.431op/s 13351094.942op/s ± 18023.731op/s 13365601.286op/s 13392993.925op/s 13414776.102op/s 13476251.325op/s 0.94% -0.458 2.646 0.24% 2315.098op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.917µs 3.918µs 0.18% -0.966 5.328 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255201795.056op/s 255665884.681op/s ± 190118.492op/s 255661190.637op/s ± 127247.253op/s 255791055.221op/s 255932523.674op/s 255974713.856op/s 256822055.561op/s 0.45% 0.981 5.422 0.07% 13443.407op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 71.438µs 72.056µs ± 0.189µs 72.044µs ± 0.085µs 72.137µs 72.367µs 72.615µs 72.794µs 1.04% 0.614 2.217 0.26% 0.013µs 1 200
credit_card/is_card_number/378282246310005 throughput 13737450.246op/s 13878149.456op/s ± 36361.720op/s 13880454.238op/s ± 16325.174op/s 13895874.662op/s 13930535.177op/s 13961555.448op/s 13998095.856op/s 0.85% -0.584 2.177 0.26% 2571.162op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.121µs 52.192µs ± 0.033µs 52.188µs ± 0.022µs 52.210µs 52.246µs 52.282µs 52.297µs 0.21% 0.510 0.262 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19121481.461op/s 19160083.996op/s ± 12032.929op/s 19161450.039op/s ± 7891.672op/s 19168544.897op/s 19177095.453op/s 19184712.738op/s 19186088.167op/s 0.13% -0.507 0.255 0.06% 850.857op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.703µs 5.878µs ± 0.070µs 5.885µs ± 0.051µs 5.932µs 5.981µs 6.025µs 6.041µs 2.65% -0.196 -0.470 1.20% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165545741.314op/s 170137968.066op/s ± 2045179.030op/s 169926949.983op/s ± 1477510.235op/s 171551290.395op/s 173604595.228op/s 175193051.161op/s 175351714.676op/s 3.19% 0.250 -0.440 1.20% 144615.996op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.911µs ± 0.003µs 3.911µs ± 0.001µs 3.913µs 3.915µs 3.921µs 3.922µs 0.28% -0.182 7.704 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254998565.010op/s 255676897.233op/s ± 181237.263op/s 255706334.770op/s ± 94707.758op/s 255780253.770op/s 255898931.811op/s 255936891.697op/s 256785749.134op/s 0.42% 0.202 7.789 0.07% 12815.410op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.077µs 64.296µs ± 0.075µs 64.285µs ± 0.047µs 64.341µs 64.434µs 64.517µs 64.576µs 0.45% 0.747 1.018 0.12% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15485730.792op/s 15553121.803op/s ± 18138.563op/s 15555644.635op/s ± 11475.274op/s 15566056.657op/s 15577828.467op/s 15583387.268op/s 15606184.731op/s 0.32% -0.738 1.002 0.12% 1282.590op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.392µs 57.558µs ± 0.105µs 57.541µs ± 0.068µs 57.621µs 57.737µs 57.887µs 58.017µs 0.83% 1.037 1.866 0.18% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17236206.057op/s 17373686.298op/s ± 31595.290op/s 17378775.302op/s ± 20623.411op/s 17397018.590op/s 17416450.883op/s 17422698.309op/s 17424121.954op/s 0.26% -1.022 1.807 0.18% 2234.124op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.894µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.917µs 3.919µs 3.921µs 0.26% -0.072 4.374 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255034436.631op/s 255673489.370op/s ± 204904.076op/s 255694131.820op/s ± 118716.668op/s 255804937.592op/s 255907811.263op/s 256015513.022op/s 256801937.112op/s 0.43% 0.087 4.435 0.08% 14488.906op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.557µs 54.796µs ± 0.152µs 54.767µs ± 0.080µs 54.851µs 55.106µs 55.371µs 55.448µs 1.24% 1.681 3.885 0.28% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 18034933.370op/s 18249753.679op/s ± 50469.079op/s 18259269.965op/s ± 26818.463op/s 18285017.257op/s 18307856.725op/s 18322275.841op/s 18329449.927op/s 0.38% -1.656 3.774 0.28% 3568.703op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.127µs 52.198µs ± 0.038µs 52.194µs ± 0.025µs 52.223µs 52.253µs 52.286µs 52.395µs 0.38% 0.955 3.170 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19085944.305op/s 19157927.852op/s ± 13764.863op/s 19159170.849op/s ± 9256.091op/s 19167076.713op/s 19177924.771op/s 19182866.171op/s 19184075.299op/s 0.13% -0.946 3.123 0.07% 973.323op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.721µs 5.883µs ± 0.067µs 5.882µs ± 0.044µs 5.930µs 5.995µs 6.031µs 6.039µs 2.67% -0.052 -0.325 1.14% 0.005µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165581757.118op/s 169998606.343op/s ± 1936450.138op/s 169997039.902op/s ± 1266605.261op/s 171123963.512op/s 173418180.468op/s 174412890.794op/s 174799798.960op/s 2.83% 0.109 -0.314 1.14% 136927.702op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255606850.987op/s; 255660034.968op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [81.350µs; 81.637µs] or [-0.176%; +0.176%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12251258.930op/s; 12294569.033op/s] or [-0.176%; +0.176%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [74.904µs; 74.955µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13341425.392op/s; 13350500.410op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255639536.087op/s; 255692233.276op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.030µs; 72.082µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number/378282246310005 throughput [13873110.071op/s; 13883188.840op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.187µs; 52.196µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19158416.348op/s; 19161751.644op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.869µs; 5.888µs] or [-0.166%; +0.166%] None None None
credit_card/is_card_number/x371413321323331 throughput [169854525.922op/s; 170421410.210op/s] or [-0.167%; +0.167%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255651779.491op/s; 255702014.974op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.285µs; 64.306µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15550607.973op/s; 15555635.633op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.544µs; 57.573µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17369307.495op/s; 17378065.101op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255645091.635op/s; 255701887.104op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.775µs; 54.817µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18242759.150op/s; 18256748.208op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.193µs; 52.203µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19156020.174op/s; 19159835.530op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.874µs; 5.892µs] or [-0.158%; +0.158%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [169730232.978op/s; 170266979.708op/s] or [-0.158%; +0.158%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 73.707ms 74.320ms ± 0.197ms 74.303ms ± 0.114ms 74.421ms 74.669ms 74.818ms 75.119ms 1.10% 0.627 1.649 0.26% 0.014ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [74.293ms; 74.348ms] or [-0.037%; +0.037%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 84.635µs 84.869µs ± 0.185µs 84.839µs ± 0.061µs 84.908µs 85.028µs 85.704µs 86.448µs 1.90% 5.380 38.494 0.22% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [84.843µs; 84.895µs] or [-0.030%; +0.030%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 144.537µs 145.146µs ± 0.634µs 145.066µs ± 0.128µs 145.198µs 145.722µs 146.238µs 153.118µs 5.55% 10.141 123.762 0.44% 0.045µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [145.058µs; 145.234µs] or [-0.061%; +0.061%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 205.893µs 206.223µs ± 0.212µs 206.184µs ± 0.148µs 206.359µs 206.629µs 206.798µs 207.066µs 0.43% 0.875 0.715 0.10% 0.015µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4829381.855op/s 4849132.109op/s ± 4977.704op/s 4850040.993op/s ± 3488.458op/s 4852878.751op/s 4855530.322op/s 4856705.427op/s 4856884.673op/s 0.14% -0.870 0.696 0.10% 351.977op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.224µs 18.359µs ± 0.164µs 18.310µs ± 0.047µs 18.389µs 18.583µs 18.798µs 20.039µs 9.45% 5.877 53.502 0.89% 0.012µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 49901718.987op/s 54474625.959op/s ± 464366.416op/s 54615596.456op/s ± 139081.705op/s 54727689.747op/s 54806167.659op/s 54852590.683op/s 54873869.157op/s 0.47% -5.351 45.900 0.85% 32835.664op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.922µs 10.992µs ± 0.032µs 10.989µs ± 0.022µs 11.013µs 11.045µs 11.069µs 11.125µs 1.24% 0.530 0.745 0.29% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 89889244.100op/s 90977533.199op/s ± 265037.536op/s 91000502.069op/s ± 183803.286op/s 91151930.791op/s 91365872.724op/s 91546767.199op/s 91556146.982op/s 0.61% -0.508 0.689 0.29% 18740.984op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [206.193µs; 206.252µs] or [-0.014%; +0.014%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4848442.247op/s; 4849821.971op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.336µs; 18.381µs] or [-0.124%; +0.124%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54410269.240op/s; 54538982.678op/s] or [-0.118%; +0.118%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.987µs; 10.996µs] or [-0.040%; +0.040%] None None None
normalization/normalize_name/normalize_name/good throughput [90940801.545op/s; 91014264.852op/s] or [-0.040%; +0.040%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.909µs 536.590µs ± 0.570µs 536.497µs ± 0.254µs 536.804µs 537.262µs 537.603µs 542.686µs 1.15% 6.263 63.688 0.11% 0.040µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1842685.196op/s 1863621.160op/s ± 1965.601op/s 1863943.526op/s ± 880.739op/s 1864734.517op/s 1865493.312op/s 1865925.950op/s 1865988.032op/s 0.11% -6.179 62.484 0.11% 138.989op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 379.105µs 379.852µs ± 0.358µs 379.808µs ± 0.263µs 380.099µs 380.424µs 380.733µs 380.929µs 0.30% 0.332 -0.356 0.09% 0.025µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2625158.722op/s 2632603.581op/s ± 2480.415op/s 2632908.205op/s ± 1825.741op/s 2634546.278op/s 2636049.208op/s 2637409.884op/s 2637793.456op/s 0.19% -0.328 -0.361 0.09% 175.392op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 194.671µs 195.120µs ± 0.597µs 195.022µs ± 0.113µs 195.166µs 195.488µs 195.966µs 201.072µs 3.10% 8.097 73.191 0.31% 0.042µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 4973352.646op/s 5125106.664op/s ± 15304.694op/s 5127620.054op/s ± 2970.687op/s 5130051.013op/s 5133624.982op/s 5135154.267op/s 5136868.481op/s 0.18% -8.009 72.012 0.30% 1082.205op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.872µs 37.025µs ± 0.104µs 37.039µs ± 0.099µs 37.118µs 37.179µs 37.207µs 37.216µs 0.48% 0.010 -1.447 0.28% 0.007µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26870030.144op/s 27008658.910op/s ± 75991.899op/s 26998695.007op/s ± 72501.523op/s 27090446.171op/s 27110289.549op/s 27115841.791op/s 27120968.722op/s 0.45% -0.006 -1.450 0.28% 5373.439op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.877µs 46.011µs ± 0.072µs 46.005µs ± 0.051µs 46.056µs 46.139µs 46.199µs 46.286µs 0.61% 0.682 0.520 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21604581.900op/s 21734178.607op/s ± 34050.869op/s 21736820.241op/s ± 24225.557op/s 21761149.145op/s 21781168.093op/s 21789910.191op/s 21797319.802op/s 0.28% -0.673 0.495 0.16% 2407.760op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.511µs; 536.669µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1863348.747op/s; 1863893.574op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [379.803µs; 379.902µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2632259.819op/s; 2632947.343op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [195.037µs; 195.202µs] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5122985.581op/s; 5127227.748op/s] or [-0.041%; +0.041%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.011µs; 37.040µs] or [-0.039%; +0.039%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26998127.164op/s; 27019190.657op/s] or [-0.039%; +0.039%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.001µs; 46.021µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21729459.484op/s; 21738897.730op/s] or [-0.022%; +0.022%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.448µs 2.480µs ± 0.024µs 2.480µs ± 0.018µs 2.494µs 2.536µs 2.541µs 2.543µs 2.54% 0.787 0.214 0.96% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.476µs; 2.483µs] or [-0.133%; +0.133%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.053µs 5.135µs ± 0.056µs 5.154µs ± 0.068µs 5.175µs 5.238µs 5.240µs 5.242µs 1.72% 0.314 -1.111 1.08% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.127µs; 5.143µs] or [-0.150%; +0.150%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 00d1748 1753192052 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.218µs 33.744µs ± 0.930µs 33.325µs ± 0.050µs 33.405µs 35.700µs 35.736µs 37.413µs 12.27% 1.788 1.541 2.75% 0.066µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.616µs; 33.873µs] or [-0.382%; +0.382%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 495 lines in your changes missing coverage. Please review.

Project coverage is 71.21%. Comparing base (4eb2b86) to head (00d1748).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
- Coverage   71.30%   71.21%   -0.10%     
==========================================
  Files         345      342       -3     
  Lines       53148    52977     -171     
==========================================
- Hits        37898    37725     -173     
- Misses      15250    15252       +2
Components Coverage Δ
datadog-crashtracker 43.94% <ø> (ø)
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 86.98% <ø> (-0.02%) ⬇️
data-pipeline-ffi 88.36% <ø> (ø)
ddcommon 82.88% <ø> (ø)
ddcommon-ffi 69.66% <ø> (ø)
ddtelemetry 60.08% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.58% <ø> (ø)
datadog-profiling 77.13% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 38.17% <0.00%> (-2.08%) ⬇️
datdog-sidecar-ffi 4.91% <0.00%> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 90.96% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.72% <ø> (ø)
datadog-tracer-flare 75.14% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from 88e2fff to d0dd988 Compare June 3, 2025 14:07
@r1viollet
Copy link
Contributor

r1viollet commented Jun 3, 2025 •
edited by ekump
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 22.12 MB 22.12 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 70.32 MB 70.32 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 9.24 MB 9.24 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 26.18 MB 26.18 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 82.55 MB 82.55 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.16 MB 9.16 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 18.40 MB 18.40 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 65.03 KB 65.03 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 124.94 MB 124.97 MB +.01% (+24.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 646.92 MB 646.92 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.89 MB 5.89 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 65.03 KB 65.03 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.35 MB 17.35 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 32.19 MB 32.19 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 15.69 MB 15.69 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 66.03 KB 66.03 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 127.33 MB 127.33 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 636.65 MB 636.65 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.49 MB 4.49 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 66.03 KB 66.03 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.48 MB 18.49 MB +.04% (+8.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 30.23 MB 30.23 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 63.04 MB 63.04 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.85 MB 9.85 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 20.97 MB 20.97 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 77.49 MB 77.49 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.75 MB 9.75 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 24.10 MB 24.10 MB 0% (0 B) 👌

bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch 4 times, most recently from 8108039 to e69e142 Compare June 17, 2025 13:23
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from e69e142 to 2671326 Compare June 18, 2025 11:35
bwoebi
bwoebi reviewed Jun 18, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from 9257c8b to 97e94de Compare June 18, 2025 12:57
bwoebi
bwoebi reviewed Jun 18, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch 2 times, most recently from bd0fe85 to 74e40d7 Compare June 18, 2025 14:09
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch 2 times, most recently from bfe0484 to c38ee2c Compare July 7, 2025 13:53
bwoebi
bwoebi reviewed Jul 8, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jul 8, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jul 8, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from c38ee2c to f1c42c2 Compare July 8, 2025 15:20
@github-actions github-actions bot removed the telemetry label Jul 8, 2025
@Leiyks Leiyks marked this pull request as ready for review July 9, 2025 15:16
@Leiyks Leiyks requested review from a team as code owners July 9, 2025 15:16
bwoebi
bwoebi reviewed Jul 11, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch 3 times, most recently from d7537b7 to 2b562ab Compare July 16, 2025 12:52
Leiyks added 15 commits July 22, 2025 15:47
@Leiyks
feat(sidecar): add telemetry clients expiration
c9f3cd5 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): buffer integrations and dependencies
ace698c 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): replace tokio Mutex by standard one for consistency
2042c21 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): use cached telemetry clients
3fd3fa4 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): update TelemetryCachedClient structs
1a19995 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): clean sidecar server telemetry behaviour
3a6195a 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): remove unused AppInstance and EnqueuedTelemetryData an…
66ca6fd 
…d refacto telemetry

Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): apply feedbacks
e6c4dba 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar): expose path_for_telemetry
611cefc 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
chore: add debug logs
8b17815 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
chore: fix telemetry lifecycle
6a1d092 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
chore: merge telemetry module
ddc96eb 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat: apply PR suggestions
f0848cb 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat: remove needs for version
d1e2f85 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks
feat(sidecar: telemetry): handle config buffering
00d1748 
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from 2b562ab to 00d1748 Compare July 22, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoebi bwoebi bwoebi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
sidecar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leiyks @codecov-commenter @r1viollet @bwoebi