Skip to content

attempt to reduce flakiness of trace exporter shutdown tests #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ekump
Copy link
Contributor

@ekump ekump commented Jul 3, 2025

What does this PR do?

Attempts to reduce the likelihood of the trace exporter shutdown unit tests flaking on CI by:

  • Directly checking AGENT_INFO_CACHE to be Some instead of checking the mock /info endpoint is hit. This is a potential race condition in tests as there is a non-zero amount of time between the endpoint being hit, the cache being populated, and the exporter checking the cache to know if it should enable the stats worker.
  • Added a test-only function to check if stats computation is enabled and the worker is running. In tests it may be possible that we start the shutdown before stats worker is active.

Motivation

Flaky tests aren't cool

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant