fix(ingress-nginx): filter out healthcheck traces #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmehala
force-pushed
the
dmehala/inginx-sample-out-stubstatus
branch
from
f5ed224 to
9afd9b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, ingress-nginx defines the /nginx_status endpoint. This configuration causes unnecessary traces to be sent to Datadog.
This commit updates the sampling rules to exclude traces originating from this endpoint.
Note to Reviewer
This change serves as a temporary workaround. In the long term, our module should be updated to avoid generating traces when
stub_statusis enabled.