Add tests from the official test suite #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports tests from https://github.com/apache/orc/tree/main/examples and adds tests which read using this crate, output JSON, and compare with the expected results.
As a side-effect, I also amended write.py to write in that format, and run the same kind of test on those.
This works well for the latter (except
test
andf32_long_long_gzip
because of inconsistent JSON serialization between Python and Rust); but I am struggling to make it work on any test of the official test suite.Here are the errors I'm getting on the five tests I'm running from the official test suite:
Timestamp not implemented
is expected, but I can't make the others work. Any idea if it's a bug in my test code, or limitations in the rest of the crate?