forked from dbt-labs/jaffle_shop_duckdb
-
Notifications
You must be signed in to change notification settings - Fork 3
Refactor Customers Model: Convert CTEs into Intermediate Models #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
even-wei
wants to merge
1
commit into
main
Choose a base branch
from
refactor/customers-cte-to-models
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
989057f
to
21de9d2
Compare
21de9d2
to
a48228a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a48228a
to
24411d3
Compare
Recce SummaryLineage Graphgraph LR
model.jaffle_shop.customers["customers
[What's Changed]
Code"]
style model.jaffle_shop.customers stroke:#ffa502
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.customer_segments["customer_segments"]
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]
Checks Summary
Next StepsIf you want to check more detail inforamtion about the recce result, please download the artifact file and open it by Recce CLI. How to check the recce result# Unzip the downloaded artifact file
tar -xf recce-state-file.zip
# Launch the recce server based on the state file
recce server --review recce_state.json
# Open the recce server http://localhost:8000 by your browser |
24411d3
to
e639327
Compare
Recce SummaryLineage Graphgraph LR
model.jaffle_shop.customers["customers
[What's Changed]
Code"]
style model.jaffle_shop.customers stroke:#ffa502
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.customer_segments["customer_segments"]
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]
Checks Summary
Next StepsIf you want to check more detail inforamtion about the recce result, please download the artifact file and open it by Recce CLI. How to check the recce result# Unzip the downloaded artifact file
tar -xf recce-state-file.zip
# Launch the recce server based on the state file
recce server --review recce_state.json
# Open the recce server http://localhost:8000 by your browser |
e639327
to
0b8e642
Compare
Recce SummaryManifest Information
Lineage Graphgraph LR
model.jaffle_shop.customers["customers
[What's Changed]
Code"]
style model.jaffle_shop.customers stroke:#ffa502
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.customer_segments["customer_segments"]
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]
Checks Summary
Checks of Data Mismatch Detected
See PR page: https://cloud.datarecce.io/DataRecce/jaffle_shop_duckdb/pulls/2 How to check the recce result# Launch the recce server based on the state file
recce server --review --cloud --password yummy_jaffle
# Open the recce server http://localhost:8000 by your browser |
0a2188b
to
a4dd026
Compare
4509780
to
4248a98
Compare
4248a98
to
e4ee394
Compare
e4ee394
to
e23db56
Compare
e23db56
to
e4ee394
Compare
e4ee394
to
6d4ed11
Compare
6d4ed11
to
5dc50e1
Compare
5dc50e1
to
70151fe
Compare
Signed-off-by: Even Wei <[email protected]>
70151fe
to
ae474ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Refactored the customers model by turning two CTEs into intermediate models, enhancing readability and maintainability.
Changes:
Rationale:
Improves clarity and allows easier future modifications.
Testing:
Ensured accuracy and consistency in results post-refactor.
Review Request:
Feedback on the implementation and integration of the new models is welcomed.