forked from dbt-labs/jaffle_shop_duckdb
-
Notifications
You must be signed in to change notification settings - Fork 3
[Demo] Understand if a customer has promoted orders #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
popcornylu
wants to merge
3
commits into
main
Choose a base branch
from
feature/add-payment-promotion-column
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a39f5e
to
1967696
Compare
Recce SummaryManifest Information
Lineage Graphgraph LR
model.jaffle_shop.customers["customers
[What's Changed]
Code, Schema"]
style model.jaffle_shop.customers stroke:#ffa502
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.stg_payments["stg_payments
[What's Changed]
Code, Schema"]
style model.jaffle_shop.stg_payments stroke:#ffa502
model.jaffle_shop.stg_payments---->model.jaffle_shop.orders
model.jaffle_shop.stg_payments---->model.jaffle_shop.customers
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]
model.jaffle_shop.customer_segments["customer_segments"]
model.jaffle_shop.orders["orders
[What's Changed]
"]
Checks Summary
Checks of Data Mismatch Detected
See PR page: https://cloud.datarecce.io/DataRecce/jaffle_shop_duckdb/pulls/44 How to check the recce result# Launch the recce server based on the state file
recce server --review --cloud --password yummy_jaffle
# Open the recce server http://localhost:8000 by your browser |
Signed-off-by: popcorny <[email protected]>
1967696
to
95ea88c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we want to understand if a customer has ever had an promotion order.
is_promotion
in thestg_payment
model, it is true if the method iscoupon
is_promotion = true
We can see the stg_payment is a non-breaking change, it would not affect the downstream models (e.g.
orders
)