feat: custom schema #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthmiguel
commented
Jul 31, 2018
darthmiguel
commented
- add custom schema flag to the config
- refactor toStruct method
- refactor toStruct implementation StringStructConverter
- refactor toStruct implementation JsonStructConverter
- ConverterUtils, methods to extract the schema from the record value
* add custom schema flag to the config * refactor toStruct method * refactor toStruct implementation StringStructConverter * refactor toStruct implementation JsonStructConverter * ConverterUtils, methods to extract the schema from the record value
invadergir
reviewed
Jul 31, 2018
| Struct messageStruct = getStruct(message); | ||
| String topic = getTopic(message); | ||
| String db = getDB(message); | ||
| String timestamp = getTimestamp(message); | ||
| records.add(new SourceRecord(Collections.singletonMap("mongodb", db), Collections.singletonMap(db, timestamp), topic, messageStruct.schema(), messageStruct)); | ||
| Object objectKey = ((Map<String, Object>) message.get("o")).get("_id"); | ||
|
|
There was a problem hiding this comment.
Can you please clean up the extraneous whitespace here and at line 152?
invadergir
reviewed
Jul 31, 2018
| } | ||
|
|
||
| try{ | ||
| customSchema = Boolean.parseBoolean(map.get(MongodbSourceConfig.CUSTOM_SCHEMA)); |
There was a problem hiding this comment.
I would suggest making the boolean optional (check for existence with map.containsKey()), and if not specified, default to false to allow the original behavior. The new behavior will be opt-in then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.