Use cache atomically #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces an alternative method for the cache helper that allows reducing the public API and removes the need for coordinating method calls. It also reduces the amount of method calls needed to use the object, which is usually irrelevant for small projects but should show improvements when scanning several files. Signed-off-by: Luís Cobucci <[email protected]>
This removes unused methods and their tests. Signed-off-by: Luís Cobucci <[email protected]>
|
@DaveLiddament is this relevant? I can rebase it but will only invest in it if you see value 😁 |
|
@lcobucci thanks for this PR. Sorry I have neglected it. I'm have a think about the caching in general. I'm wondering when using the reflection provider, I should store the attributes for all the rules and cache those. Then we are only doing one reflection call for each method per analysis run, rather than per rule per analysis run. I'll get back to you. Thanks once again for your interest in this project. |
|
It's all good @DaveLiddament, this was just me trying to clean up my list of open PRs 🤣 Take your time and I'm quite alright with having this closed as outcome. No hard feelings there. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor improvement on how the cache component works, allowing it to better encapsulate its concepts.