Bug/fix srctool output #1269
Merged
Bug/fix srctool output #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et implemented their execution.
DavidT3
requested changes
Nov 25, 2024
…t_out' variable when there is no viable install. For PR #1269
DavidT3
requested changes
Dec 3, 2024
…und on the system
… number generators
DavidT3
reviewed
Dec 5, 2024
DavidT3
reviewed
Dec 5, 2024
DavidT3
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok we have figured out what is happening - is to do with the new version of srctool in eSASSDR1. There is a new parameter “write_insts”, by default this will be “0 1 2 3 4 5 6 7 8 9", so when you run srctool for individual instruments you will currently output: 020_SourceSpec.fits, 220_SourceSpec.fits, 820_SourceSpec.fits. Therefore when the next command is run for the next instrument it will try to output files called 020_SourceSpec.fits and 820_SourceSpec.fits, which already exist. So it errors because it can’t write out the file.
Have added commands to remove these extra files.
Have also added checking of eSASS version in utils fixed a bug where an error was generated if ciao was not initialised.