Feat/pressure profile class #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulate pressure, but that will be a very simple adaptation of the existing entropy calculation method. For issue #1272. Also updated some parts of the SpecificEntropy class to match improvements I made in HydrostaticMass.
…ction - indirectly for issue #1272
…. For issue #1272 (indirectly)
…. For issue #1272 (indirectly)
…. For issue #1272 (indirectly)
…. For issue #1272 (indirectly)
… Indirectly for issue #1272 as the fitted pressure models aren't displaying completely correctly.
…mum plotting distance (in BaseProfile1D/Aggregate...) get_view/view methods. This is because the value is going to zero, which will result in an infinite value from some values. I was going to stop the model going any further than the rad position of the first data point, but instead I've increased the number of model radii steps to plot. It won't stop that infinite problem, but it will get the model plotting much closer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.