-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/e rosita school updates #1292
Feat/e rosita school updates #1292
Conversation
…3/XGA into feat/eROSITASchoolUpdates
xga/generate/esass/spec.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is identical, not sure why it is a change here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is probably because vscode sometimes very annoyingly adds 'non-breaking spaces' rather than just the standard space character - https://stackoverflow.com/questions/57162734/vscode-inserting-non-breaking-spaces-instead-of-regular-spaces
It can be mildly irritating because they don't render as spaces in Pycharm, they just say #NBSP or something like that - doesn't matter here which it is though, and can't tell in the review interface anyway!
xga/generate/esass/spec.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is probably because vscode sometimes very annoyingly adds 'non-breaking spaces' rather than just the standard space character - https://stackoverflow.com/questions/57162734/vscode-inserting-non-breaking-spaces-instead-of-regular-spaces
It can be mildly irritating because they don't render as spaces in Pycharm, they just say #NBSP or something like that - doesn't matter here which it is though, and can't tell in the review interface anyway!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
This is a tiny change, just adding in two arguments to the expmap command, that were recommended by the eROSITA analysis school