Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/e rosita school updates #1292

Merged
merged 14 commits into from
Jan 8, 2025

Conversation

jessicapilling
Copy link
Collaborator

This is a tiny change, just adding in two arguments to the expmap command, that were recommended by the eROSITA analysis school

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is identical, not sure why it is a change here

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably because vscode sometimes very annoyingly adds 'non-breaking spaces' rather than just the standard space character - https://stackoverflow.com/questions/57162734/vscode-inserting-non-breaking-spaces-instead-of-regular-spaces

It can be mildly irritating because they don't render as spaces in Pycharm, they just say #NBSP or something like that - doesn't matter here which it is though, and can't tell in the review interface anyway!

xga/generate/esass/phot.py Show resolved Hide resolved
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably because vscode sometimes very annoyingly adds 'non-breaking spaces' rather than just the standard space character - https://stackoverflow.com/questions/57162734/vscode-inserting-non-breaking-spaces-instead-of-regular-spaces

It can be mildly irritating because they don't render as spaces in Pycharm, they just say #NBSP or something like that - doesn't matter here which it is though, and can't tell in the review interface anyway!

Copy link
Owner

@DavidT3 DavidT3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@jessicapilling jessicapilling merged commit 6954615 into feat/integrateMultiMiss Jan 8, 2025
1 check passed
@jessicapilling jessicapilling deleted the feat/eROSITASchoolUpdates branch January 8, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants