Skip to content

Datagen remaining tags#233

Merged
Hugman76 merged 4 commits intodevfrom
ft/datagen-remaining-tags
Nov 11, 2025
Merged

Datagen remaining tags#233
Hugman76 merged 4 commits intodevfrom
ft/datagen-remaining-tags

Conversation

@Hugman76
Copy link
Member

@Hugman76 Hugman76 commented Oct 3, 2025

This also has some effects on gameplay:

  • Capybaras and ducks are now considered friendly by ghastlings
  • Iron golems can now offer gifts to capybaras
  • Ducks no longer fall through powder snow
  • Capybaras are no longer scary for pufferfish
  • Capybaras are now sensitive to the Impaling enchantment

This also adds translations for every tag added by Promenade (modded+conventional) to enable wider compatiblity with other mods

@github-project-automation github-project-automation bot moved this to 🧐 Needs Review in Main Project Oct 3, 2025
@Hugman76 Hugman76 requested a review from Copilot October 10, 2025 16:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements data generation for remaining tags, primarily focusing on moving from manually created JSON tag files to a data generation approach, while adding conventional tag support for broader mod compatibility.

  • Removes manually created conventional tag JSON files and replaces them with data generation
  • Adds conventional tag definitions and translations for all Promenade tags
  • Updates entity type tags to support new gameplay behaviors (ghastling friendliness, iron golem gifts, powder snow walking, etc.)

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
c/tags/item/*.json Removed manually created conventional tag files
c/tags/entity_type/*.json Removed manually created conventional entity type tag files
PromenadeItemTags.java Added conventional tag definitions and reorganized animal food tags
PromenadeEntityTypeTags.java New file defining conventional entity type tags
PromenadeBlockTags.java Added conventional tag definitions for igneous rocks
PromenadeBiomeTags.java Added conventional biome tags and renamed witch hut tag
Provider classes Updated data generation to include conventional tags and new entity behaviors
PromenadeEnglishLangProvider.java Added translations for all tags to support mod compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Hugman76 Hugman76 merged commit e5c4550 into dev Nov 11, 2025
1 check passed
@Hugman76 Hugman76 deleted the ft/datagen-remaining-tags branch November 11, 2025 13:46
@github-project-automation github-project-automation bot moved this from 🧐 Needs Review to ✨ Done in Main Project Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant