Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements data generation for remaining tags, primarily focusing on moving from manually created JSON tag files to a data generation approach, while adding conventional tag support for broader mod compatibility.
- Removes manually created conventional tag JSON files and replaces them with data generation
- Adds conventional tag definitions and translations for all Promenade tags
- Updates entity type tags to support new gameplay behaviors (ghastling friendliness, iron golem gifts, powder snow walking, etc.)
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| c/tags/item/*.json | Removed manually created conventional tag files |
| c/tags/entity_type/*.json | Removed manually created conventional entity type tag files |
| PromenadeItemTags.java | Added conventional tag definitions and reorganized animal food tags |
| PromenadeEntityTypeTags.java | New file defining conventional entity type tags |
| PromenadeBlockTags.java | Added conventional tag definitions for igneous rocks |
| PromenadeBiomeTags.java | Added conventional biome tags and renamed witch hut tag |
| Provider classes | Updated data generation to include conventional tags and new entity behaviors |
| PromenadeEnglishLangProvider.java | Added translations for all tags to support mod compatibility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/datagen/java/fr/hugman/promenade/data/provider/PromenadeItemTagProvider.java
Show resolved
Hide resolved
src/datagen/java/fr/hugman/promenade/data/provider/PromenadeEntityTypeTagProvider.java
Show resolved
Hide resolved
src/datagen/java/fr/hugman/promenade/data/provider/PromenadeBlockTagProvider.java
Show resolved
Hide resolved
src/datagen/java/fr/hugman/promenade/data/provider/PromenadeBlockTagProvider.java
Show resolved
Hide resolved
src/datagen/java/fr/hugman/promenade/data/provider/PromenadeBiomeTagProvider.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also has some effects on gameplay:
This also adds translations for every tag added by Promenade (modded+conventional) to enable wider compatiblity with other mods