Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds shelf blocks for four custom wood types in the Promenade mod: Sakura, Maple, Palm, and Dark Amaranth. Shelves are functional storage blocks introduced in Minecraft 1.21 that can store books and other items.
Key changes:
- Added shelf factory method to BlockFactory for creating shelf blocks from planks
- Registered four shelf blocks with proper block entities, recipes, models, tags, and loot tables
- Added shelf textures for all four wood types
Reviewed changes
Copilot reviewed 10 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/fr/hugman/promenade/block/helper/BlockFactory.java | Adds shelf factory method with proper settings including SHELF sound group and container component |
| src/main/java/fr/hugman/promenade/block/PromenadeBlocks.java | Registers four shelf blocks (Sakura, Maple, Palm, Dark Amaranth) and consolidates imports |
| src/main/java/fr/hugman/promenade/registry/PromenadeFlammables.java | Registers flammability for three shelf types (Dark Amaranth excluded as Nether wood) |
| src/main/java/fr/hugman/promenade/block/entity/PromenadeBlockEntities.java | Adds shelf blocks to vanilla SHELF block entity type |
| src/main/java/fr/hugman/promenade/itemgroup/PromenadeItemGroupAdditions.java | Places shelves in creative inventory after corresponding vanilla wood shelves |
| src/datagen/java/fr/hugman/promenade/data/provider/PromenadeRecipeGenerator.java | Generates crafting recipes for all four shelf types |
| src/datagen/java/fr/hugman/promenade/data/provider/PromenadeModelProvider.java | Registers shelf models using stripped log textures |
| src/datagen/java/fr/hugman/promenade/data/provider/PromenadeBlockTagProvider.java | Adds shelves to WOODEN_SHELVES block tag |
| src/datagen/java/fr/hugman/promenade/data/provider/PromenadeItemTagProvider.java | Copies WOODEN_SHELVES tag from blocks to items |
| src/datagen/java/fr/hugman/promenade/data/provider/PromenadeBlockLootTableProvider.java | Adds simple drop loot tables for all four shelf types |
| src/client/resources/assets/promenade/textures/block/sakura_shelf.png | Adds Sakura shelf texture |
| src/client/resources/assets/promenade/textures/block/maple_shelf.png | Adds Maple shelf texture |
| src/client/resources/assets/promenade/textures/block/palm_shelf.png | Adds Palm shelf texture |
| src/client/resources/assets/promenade/textures/block/dark_amaranth_shelf.png | Adds Dark Amaranth shelf texture |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.