fix(workflows): optimize project file discovery logic #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `GetCurrentDirectory` calls with `AtomRootDirectory` for accurate root resolution. Enhanced file enumeration with filters for `.csproj` files and added `EnumerationOptions` to handle recursion, inaccessible paths, and exclusion of special directories. This improves performance and ensures reliable project path resolution.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request optimizes project file discovery logic by replacing unreliable current directory detection with a root-based approach using AtomRootDirectory, and enhancing the file search with proper filtering and enumeration options.
Key Changes
- Replaced
GetCurrentDirectory()withAtomRootDirectoryfor consistent root path resolution - Added
*.csprojfile filter toEnumerateFilesto avoid scanning all files - Configured
EnumerationOptionswith recursion depth limit, inaccessible path handling, and special directory exclusion
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DecSm.Atom.Module.GithubWorkflows/Generation/GithubWorkflowWriter.cs | Updated FindProjectPath method with optimized file discovery using root directory and enumeration options |
| DecSm.Atom.Module.DevopsWorkflows/Generation/DevopsWorkflowWriter.cs | Updated FindProjectPath method with optimized file discovery using root directory and enumeration options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
GetCurrentDirectorycalls withAtomRootDirectoryfor accurate root resolution. Enhanced file enumeration with filters for.csprojfiles and addedEnumerationOptionsto handle recursion, inaccessible paths, and exclusion of special directories. This improves performance and ensures reliable project path resolution.