Merge main #16
Open
Merge main #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that there's extra quotes in split_part macro because if you run dbt_utils.get_url_paramter code for clickhouse results in extra quotes around field name.
This reverts commit a99ef52.
Previous commit changed all sql to lowercase. Sorry. Fixed.
Changed from splitByChar to splitByStrig because sometimes you need more than one char to split.
…terialization layout
Fix quotation in split_part macro
…yout-dictionary feat: support range based dictionary layouts
…s-for-empty-model Apply query settings for empty table model
Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>
Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>
…tests-changelog Add range based dictionary to CHANGELOG + tests
Support replace view
revert readme changes
fix: create materialized view on cluster
Revert "fix: create materialized view on cluster"
feat: allow using TLS client certificates
…-issue don't drop local tables when there is no distributed table
…on-cluster Support of insert_overwrite in cluster setup
optimise adding projections and indexes in one statement, to avoid er…
V1.8.9 housekeeping
Magicbeanbuyer
commented
Feb 20, 2025
| can_on_cluster = None | ||
| engine = None | ||
| # We placed a hardcoded const (instead of importing it from dbt-core) in order to decouple the packages | ||
| if relation_config.resource_type == NODE_TYPE_SOURCE: | ||
| if schema == relation_config.source_name and relation_config.database: | ||
| schema = relation_config.database | ||
|
|
||
| if cluster and str(relation_config.config.get("force_on_cluster")).lower() == "true": |
| {%- set local_db_prefix = adapter.get_clickhouse_local_db_prefix() -%} | ||
| {% set existing_local = existing_relation.incorporate(path={"identifier": this.identifier + local_suffix, "schema": local_db_prefix + this.schema}) if existing_relation is not none else none %} | ||
|
|
||
| {% if is_distributed %} |
There was a problem hiding this comment.
does this mean we could use insert_overwrite for ingestion cluster too?
Will investigate further with ticket DAPA-2889
There was a problem hiding this comment.
quite some substantial additions to MV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR: