Al/math/minpooling #410
Open
Al/math/minpooling #410
+148
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if self.get_backend() == "numpy": | ||
| return self._get_numpy(image, ksize, **kwargs,) | ||
| elif self.get_backend() == "torch": | ||
| return self._get_torch(image, ksize, **kwargs,) |
There was a problem hiding this comment.
I would prefer to check the type of the image, instead of checking the backend. So "if apc.is_torch_array(array): ...", like we have done in several of the features. But I don't think that the way it is done now is wrong
There was a problem hiding this comment.
We can always do both but I think maintaining consistency is more important in this case like you pointed out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.