Open
Conversation
The tested feature has been disabled in 9c679ce but the tests were left as is, and thus were failing.
Flatten implementation was changed in fbb2a33, but the tests were not updated. The new behaviour is expected as seen in the tests for flatten itself.
HTTP auth has been updated in cc17356 to include base64 validation, the test of this package have been updated but not the global one. We are now using values that are expected to be detected also in the global tests.
Since e4d27d8 (in a change that does not match the commit name), the private keys detected are returned completely instead of juste the first line. So the global tests had to be updated.
This reverts commit 73888f5. This commit breaks all the TestSingleValue that contain an URL. This is because the IniTransformer parses a colon as a key-value delimiter. Prior to this commit the result of the INI parser were always ignored if it consisted of a single key-value pair, and I think it is better this way. I don't really understand the point in trying to parse ini files beofre looking for secrets in them anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As said in #5 here are the fixes for the tests. See each commit comment for an explanation.