Skip to content

Conversation

@kiblik
Copy link
Contributor

@kiblik kiblik commented Oct 12, 2025

After #13405 is accepted, it might be a good idea to keep track of some other versions to avoid situations like #13401.

@kiblik kiblik force-pushed the renovate_workflows_versions branch 5 times, most recently from 1f00cfc to 888f0ab Compare October 12, 2025 19:46
@kiblik kiblik marked this pull request as ready for review October 12, 2025 20:06
@dryrunsecurity
Copy link

dryrunsecurity bot commented Oct 12, 2025

DryRun Security

This pull request contains automation/configuration issues: the ShellCheck workflow pins a version but requires manual SHA updates (risking integrity bypass if desynchronized), GitHub Actions node-version entries lack Renovate comments so they won't be auto-updated, and the Renovate config ignores key files (requirements.txt, package.json, Dockerfile) which may let dependencies go stale and vulnerable.

Risk of Integrity Bypass in Dependency Checksum in .github/workflows/shellcheck.yml
Vulnerability Risk of Integrity Bypass in Dependency Checksum
Description The workflow uses SHELLCHECK_VERSION which is configured for automatic updates by Renovate, but SHELLCHECK_SHA requires manual updates. This creates a desynchronization risk where Renovate could update the version, but the corresponding SHA is not updated. This mismatch could either cause build failures or, more critically, bypass an intended integrity check, opening a window for a supply chain attack if a malicious shellcheck binary is downloaded and executed.

SHELLCHECK_SHA: '038fd81de6b7e20cc651571362683853670cdc71' # Renovate config is not currently adjusted to update hash - it needs to be done manually for now
jobs:
shellcheck:
runs-on: ubuntu-latest

Outdated Node.js Dependency in .github/workflows/validate_docs_build.yml
Vulnerability Outdated Node.js Dependency
Description The node-version in the GitHub Actions workflow files (.github/workflows/validate_docs_build.yml and .github/workflows/gh-pages.yml) is not being managed by Renovate's custom manager. The custom regex manager in .github/renovate.json requires a specific comment format (# renovate: datasource=...) to detect and update versions. The node-version lines lack this required comment, meaning Renovate will not automatically update them. This will lead to the Node.js version becoming stale and potentially vulnerable over time.

- name: Setup Hugo
uses: peaceiris/actions-hugo@75d2e84710de30f6ff7268e08f310b60ef14033f # v3.0.0
with:
hugo-version: '0.140.1' # renovate: datasource=github-releases depName=gohugoio/hugo versioning=loose
extended: true
- name: Setup Node
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: '22.20.0' # TODO: Renovate helper might not be needed here - needs to be fully tested
- name: Cache dependencies
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0

Risk of Stale Dependencies due to Renovate Ignore Paths in .github/renovate.json
Vulnerability Risk of Stale Dependencies due to Renovate Ignore Paths
Description The Renovate configuration adds an ignorePaths list that prevents automated dependency updates for critical files like requirements.txt, package.json, and Dockerfile. This could lead to dependencies in these files becoming outdated and vulnerable over time, as they will be skipped by the automated update process. Without a clear, verifiable alternative mechanism for updating these dependencies, the project risks accumulating known vulnerabilities.

"ignorePaths": [
"requirements.txt",
"requirements-lint.txt",
"components/package.json",
"components/package-lock.json",
"dojo/components/yarn.lock",
"dojo/components/package.json",
"Dockerfile**"
],


All finding details can be found in the DryRun Security Dashboard.

@valentijnscholten valentijnscholten added this to the 2.51.1 milestone Oct 13, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kiblik kiblik force-pushed the renovate_workflows_versions branch from 888f0ab to 4d8020e Compare October 16, 2025 11:47
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@kiblik kiblik force-pushed the renovate_workflows_versions branch from 71014c7 to 380ae36 Compare October 16, 2025 12:46
@valentijnscholten valentijnscholten modified the milestones: 2.51.1, 2.51.2 Oct 16, 2025
@rossops rossops merged commit 211a54f into DefectDojo:bugfix Oct 16, 2025
149 checks passed
@kiblik kiblik deleted the renovate_workflows_versions branch October 16, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants