todo includes DateAdded in model and create action #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlbyk
reviewed
Dec 2, 2021
Comment on lines
87
to
88
| DateTime dateCreated = DateTime.UtcNow.Date; | ||
| todo.DateCreated = dateCreated; |
There was a problem hiding this comment.
If I create something at 10pm CT, should its DateCreated be captured as "tomorrow" because it's past midnight UTC?
Even if you want to render this as a date in the app, I'd generally treat this as a UTC timestamp of precisely when it was created. Formatting (local vs UTC, absolute vs relative time, etc) would be up to the client.
There was a problem hiding this comment.
Should be fixed now!
TodoApi/TodoApi/TodoApi.csproj
Outdated
| @@ -15,7 +15,11 @@ | |||
| </PackageReference> | |||
| <PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="3.1.3" /> | |||
| <PackageReference Include="Swashbuckle.AspNetCore" Version="5.0.0" /> | |||
| <PackageReference Include="Microsoft.AspNetCore.Identity" Version="2.1.6" /> | |||
There was a problem hiding this comment.
Did you find this to be necessary? This should be a transitive dependency of Microsoft.AspNetCore.Identity.EntityFrameworkCore.
There was a problem hiding this comment.
Nope, it ended up not being necessary. I went ahead and removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.