Refactor initialization Model
#562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Give (non-type) global constants upper case names and fixes issue #535 * Remove parametric type `T` from structs This is always set at Float64. Supporting parametric precision could be part of a separate PR (if we want to support this), including which structs would need type parameters. --------- Co-authored-by: Willem van Verseveld <[email protected]>
test/run_sbm.jl passes Co-authored-by: Bart de Koning <[email protected]>
test/run_sbm_gwf.jl passes
Containing shared land and river parameters, and `Network` data structure. Tests run_sbm and run_sbm_gwf pass.
Make use of shared river and land parameters.
In some cases the same data from netCDF is read more than once, in the function `ncread` logging is now optional when reading a netCDF variable.
Rename `fraction_to_river` to `flow_fraction_to_river` and `river` to `river_location`.
Co-authored-by: JoostBuitink <[email protected]>
JoostBuitink
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #523