Skip to content

Conversation

@aurifi
Copy link

@aurifi aurifi commented Oct 18, 2025

Description

Fixes an issue in which the base-path was duplicated while navigating to certain pages.

Addressed Issue

Fixes #1294
Fixes #1288
Fixes DependencyTrack/dependency-track#4958

Additional Details

According to the documentation of Vue Router the href-Property includes any existing base-path, which leads to a duplication on multiple links. To fix this route.fullPath was used instead, which does not contain the base.

image

Checklist

@owasp-dt-bot
Copy link

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@aurifi
Copy link
Author

aurifi commented Oct 31, 2025

Hey @nscuro :)
Is there anything I can do to get this reviewed?

Thanks and have a nice day!

@nscuro nscuro added this to the 4.14.0 milestone Oct 31, 2025
@nscuro nscuro added defect Something isn't working backport/4.13.6 PRs to be backported to version 4.13.6 labels Oct 31, 2025
@nscuro nscuro changed the title fix: don't duplicate base-path in links, #1294 fix: don't duplicate base-path in links Oct 31, 2025
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aurifi!

@nscuro nscuro merged commit f1e0635 into DependencyTrack:master Oct 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/4.13.6 PRs to be backported to version 4.13.6 defect Something isn't working

Projects

None yet

3 participants