Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do no try opening audio streams when the '-nosound' option is specified #639

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

Lgt2x
Copy link
Member

@Lgt2x Lgt2x commented Oct 26, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

When the option was specified, many messages were spamming the console in debug mode "Error opening stream X.osf on channel Y.". Now music is not started at all with "-nosound".

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

When the option was specified, many messages were spamming the console in debug mode "Error opening stream X.osf on channel Y."
@winterheart
Copy link
Collaborator

Tested on Linux and verified that all works as expected.

@winterheart winterheart merged commit 73d2764 into DescentDevelopers:main Oct 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants