Follow up to #701

[winterheart]

Pull Request Type

• GitHub Workflow changes
• Documentation or Wiki changes
• Build and Dependency changes
• Runtime changes
  • Render changes
  • Audio changes
  • Input changes
  • Network changes
  • Other changes

Description

Current -mission cmdline arg handling is broken. Intended use is direct load specified mission, but currently it fails with Int3().

Now Descent3 loads specified mission after selecting pilot and pressing "New game" in main menu.

Simplified code around direct loading missions.

Related Issues

Screenshots (if applicable)

Checklist

• I have tested my changes locally and verified that they work as intended.
• I have documented any new or modified functionality.
• I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
• I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

[Lgt2x]

This conflicts with #701 that takes a different approach. Yours will load the mission every time you select "New game", mine will load the level automatically once the pilot is selected, but only the first time. My use case for -mission is easily testing a level without any interaction on the menu before entering it, using a command-line like -pilot mypilot -mission d3 -loadlevel 4, but still give full access to the game once it has loaded once. TBH I'm fine with both.

[winterheart]

Oh, I didn't aware that there already #701 in PRs. Still, second commit still maybe useful.

[Lgt2x]

haha I thought you just didn't like the way I did it. Let's keep the 2nd commit

[winterheart]

Reworked PR after #701 merged.

[Lgt2x]

There are other instances left using an int argument out there in gamesequence.cpp if you mind fixing as well

[Lgt2x]

I can't find the d3oem.mn3 anywhere, we could even delete the #ifdef OEM I think (and even DEMO?)