e2e demos tests: switch on disable native automation #31362

EugeniyKiyashko · 2025-10-15T20:43:51Z

No description provided.

Copilot

Pull Request Overview

This PR modifies TestCafe configuration for demo visual tests, removing the disableNativeAutomation flag and standardizing HTML meta tags across demo files.

Key Changes

Removes disableNativeAutomation: true from TestCafe runner configuration
Adds locale environment variables (LANG and LC_ALL) set to UTF-8
Adds --disable-dev-shm-usage Chrome flag to the browser configuration
Simplifies meta tags in HTML demo files by consolidating charset declarations

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
apps/demos/utils/visual-tests/testcafe-runner.ts	Removes native automation disable flag, adds locale env vars, and adds Chrome flag for shared memory
apps/demos/Demos/Charts/ClientSideDataProcessing/jQuery/index.html	Consolidates meta tags: replaces separate IE compatibility and content-type tags with single charset meta tag
apps/demos/Demos/Charts/ClientSideDataProcessing/Angular/index.html	Consolidates meta tags: replaces separate IE compatibility and content-type tags with single charset meta tag
apps/demos/Demos/Charts/AxisCustomPosition/jQuery/index.html	Consolidates meta tags: replaces separate IE compatibility and content-type tags with single charset meta tag

Copilot

Pull Request Overview

Copilot reviewed 99 out of 222 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

apps/demos/testing/common.test.ts:1

The closing brace on line 200 creates an incorrect nesting structure. The console message assertions (lines 191-199) should execute regardless of the framework type, not only when comparisonResult is truthy. This appears to be a brace placement error that changes the intended control flow.

import { glob } from 'glob';

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…o/DevExtreme into 25_1_romans_issue

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull Request Overview

Copilot reviewed 83 out of 1479 changed files in this pull request and generated no new comments.

Copilot

Pull Request Overview

Copilot reviewed 83 out of 1519 changed files in this pull request and generated no new comments.

Copilot

Pull Request Overview

Copilot reviewed 83 out of 1642 changed files in this pull request and generated 1 comment.

Copilot · 2025-10-23T14:18:41Z

apps/demos/testing/common.test.ts

+
+              },
+              // eslint-disable-next-line spellcheck/spell-checker
+              textDiffTreshold: 0.1,


Corrected spelling of 'Treshold' to 'Threshold'

Suggested change

textDiffTreshold: 0.1,

textDiffThreshold: 0.1,

Copilot

Pull Request Overview

Copilot reviewed 83 out of 1759 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

apps/demos/testing/common.test.ts:1

Missing closing brace for the else block that starts at line 184. The code structure shows an if-else statement where the else block begins at line 184 but is never properly closed before this new if statement at line 200.

import { glob } from 'glob';

…o/DevExtreme into 25_1_romans_issue

Copilot

Pull Request Overview

Copilot reviewed 83 out of 2047 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

apps/demos/testing/common.test.ts:1

Missing closing brace for the else block that starts at line 184. The code structure shows an if (axeCheck) block starting at line 173 with an else at line 184, but the else block's closing brace is missing. The brace at line 209 appears to close the inner block starting at line 200, not the outer else block.

import { glob } from 'glob';

Copilot

Pull Request Overview

Copilot reviewed 83 out of 2054 changed files in this pull request and generated 2 comments.

Copilot · 2025-10-24T07:58:13Z

apps/demos/testing/common.test.ts

+          if (comparisonResult) {
+            const consoleMessages = await t.getBrowserConsoleMessages();

-          const errors = [...consoleMessages.error, ...consoleMessages.warn]
-            .filter((e) => !knownWarnings.some((kw) => e.startsWith(kw)));
+            const errors = [...consoleMessages.error, ...consoleMessages.warn]
+              .filter((e) => !knownWarnings.some((kw) => e.startsWith(kw)));

-          await t.expect(errors).eql([]);
-          await t.expect(comparisonResult).ok('INVALID_SCREENSHOT');
+            await t.expect(errors).eql([]);
+            await t.expect(comparisonResult).ok('INVALID_SCREENSHOT');
+          }


The logic appears inverted. Console error checking and screenshot validation should run when comparisonResult is falsy (indicating a mismatch), not when it's truthy. If comparisonResult is true, the comparison passed and assertions are unnecessary.

Copilot · 2025-10-24T07:58:13Z

apps/demos/testing/common.test.ts

+            const fastComparisonOptions = {
+              ...comparisonOptions,
+              looksSameComparisonOptions: {
+                ...comparisonOptions?.looksSameComparisonOptions,
+                tolerance: 10,
+                antialiasingTolerance: 10,
+
+              },
+              // eslint-disable-next-line spellcheck/spell-checker
+              textDiffTreshold: 0.1,
+            };


[nitpick] The empty line at line 191 within the looksSameComparisonOptions object should be removed to maintain consistent code formatting.

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 3ed53f0 to e515722 Compare October 15, 2025 22:02

Copilot AI review requested due to automatic review settings October 20, 2025 19:25

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from e515722 to 3bfba8a Compare October 20, 2025 19:25

EugeniyKiyashko requested a review from a team as a code owner October 20, 2025 19:25

Copilot AI reviewed Oct 20, 2025

View reviewed changes

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 3bfba8a to 960ab15 Compare October 20, 2025 20:02

EugeniyKiyashko requested a review from a team as a code owner October 20, 2025 20:02

Copilot AI review requested due to automatic review settings October 20, 2025 20:51

EugeniyKiyashko requested a review from a team as a code owner October 20, 2025 20:51

Copilot AI reviewed Oct 20, 2025

View reviewed changes

e2e demos tests: switch on disable native automation

428c50c

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 65bd7b1 to 4c42e0b Compare October 21, 2025 06:23

update etalons

3bdc5a4

Copilot AI review requested due to automatic review settings October 21, 2025 06:52

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 4c42e0b to 3bdc5a4 Compare October 21, 2025 06:52

EugeniyKiyashko requested a review from a team as a code owner October 21, 2025 06:52

Copilot AI reviewed Oct 21, 2025

View reviewed changes

replace etalons

5e70d3d

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 5e70d3d to 8770346 Compare October 22, 2025 08:34

Copilot AI review requested due to automatic review settings October 22, 2025 08:34

EugeniyKiyashko self-assigned this Oct 22, 2025

Copilot AI reviewed Oct 22, 2025

View reviewed changes

EugeniyKiyashko added 3 commits October 22, 2025 21:46

e2e demos tests: switch on disable native automation

8bee1c3

update etalons

bede550

replace etalons

229f2a1

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 8770346 to 229f2a1 Compare October 22, 2025 17:46

EugeniyKiyashko added 2 commits October 22, 2025 21:55

Merge branch '25_1_romans_issue' of https://github.com/EugeniyKiyashk…

cf654cc

…o/DevExtreme into 25_1_romans_issue

change chrome options

9600647

Copilot AI review requested due to automatic review settings October 22, 2025 17:57

Copilot AI reviewed Oct 22, 2025

View reviewed changes

Copilot AI reviewed Oct 23, 2025

View reviewed changes

try new settings

61dd3b0

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 1caa8e8 to 61dd3b0 Compare October 23, 2025 09:14

EugeniyKiyashko added force all tests 25_2 labels Oct 23, 2025

update screenshots and remove masks

e6a3389

Copilot AI review requested due to automatic review settings October 23, 2025 10:18

Copilot AI reviewed Oct 23, 2025

View reviewed changes

EugeniyKiyashko added 2 commits October 23, 2025 14:54

update etalons

1e75f93

update etalons

fe6b6ab

Copilot AI review requested due to automatic review settings October 23, 2025 11:34

Copilot AI reviewed Oct 23, 2025

View reviewed changes

EugeniyKiyashko added 2 commits October 23, 2025 17:20

change configuration

ad91171

unskip demos

338ec45

Copilot AI review requested due to automatic review settings October 23, 2025 14:18

Copilot AI reviewed Oct 23, 2025

View reviewed changes

EugeniyKiyashko added 3 commits October 23, 2025 18:50

update etalons

4e99b70

update etalons

75a49cb

Merge branch '25_2' into 25_1_romans_issue

f85cd03

Copilot AI review requested due to automatic review settings October 24, 2025 05:16

Copilot AI reviewed Oct 24, 2025

View reviewed changes

Merge branch '25_1_romans_issue' of https://github.com/EugeniyKiyashk…

f9170e9

…o/DevExtreme into 25_1_romans_issue

Copilot AI review requested due to automatic review settings October 24, 2025 05:57

Copilot AI reviewed Oct 24, 2025

View reviewed changes

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 20fcdca to 016c1bd Compare October 24, 2025 07:26

update

83e1f5e

Copilot AI review requested due to automatic review settings October 24, 2025 07:57

EugeniyKiyashko force-pushed the 25_1_romans_issue branch from 016c1bd to 83e1f5e Compare October 24, 2025 07:57

Copilot AI reviewed Oct 24, 2025

View reviewed changes

Merge branch '25_2' into 25_1_romans_issue

45db99e

e2e demos tests: switch on disable native automation #31362

Are you sure you want to change the base?

e2e demos tests: switch on disable native automation #31362

Uh oh!

Conversation

EugeniyKiyashko commented Oct 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant