e2e components tests: speed up tests execution #31379

EugeniyKiyashko · 2025-10-16T19:59:20Z

No description provided.

Copilot

Pull Request Overview

This PR reorganizes the e2e test infrastructure by moving Gantt, FilterBuilder, and Pagination tests to a common folder structure, and implements dynamic script loading to optimize test execution. The changes include relocating test files, updating import paths, and introducing conditional loading of external dependencies (Quill, Gantt, ASP.NET Data) based on test metadata.

Reviewed Changes

Copilot reviewed 44 out of 159 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
packages/testcafe-models/dataGrid/index.ts	Updated scrollBy method signature to require TestController parameter and add scrollable check
e2e/testcafe-devextreme/tests/scheduler/common/grouping/groupHeaderLongNamesCss.ts	Added debugging console.log statements to output page HTML
e2e/testcafe-devextreme/tests/scheduler/common/api/resourceRequestCount.ts	Added loadAspNetData metadata to tests requiring ASP.NET data
e2e/testcafe-devextreme/tests/scheduler/common/agenda/keyField.ts	Added loadAspNetData metadata to tests requiring ASP.NET data
e2e/testcafe-devextreme/tests/editors/selectBox/common.ts	Added loadAspNetData metadata to test requiring ASP.NET data
e2e/testcafe-devextreme/tests/editors/htmlEditor/*.ts	Added loadQuill metadata to tests requiring Quill library
e2e/testcafe-devextreme/tests/editors/chat/messageList.ts	Added loadAspNetData metadata to test requiring ASP.NET data
e2e/testcafe-devextreme/tests/dataGrid/*/.ts	Updated all scrollBy calls to include TestController parameter, added loadAspNetData metadata where needed
e2e/testcafe-devextreme/tests/container.html	Commented out static script loading for dx-quill, dx-gantt, dx.all, and dx.aspnet.data
e2e/testcafe-devextreme/tests/common/pagination/*.ts	Moved from tests/pagination/ and updated import paths
e2e/testcafe-devextreme/tests/common/gantt/*.ts	Moved from tests/gantt/ and updated import paths, added loadGantt metadata
e2e/testcafe-devextreme/tests/common/filterBuilder/*.ts	Moved from tests/filterBuilder/ and updated import paths
e2e/testcafe-devextreme/tests/cardView/headerFilter/remote.functional.ts	Added loadAspNetData metadata to tests requiring ASP.NET data
e2e/testcafe-devextreme/tests/accessibility/*.ts	Added loadQuill metadata and updated import paths
e2e/testcafe-devextreme/runner.ts	Implemented dynamic script loading logic based on test metadata, added debugging logs, commented out retry logic
e2e/testcafe-devextreme/helpers/themeUtils.ts	Refactored screenshot naming logic for better clarity
e2e/testcafe-devextreme/helpers/testPageUtils.ts	Added functions for dynamic loading of Quill, Gantt, ASP.NET Data, and DevExtreme scripts, fixed typo in comment
e2e/testcafe-devextreme/helpers/safeSizeTest.ts	Added support for test metadata in safeSizeTest function
e2e/testcafe-devextreme/helpers/accessibility/test.ts	Added support for test metadata in accessibility testing
.github/workflows/testcafe_tests.yml	Commented out treeList and pivotGrid test configurations

Copilot · 2025-10-20T15:16:24Z

e2e/testcafe-devextreme/tests/scheduler/common/grouping/groupHeaderLongNamesCss.ts

+  const pageHTML = await t.eval(() => document.documentElement.outerHTML);
+  console.log('=== 2FULL PAGE HTML ===');
+  console.log(pageHTML);
+
+  const bodyHTML = await t.eval(() => document.body.innerHTML);
+  console.log('=== 2BODY HTML ===');
+  console.log(bodyHTML);


Debug console.log statements should be removed before merging to production. These logging statements appear to be temporary debugging code that was left in the test.

Copilot · 2025-10-20T15:16:25Z

e2e/testcafe-devextreme/tests/scheduler/common/grouping/groupHeaderLongNamesCss.ts

+  console.log('=== FULL PAGE HTML ===');
+  console.log(pageHTML);
+
+  const bodyHTML = await t.eval(() => document.body.innerHTML);
+  console.log('=== BODY HTML ===');
+  console.log(bodyHTML);


Debug console.log statements should be removed before merging to production. These logging statements appear to be temporary debugging code that was left in the test before hook.

Suggested change

console.log('=== FULL PAGE HTML ===');

console.log(pageHTML);

const bodyHTML = await t.eval(() => document.body.innerHTML);

console.log('=== BODY HTML ===');

console.log(bodyHTML);

const bodyHTML = await t.eval(() => document.body.innerHTML);

Copilot · 2025-10-20T15:16:25Z

e2e/testcafe-devextreme/runner.ts

+// const LAUNCH_RETRY_ATTEMPTS = 5;
+// const LAUNCH_RETRY_TIMEOUT = 20000;


Commented-out retry constants suggest incomplete implementation. If retry logic is intentionally disabled, these constants should be removed; if retry functionality is still needed, the code should be uncommented and properly integrated.

Suggested change

// const LAUNCH_RETRY_ATTEMPTS = 5;

// const LAUNCH_RETRY_TIMEOUT = 20000;

Copilot · 2025-10-20T15:16:26Z

e2e/testcafe-devextreme/runner.ts

+          // eslint-disable-next-line no-plusplus
+          testRunCounter++;
+          console.log(`🔄 Test run #${testRunCounter} started`);


Debug console.log statement should be removed or replaced with proper logging mechanism for production code.

Copilot · 2025-10-20T15:16:26Z

e2e/testcafe-devextreme/runner.ts

+          const executionCount = testExecutionMap.get(name);
+          if (executionCount! > 1) {
+            console.log(`🔁 Test "${name}" - retry attempt #${executionCount}`);
+          } else {
+            console.log(`✅ Test "${name}" - first run`);


Debug console.log statements should be removed or replaced with proper logging mechanism for production code.

Copilot · 2025-10-20T15:16:26Z

e2e/testcafe-devextreme/runner.ts

+            // await loadScripts(t, 'axe.min.js', {
+            //   basePath: '../../../node_modules/axe-core/',
+            //   checkExists: 'axe',
+            // });


Commented-out code should be removed if no longer needed. If this is a temporary change or alternative implementation, add a comment explaining why it's preserved.

Suggested change

// await loadScripts(t, 'axe.min.js', {

// basePath: '../../../node_modules/axe-core/',

// checkExists: 'axe',

// });

Copilot · 2025-10-20T15:16:26Z

e2e/testcafe-devextreme/runner.ts

-    }
-    process.exit(1);
-  });
+  await testCafe.close();


The test runner closes TestCafe immediately without waiting for test execution to complete. The runner.run() call and result handling logic appears to be missing, which will cause tests to never execute.

Copilot · 2025-10-20T15:16:27Z

e2e/testcafe-devextreme/runner.ts

+// let testCafe: TestCafe;
+
+// createTestCafe(TESTCAFE_CONFIG)
+//   .then(async (tc: TestCafe) => {
+//     testCafe = tc;
+
+//     const args = getArgs();
+//     const testName = args.test.trim();
+//     const reporter = typeof args.reporter === 'string' ? args.reporter.trim() : args.reporter;
+//     const indices = args.indices.trim();
+//     let componentFolder = args.componentFolder.trim();
+//     const file = args.file.trim();
+
+//     setTestingPlatform(args);
+//     setTestingTheme(args);
+//     setShadowDom(args);
+
+//     componentFolder = componentFolder ? `${componentFolder}/**` : '**';
+//     if (fs.existsSync('./screenshots')) {
+//       fs.rmSync('./screenshots', { recursive: true });
+//     }
+
+//     const browsers = args.browsers


Large block of commented-out code (lines 352-560) should be removed. This appears to be the old implementation that has been replaced. If this code needs to be preserved for reference, it should be documented in version control history rather than kept as comments.

Suggested change

// let testCafe: TestCafe;

// createTestCafe(TESTCAFE_CONFIG)

// .then(async (tc: TestCafe) => {

// testCafe = tc;

// const args = getArgs();

// const testName = args.test.trim();

// const reporter = typeof args.reporter === 'string' ? args.reporter.trim() : args.reporter;

// const indices = args.indices.trim();

// let componentFolder = args.componentFolder.trim();

// const file = args.file.trim();

// setTestingPlatform(args);

// setTestingTheme(args);

// setShadowDom(args);

// componentFolder = componentFolder ? `${componentFolder}/**` : '**';

// if (fs.existsSync('./screenshots')) {

// fs.rmSync('./screenshots', { recursive: true });

// }

// const browsers = args.browsers

Copilot

Pull Request Overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 5 comments.

Copilot · 2025-10-22T17:57:49Z

e2e/testcafe-devextreme/tests/scheduler/common/grouping/groupHeaderLongNamesCss.ts

+  const pageHTML = await t.eval(() => document.documentElement.outerHTML);
+  console.log('=== FULL PAGE HTML ===');
+  console.log(pageHTML);
+
+  const bodyHTML = await t.eval(() => document.body.innerHTML);
+  console.log('=== BODY HTML ===');
+  console.log(bodyHTML);


Debug console.log statements should be removed before merging to production. These appear to be leftover debugging code from development.

Copilot · 2025-10-22T17:57:50Z

e2e/testcafe-devextreme/runner.ts

+// const wait = async (
+//   timeout: number,
+// // eslint-disable-next-line no-promise-executor-return
+// ): Promise<void> => new Promise((resolve) => setTimeout(resolve, timeout));
+
+// const retry = async <T>(action: () => Promise<T>, attempt: number): Promise<T> => {
+//   try {
+//     return await action();
+//   } catch (error) {
+//     if (attempt <= 1) {
+//       throw error;
+//     }
+
+//     /* eslint-disable no-console */
+//     console.log('\n > error occurred during testcafe launch!\n');
+//     console.error(error);
+//     console.info(`\n > waiting ${LAUNCH_RETRY_TIMEOUT / 1000} seconds...\n`);
+//     await wait(LAUNCH_RETRY_TIMEOUT);
+//     console.info('\n > retry launching testcafe\n');
+//     /* eslint-enable no-console */
+//     return retry(action, attempt - 1);
+//   }
+// };


Large blocks of commented-out code reduce code readability and maintainability. If this retry mechanism is no longer needed, it should be removed entirely. If there's a possibility of needing it again, consider documenting the reason for its removal in a comment or tracking it in version control history instead.

Copilot · 2025-10-22T17:57:50Z

e2e/testcafe-devextreme/runner.ts

+// let testCafe: TestCafe;
+
+// createTestCafe(TESTCAFE_CONFIG)
+//   .then(async (tc: TestCafe) => {


Over 200 lines of commented-out code (lines 358-566) significantly reduce code readability. This appears to be the old implementation before refactoring to async/await. Since this code is preserved in version control, it should be removed entirely from the file.

Copilot · 2025-10-22T17:57:51Z

e2e/testcafe-devextreme/helpers/testPageUtils.ts

+// interface LoadOptions {
+//   basePath?: string;
+//   checkExists?: string;
+// }
+
+// // async function loadResources(


Large blocks of commented-out code (lines 162-312) should be removed. This appears to be unused alternative implementations of resource loading. Since the code is tracked in version control, there's no need to keep it commented out in the source file.

Copilot · 2025-10-22T17:57:51Z

.github/workflows/testcafe_tests.yml

          { componentFolder: "dataGrid/sticky/fixed", name: "dataGrid / sticky (3/3)", indices: "3/3" },
          { componentFolder: "cardView", name: "cardView" },
          { componentFolder: "cardView", name: "cardView - material", theme: 'material.blue.light' },
          { componentFolder: "cardView", name: "cardView - fluent", theme: 'fluent.blue.light' },


The pivotGrid tests are commented out without explanation. Consider adding a comment explaining why these tests are disabled or create a tracking issue if this is temporary. YAML uses '#' for comments but mixing commented configuration with active configuration can lead to confusion.

Suggested change

{ componentFolder: "cardView", name: "cardView - fluent", theme: 'fluent.blue.light' },

{ componentFolder: "cardView", name: "cardView - fluent", theme: 'fluent.blue.light' },

# The following pivotGrid tests are temporarily disabled due to known instability/issues.

# See https://github.com/your-org/your-repo/issues/1234 for tracking and re-enabling.

Copilot

Pull Request Overview

Copilot reviewed 34 out of 38 changed files in this pull request and generated 5 comments.

Copilot · 2025-10-24T07:01:27Z

e2e/testcafe-devextreme/runner.ts

+  const testExecutionMap = new Map<string, number>();
+
+  const runOptions: RunOptions = {
+    quarantineMode: false, // { successThreshold: 1, attemptLimit: 1 },


Quarantine mode is disabled with commented configuration inline. If this is intentional, the comment should be removed; otherwise, the proper configuration should be uncommented.

Suggested change

quarantineMode: false, // { successThreshold: 1, attemptLimit: 1 },

quarantineMode: false,

Copilot · 2025-10-24T07:01:27Z

e2e/testcafe-devextreme/runner.ts

+          if (!componentFolder.includes('accessibility')) {
+            // @ts-expect-error ts-errors
+            const { meta } = t.testRun.test;
+            console.log('Test meta:', meta);


Debug console logging should be removed before merging. This appears to be temporary debugging output.

Suggested change

console.log('Test meta:', meta);

Copilot · 2025-10-24T07:01:27Z

e2e/testcafe-devextreme/runner.ts

+        before: async () => {
+          // eslint-disable-next-line no-plusplus
+          testRunCounter++;
+          console.log(`🔄 Test run #${testRunCounter} started`);


Debug console logging should be removed or converted to a proper logger before merging. Multiple console.log statements for test execution tracking appear to be temporary debugging code.

Copilot · 2025-10-24T07:01:27Z

e2e/testcafe-devextreme/runner.ts

+
+          const executionCount = testExecutionMap.get(name);
+          if (executionCount! > 1) {
+            console.log(`🔁 Test "${name}" - retry attempt #${executionCount}`);


Debug console logging should be removed or converted to a proper logger before merging. Multiple console.log statements for test execution tracking appear to be temporary debugging code.

Copilot · 2025-10-24T07:01:28Z

e2e/testcafe-devextreme/runner.ts

+          if (executionCount! > 1) {
+            console.log(`🔁 Test "${name}" - retry attempt #${executionCount}`);
+          } else {
+            console.log(`✅ Test "${name}" - first run`);


Debug console logging should be removed or converted to a proper logger before merging. Multiple console.log statements for test execution tracking appear to be temporary debugging code.

EugeniyKiyashko self-assigned this Oct 16, 2025

EugeniyKiyashko requested review from a team as code owners October 16, 2025 19:59

EugeniyKiyashko force-pushed the 25_2_split_a11y_tests_speedup branch 6 times, most recently from 4c27b16 to 6a3cd89 Compare October 17, 2025 11:34

EugeniyKiyashko changed the title ~~e2e tests: move Gantt, FilterBuilder, Pagination to common folder~~ e2e tests: move Gantt, FilterBuilder, Pagination, TreeList to common folder Oct 17, 2025

EugeniyKiyashko force-pushed the 25_2_split_a11y_tests_speedup branch 2 times, most recently from 679aefd to d7d08a3 Compare October 17, 2025 17:45

EugeniyKiyashko changed the title ~~e2e tests: move Gantt, FilterBuilder, Pagination, TreeList to common folder~~ e2e tests: move Gantt, FilterBuilder, Pagination to common folder Oct 17, 2025

EugeniyKiyashko force-pushed the 25_2_split_a11y_tests_speedup branch 2 times, most recently from b938314 to bfff62b Compare October 20, 2025 15:14

Copilot AI review requested due to automatic review settings October 20, 2025 15:14

Copilot AI reviewed Oct 20, 2025

View reviewed changes

EugeniyKiyashko force-pushed the 25_2_split_a11y_tests_speedup branch from bfff62b to d7ef866 Compare October 20, 2025 19:03

EugeniyKiyashko changed the title ~~e2e tests: move Gantt, FilterBuilder, Pagination to common folder~~ e2e components tests: speed up tests execution Oct 22, 2025

Copilot AI review requested due to automatic review settings October 22, 2025 17:55

Copilot AI reviewed Oct 22, 2025

View reviewed changes

changes

021a22c

EugeniyKiyashko force-pushed the 25_2_split_a11y_tests_speedup branch from 76cd081 to 021a22c Compare October 24, 2025 05:28

update configuration

ebfb80d

Copilot AI review requested due to automatic review settings October 24, 2025 06:59

Copilot AI reviewed Oct 24, 2025

View reviewed changes

		// const LAUNCH_RETRY_ATTEMPTS = 5;
		// const LAUNCH_RETRY_TIMEOUT = 20000;

	quarantineMode: false, // { successThreshold: 1, attemptLimit: 1 },
	quarantineMode: false,

e2e components tests: speed up tests execution #31379

Are you sure you want to change the base?

e2e components tests: speed up tests execution #31379

Uh oh!

Conversation

EugeniyKiyashko commented Oct 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development