Replace shortid to nanoid #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 2ccdf22 have failed. See details: |
1 similar comment
|
❌ Tests for the commit 2ccdf22 have failed. See details: |
|
Hello @ai ! Thank you, nice job! I'll figure out why tests are failing, likely it's something with Firefox on Browserstack. So your PR will be merged when I resolve issues with tests. One more point: we are using |
|
You are awesome! |
|
❌ Tests for the commit 2ccdf22 have failed. See details: |
|
✅ Tests for the commit 71491cd have passed. See details: |
AlexanderMoskovkin
approved these changes
Nov 29, 2017
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think of replacing
shortidtonanoid(without big changes for users). Benefits:shortidis not maintained anymore (and issue tracker has many important issues). I tried to took maintenance, but found that I can’t fixshortidwith keeping API.shortidhas problem with random generator (issue) and ID uniformity (issue).nanoiduse hardware random generator and has special uniformity tests (docs).shortidhas the problem with-symbol in the end of URL on some Android app (issue).nanoiduses safe~instead of-.nanoidis 10x times faster thanshortid.@AlexanderMoskovkin @AndreyBelym what do you think?