Skip to content

Conversation

@DevQps
Copy link
Owner

@DevQps DevQps commented Feb 21, 2022

Description

This commit fixes a few things:

  • It includes the README examples in the documentation tests.
  • It fixes broken code that constructed malformed URLs.
  • Generates error messages if listings for the future are requested.
  • Generates error messages if listings for "today" are being requested for RIPE and LACNIC (they do not provide this).
  • Refactored the download method in async.

Fixes #4 - ARIN restructured the FTP such that extended listings prior to this are available.

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #10 (05a326c) into master (50c7e88) will increase coverage by 3.24%.
The diff coverage is 78.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   88.99%   92.23%   +3.24%     
==========================================
  Files           3        3              
  Lines         109      103       -6     
==========================================
- Hits           97       95       -2     
+ Misses         12        8       -4     
Impacted Files Coverage Δ
src/lib.rs 97.77% <ø> (-2.23%) ⬇️
src/download.rs 85.71% <77.41%> (+8.35%) ⬆️
tests/readme.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c7e88...05a326c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support downloading RSEF listings prior to 2017 for ARIN

2 participants