Decode JSON Pointer segments and handle numeric path variants for Monaco highlighting#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
selectedNode.idis a JSON Pointer with percent-encoding or RFC6901 escapes (~1,~0).Description
decodePointerSegmentto decode percent-encoded pointer segments and unescape~1and~0sequences.buildPathCandidatesto produce candidate path arrays that include both string and numeric versions for numeric segments.parseDocument/getIn) and JSON (parseTree/findNodeAtLocation) and pick the first valid node with a range or offset for highlighting.try/catchto prevent exceptions from breaking the effect and update effect dependencies to includeschemaFormatandschemaTextso highlights refresh on format/text changes.Testing
yarn testand all tests completed successfully.yarn lintand no issues were reported.schemaFormatand whenschemaTextchanges via automated test coverage and CI checks.Codex Task