Improve JSON Pointer decoding and robust node highlighting in MonacoEditor#5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
selectedNode.idcontains URI-encoded or tilde-escaped JSON Pointer segments.Description
decodePointerSegmentto safelydecodeURIComponentpointer segments and unescape~1/~0sequences with a fallback for malformed segments.buildPathCandidatesto generate candidate paths that try numeric segments as both strings and numbers, and use these candidates when locating nodes in YAML (getIn) or JSON (findNodeAtLocation) ASTs.try/catchand select the first candidate node that contains arange, then compute start/end positions from that node.schemaFormatandschemaTextto the effect dependencies.Testing
yarn test, and all tests passed.yarn buildto confirm type correctness, which succeeded.yarn lint, which completed without errors.Codex Task