feat: add initial implementation of history threats #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `get_attacked_squares` public so we can use it for threat detection. bench: 1176279
bench: 1176279
DeveloperPaul123
commented
Dec 2, 2025
Comment on lines
+101
to
+105
| let grid = self.table[side as usize][piece_type][square]; | ||
| print!( | ||
| "{:5} | {:5}\n------\n[{:5} | {:5} ]", | ||
| grid[0][0], grid[0][1], grid[1][0], grid[1][1] | ||
| ); |
Owner
Author
There was a problem hiding this comment.
Haven't actually tested this to see what it looks like - might have broken things.
| let history_table = HistoryTable::new(); | ||
| // loop through all sides, piece types, and squares | ||
| for side in 0..2 { | ||
| for side in 0..2u8 { |
Owner
Author
There was a problem hiding this comment.
Use the actual enum type here Side
| // loop through all sides, piece types, and squares | ||
| for side in 0..2 { | ||
| for side in 0..2u8 { | ||
| for piece_type in 0..6 { |
Owner
Author
There was a problem hiding this comment.
Same here, use Piece directly
Use move gens `is_square_attacked` function instead. bench: 1176279
DeveloperPaul123
force-pushed
the
feature/hist-threat
branch
from
ba16707 to
745c184
Compare
DeveloperPaul123
force-pushed
the
main
branch
from
600caf2 to
21b4ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
is_from_attackedandis_to_attackedflags.See #166
bench: 1176279