Skip to content

Fix Scoop update/uninstall failing for packages installed via manifest URL #4594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit into from
Apr 16, 2026
+4 −3
Merged

Fix Scoop update/uninstall failing for packages installed via manifest URL #4594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/UniGetUI.PackageEngine.Managers.Scoop/Helpers/ScoopPkgDetailsHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,11 @@ protected override void GetDetails_UnSafe(IPackageDetails details)
}

string packageId;
// If source is ellpised or source is a local path, omit source argument
// If source is ellipsed, a local path, or a URL manifest, omit source argument
if (
details.Package.Source.Name.Contains("...")
|| details.Package.Source.Name.Contains(":\\")
|| details.Package.Source.Name.StartsWith("http")
)
packageId = $"{details.Package.Id}";
else
Expand Down
4 changes: 2 additions & 2 deletions src/UniGetUI.PackageEngine.Managers.Scoop/Helpers/ScoopPkgOperationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ OperationType operation
},
];

// If source is ellpised or source is a local path, omit source argument
if (package.Source.Name.Contains("...") || package.Source.Name.Contains(":\\"))
// If source is ellipsed, a local path, or a URL manifest, omit source argument
if (package.Source.Name.Contains("...") || package.Source.Name.Contains(":\\") || package.Source.Name.StartsWith("http"))
parameters.Add($"{package.Id}");
else
parameters.Add($"{package.Source.Name}/{package.Id}");
Expand Down
Loading